Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NFS over REST #46519

Merged
merged 52 commits into from
Nov 15, 2024
Merged

NFS over REST #46519

merged 52 commits into from
Nov 15, 2024

Conversation

seanmcc-msft
Copy link
Member

@seanmcc-msft seanmcc-msft commented Oct 10, 2024 •
edited
Loading

TODO

  • Fix existing CI
  • Remember to update Changelogs breaking changes section

@github-actions github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label Oct 10, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 10, 2024 •
edited
Loading

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.Storage.Files.Shares

@seanmcc-msft
Copy link
Member Author

TODO may need to make Create Symbolic Link, Get Symbolic Link, and Create Hard Link internal if the Files team moves these to STG 98

@seanmcc-msft
Copy link
Member Author

TODO make Create Symbolic Link and Get Symbolic Link internal

amnguye
amnguye approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@amnguye amnguye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a few comments and a question

sdk/storage/Azure.Storage.Files.Shares/tests/FileClientTests.cs Outdated Show resolved Hide resolved
sdk/storage/Azure.Storage.Files.Shares/src/Models/RolePermissionExtensions.cs Show resolved Hide resolved
sdk/storage/Azure.Storage.Files.Shares/src/ShareDirectoryClient.cs Show resolved Hide resolved
sdk/storage/Azure.Storage.Files.Shares/src/ShareFileClient.cs Outdated Show resolved Hide resolved
@seanmcc-msft seanmcc-msft merged commit 8df4419 into Azure:feature/storage/stg97base Nov 15, 2024
17 checks passed
@seanmcc-msft seanmcc-msft deleted the feature/storage/nfsOverRest branch November 15, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weirongw23-msft weirongw23-msft weirongw23-msft approved these changes

@amnguye amnguye amnguye approved these changes

@jaschrep-msft jaschrep-msft Awaiting requested review from jaschrep-msft jaschrep-msft is a code owner

@schaabs schaabs Awaiting requested review from schaabs schaabs is a code owner

@tg-msft tg-msft Awaiting requested review from tg-msft tg-msft is a code owner

@jalauzon-msft jalauzon-msft Awaiting requested review from jalauzon-msft jalauzon-msft is a code owner

@nickliu-msft nickliu-msft Awaiting requested review from nickliu-msft nickliu-msft is a code owner

Assignees
No one assigned
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seanmcc-msft @azure-sdk @amnguye @weirongw23-msft