Azure OpenAI updates #46103
Merged
Azure OpenAI updates #46103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ralph-msft
commented
Sep 20, 2024
ralph-msft
commented
- Nuget package updates:
- System.ClientModel to version 1.1.0
- OpenAI to version 2.0.0-beta.12
- Latest API updates for Azure OpenAI
--------- Co-authored-by: Anne Thompson <[email protected]>
ralph-msft
requested review from
JoshLove-msft,
christothes,
annelo-msft,
KrzysztofCwalina,
tg-msft,
jsquire,
m-nash,
ArthurMa1978,
jpalvarezl,
trrwilson and
joseharriaga
as code owners
|
API change check API changes are not detected in this pull request. |
annelo-msft
reviewed
Sep 20, 2024
There was a problem hiding this comment.
How many of the workaround noted in #45996 will we be able to remove as part of this PR? I am very excited about removing those so issues around repo-wide updates like @m-redding's STJ upgrade will be caught earlier in the future.
Specifically, can we remove the workarounds we introduced in:
- SCM: Remove PageCollection types in favor of using CollectionResult #45961
- Skip project reference tests for openai #44896
- ClientModel: Updates to paging types to support sub-client enumerator pattern #44825
?
@benbp as FYI as well
annelo-msft
reviewed
Sep 20, 2024
jsquire
previously requested changes
Sep 20, 2024
annelo-msft
reviewed
Sep 20, 2024
annelo-msft
reviewed
Sep 20, 2024
ralph-msft
requested review from
ShivangiReja,
kinelski and
a team
as code owners
annelo-msft
reviewed
Sep 20, 2024
annelo-msft
approved these changes
Sep 20, 2024
trrwilson
approved these changes
Sep 20, 2024
jsquire
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.