Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] [WebJobs] Adding back in fix for WebJobs Extension Queue Length #45968

Merged
merged 1 commit into from
Sep 13, 2024
Merged

[Storage] [WebJobs] Adding back in fix for WebJobs Extension Queue Length #45968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...crosoft.Azure.WebJobs.Extensions.Storage.Common/src/Shared/Queues/QueueMetricsProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ public async Task<int> GetQueueLengthAsync()
{
try
{
QueueProperties queueProperties = await _queue.GetPropertiesAsync().ConfigureAwait(false);
return queueProperties.ApproximateMessagesCount;
QueueTriggerMetrics queueMetrics = await GetMetricsAsync().ConfigureAwait(false);
return queueMetrics.QueueLength;
}
catch (RequestFailedException ex)
{
Expand Down
7 changes: 2 additions & 5 deletions sdk/storage/Microsoft.Azure.WebJobs.Extensions.Storage.Queues/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,17 @@

## 5.4.0-beta.1 (Unreleased)

### Features Added

### Breaking Changes

### Bugs Fixed
- When grabbing Queue Metrics for amount of messages, will now use the QueueTriggerMetrics.QueueLength instead of the ApproximateMessagesCount for less stale metrics.

### Other Changes
- Improvement in logging exceptions when retrieving queue metrics.

## 5.3.1 (2024-07-17)

### Bugs Fixed
- Rely on PeekMessagesAsync when calculating message queue length
- Fixing target base scale instance concurrency for queues
- When grabbing Queue Metrics for amount of messages, will now use the QueueTriggerMetrics.QueueLength instead of the ApproximateMessagesCount for less stale metrics.

## 5.3.0 (2024-04-18)
- Includes all features from 5.3.0-beta.1.
Expand Down