Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix error replacement holder #45915

Merged
merged 1 commit into from
Sep 12, 2024
Merged

fix error replacement holder #45915

merged 1 commit into from
Sep 12, 2024

Conversation

welovej
Copy link
Member

@welovej welovej commented Sep 12, 2024

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@live1206
Copy link
Member

live1206 commented Sep 12, 2024 •
edited
Loading

LGTM @welovej although have you tried with the updated template to regenerate for #45890 to make sure everything looks good?

@welovej welovej marked this pull request as ready for review September 12, 2024 05:08
@welovej
Copy link
Member Author

welovej commented Sep 12, 2024 •
edited
Loading

LGTM @welovej although have you tried with the updated template to regenerate for #45890 to make sure everything looks good?
Hi @live1206
yes, the last update PR involed with one name changing that used
LowercaseProviderShortName instead of ProviderNameLowercase. And I searched ./Azure.ResourceManager.Templateglobally, there is no ProviderNameLowercase occurence any more.
Please approve it twice so that this PRcan be merged.

@live1206 live1206 merged commit 6f2f450 into Azure:main Sep 12, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@live1206 live1206 live1206 approved these changes

@hallipr hallipr Awaiting requested review from hallipr hallipr is a code owner

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard is a code owner

@benbp benbp Awaiting requested review from benbp benbp is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@welovej @live1206