Fix a few Azure.Provisioning issues
#45911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on, changing the entropy source for RGs, avoiding Location on existing resources, sorting params/outputs, fixing params in interpolation, adding an overload of AssignRole not tied to user assigned identities, and making a few helpful APIs public. This also adds back part of the InfrastructureResolver module splitting prototype to sort params/outputs generically.
sdk/provisioning/Azure.Provisioning.AppConfiguration/src/Generated/AppConfigurationStore.cs
Outdated
Show resolved
Hide resolved
sdk/provisioning/Azure.Provisioning/src/Primitives/ProvisioningConstruct.cs
Show resolved
Hide resolved
JoshLove-msft
approved these changes
Sep 11, 2024
16 tasks
|
/check-enforcer evaluate |
eerhardt
reviewed
Sep 11, 2024
sdk/provisioning/Azure.Provisioning.AppConfiguration/tests/BasicAppConfigurationTests.cs
Show resolved
Hide resolved
eerhardt
reviewed
Sep 11, 2024
eerhardt
reviewed
Sep 11, 2024
sdk/provisioning/Azure.Provisioning/api/Azure.Provisioning.netstandard2.0.cs
Show resolved
Hide resolved
eerhardt
approved these changes
Sep 11, 2024
|
/check-enforcer evaluate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a few
Azure.Provisioningissues including using params forLocation, changing the entropy source for RGs, avoidingLocationonexistingresources, sorting params/outputs, fixing params in interpolation, adding an overload ofAssignRolenot tied to user assigned identities, and making a few helpful APIs public. This also adds back part of theInfrastructureResolvermodule splitting prototype to sort params/outputs generically.