Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using federated auth for ACS tests #44886

Merged
merged 4 commits into from
Jul 18, 2024
Merged

Using federated auth for ACS tests #44886

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9dd0388
Using federated auth for ACS tests
rajuanitha88 Jul 7, 2024
0783c43
Removing usage of secrets for Shortcodes
rajuanitha88 Jul 7, 2024
51f6dde
Removing PPE and INT Live tests
rajuanitha88 Jul 12, 2024
62596e5
Addressing comments to maintain consistency across languages
rajuanitha88 Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions sdk/communication/Azure.Communication.CallAutomation/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,13 @@ extends:
parameters:
ServiceDirectory: communication
Project: Azure.Communication.CallAutomation
UseFederatedAuth: true
CloudConfig:
Public:
ServiceConnection: azure-sdk-tests
SubscriptionConfigurationFilePaths:
- eng/common/TestResources/sub-config/AzurePublicMsft.json
SubscriptionConfigurations:
- $(sub-config-azure-cloud-test-resources)
- $(sub-config-communication-services-cloud-test-resources-common)
- $(sub-config-communication-services-cloud-test-resources-net)
Int:
Expand All @@ -17,7 +20,7 @@ extends:
- $(sub-config-communication-int-test-resources-net)
Clouds: Public
TestResourceDirectories:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is just the root now you can remove this entire setting as that is the default.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, how were these test deployments working before this change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think it was for some of the other ACS SDKs. We fixed this as part of this work.

- communication/test-resources/
- communication/
EnvVars:
# SKIP_CALLAUTOMATION_INTERACTION_LIVE_TESTS skips certain CallAutomation tests that required human interactions
SKIP_CALLAUTOMATION_INTERACTION_LIVE_TESTS: TRUE
7 changes: 5 additions & 2 deletions sdk/communication/Azure.Communication.CallingServer/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,13 @@ extends:
parameters:
ServiceDirectory: communication
Project: Azure.Communication.CallingServer
UseFederatedAuth: true
CloudConfig:
Public:
ServiceConnection: azure-sdk-tests
SubscriptionConfigurationFilePaths:
- eng/common/TestResources/sub-config/AzurePublicMsft.json
SubscriptionConfigurations:
- $(sub-config-azure-cloud-test-resources)
- $(sub-config-communication-services-cloud-test-resources-common)
- $(sub-config-communication-services-cloud-test-resources-net)
Int:
Expand All @@ -17,7 +20,7 @@ extends:
- $(sub-config-communication-int-test-resources-net)
Clouds: Public
TestResourceDirectories:
- communication/test-resources/
- communication/
EnvVars:
# SKIP_CALLINGSERVER_INTERACTION_LIVE_TESTS skips certain CallAutomation tests that required human interactions
SKIP_CALLINGSERVER_INTERACTION_LIVE_TESTS: TRUE
7 changes: 5 additions & 2 deletions sdk/communication/Azure.Communication.Chat/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,13 @@ extends:
parameters:
ServiceDirectory: communication
Project: Azure.Communication.Chat
UseFederatedAuth: true
CloudConfig:
Public:
ServiceConnection: azure-sdk-tests
SubscriptionConfigurationFilePaths:
- eng/common/TestResources/sub-config/AzurePublicMsft.json
SubscriptionConfigurations:
- $(sub-config-azure-cloud-test-resources)
- $(sub-config-communication-services-cloud-test-resources-common)
- $(sub-config-communication-services-cloud-test-resources-net)
PPE:
Expand All @@ -21,4 +24,4 @@ extends:
- $(sub-config-communication-int-test-resources-net)
Clouds: Public,PPE,Int
TestResourceDirectories:
- communication/test-resources/
- communication/
8 changes: 5 additions & 3 deletions sdk/communication/Azure.Communication.Identity/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,14 @@ extends:
parameters:
ServiceDirectory: communication
Project: Azure.Communication.Identity
UseFederatedAuth: true
CloudConfig:
Public:
ServiceConnection: azure-sdk-tests
SubscriptionConfigurationFilePaths:
- eng/common/TestResources/sub-config/AzurePublicMsft.json
SubscriptionConfigurations:
- $(sub-config-azure-cloud-test-resources)
- $(sub-config-communication-services-cloud-test-resources-common)
- $(sub-config-communication-services-cloud-test-resources-net)
- $(sub-config-communication-services-cloud-test-resources-cte)
PPE:
SubscriptionConfigurations:
- $(sub-config-communication-ppe-test-resources-common)
Expand Down
7 changes: 5 additions & 2 deletions sdk/communication/Azure.Communication.JobRouter/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,13 @@ extends:
parameters:
ServiceDirectory: communication
Project: Azure.Communication.JobRouter
UseFederatedAuth: true
CloudConfig:
Public:
ServiceConnection: azure-sdk-tests
SubscriptionConfigurationFilePaths:
- eng/common/TestResources/sub-config/AzurePublicMsft.json
SubscriptionConfigurations:
- $(sub-config-azure-cloud-test-resources)
- $(sub-config-communication-services-cloud-test-resources-common)
- $(sub-config-communication-services-cloud-test-resources-net)
Int:
Expand All @@ -17,4 +20,4 @@ extends:
- $(sub-config-communication-int-test-resources-net)
Clouds: Public,Int
TestResourceDirectories:
- communication/test-resources/
- communication/
5 changes: 4 additions & 1 deletion sdk/communication/Azure.Communication.Rooms/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,13 @@ extends:
parameters:
ServiceDirectory: communication
Project: Azure.Communication.Rooms
UseFederatedAuth: true
CloudConfig:
Public:
ServiceConnection: azure-sdk-tests
SubscriptionConfigurationFilePaths:
- eng/common/TestResources/sub-config/AzurePublicMsft.json
SubscriptionConfigurations:
- $(sub-config-azure-cloud-test-resources)
- $(sub-config-communication-services-cloud-test-resources-common)
- $(sub-config-communication-services-cloud-test-resources-net)
PPE:
Expand Down
7 changes: 5 additions & 2 deletions sdk/communication/Azure.Communication.ShortCodes/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,13 @@ extends:
parameters:
ServiceDirectory: communication
Project: Azure.Communication.ShortCodes
UseFederatedAuth: true
CloudConfig:
Public:
ServiceConnection: azure-sdk-tests
SubscriptionConfigurationFilePaths:
- eng/common/TestResources/sub-config/AzurePublicMsft.json
SubscriptionConfigurations:
- $(sub-config-azure-cloud-test-resources)
- $(sub-config-communication-services-cloud-test-resources-common)
- $(sub-config-communication-services-cloud-test-resources-net)
Int:
Expand All @@ -17,4 +20,4 @@ extends:
- $(sub-config-communication-int-test-resources-net)
Clouds: Public,Int
TestResourceDirectories:
- communication/test-resources/
- communication/