Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid ServiceBusSenderOptions allocations #44856

Merged
merged 1 commit into from
Jul 4, 2024

Avoid ServiceBusSenderOptions allocations

c007c12
Select commit
Loading
Failed to load commit list.
Merged

Avoid ServiceBusSenderOptions allocations #44856

Avoid ServiceBusSenderOptions allocations
c007c12
Select commit
Loading
Failed to load commit list.
Azure Pipelines / net - servicebus - tests succeeded Jul 4, 2024 in 43m 27s

Build #20240703.2 had test failures

0 errors / 14 warnings

Details

Tests

  • Failed: 9 (0.04%)
  • Passed: 23,385 (99.51%)
  • Other: 105 (0.45%)
  • Total: 23,499
Code coverage

  • 2774 of 3818 branches covered (72.66%)
  • 10391 of 12447 lines covered (83.48%)

Annotations

Check failure on line 1 in Azure.Messaging.ServiceBus.Tests.Receiver.ReceiverLiveTests.ReceiverThrowsWhenUsingSessionEntity

See this annotation in the file changed.

@azure-pipelines azure-pipelines / net - servicebus - tests

Azure.Messaging.ServiceBus.Tests.Receiver.ReceiverLiveTests.ReceiverThrowsWhenUsingSessionEntity 

Azure.Messaging.ServiceBus.ServiceBusException : Service request failed.
Status: 503 (Service Unavailable)

Content:
<Error><Code>503</Code><Detail>SubCode=50004. The request was terminated because the namespace sb-t6338608ca9964009 is being throttled. Error code : 50009. Please wait 2 seconds and try again. To know more visit https://aka.ms/sbResourceMgrExceptions and https://aka.ms/ServiceBusThrottling TrackingId:f2dba89a-ae7e-49d1-981a-e644029b50e6_G7_B3, SystemTracker:sb-t6338608ca9964009:Queue:55067296-c74c-receiverthrowsw, Timestamp:2024-07-03T20:44:28</Detail></Error>

Headers:
Transfer-Encoding: chunked
Server: Microsoft-HTTPAPI/2.0
Strict-Transport-Security: REDACTED
Date: Wed, 03 Jul 2024 20:44:28 GMT
Content-Type: application/xml; charset=utf-8
 (ServiceBusy). For troubleshooting information, see https://aka.ms/azsdk/net/servicebus/exceptions/troubleshoot.
  ----> Azure.RequestFailedException : Service request failed.
Status: 503 (Service Unavailable)

Content:
<Error><Code>503</Code><Detail>SubCode=50004. The request was terminated because the namespace sb-t6338608ca9964009 is being throttled. Error code : 50009. Please wait 2 seconds and try again. To know more visit https://aka.ms/sbResourceMgrExceptions and https://aka.ms/ServiceBusThrottling TrackingId:f2dba89a-ae7e-49d1-981a-e644029b50e6_G7_B3, SystemTracker:sb-t6338608ca9964009:Queue:55067296-c74c-receiverthrowsw, Timestamp:2024-07-03T20:44:28</Detail></Error>

Headers:
Transfer-Encoding: chunked
Server: Microsoft-HTTPAPI/2.0
Strict-Transport-Security: REDACTED
Date: Wed, 03 Jul 2024 20:44:28 GMT
Content-Type: application/xml; charset=utf-8
Raw output 
   at Azure.Messaging.ServiceBus.Administration.HttpRequestAndResponse.ThrowIfRequestFailed(Request request, Response response) in /_/sdk/servicebus/Azure.Messaging.ServiceBus/src/Administration/HttpRequestAndResponse.cs:line 108
   at Azure.Messaging.ServiceBus.Administration.HttpRequestAndResponse.SendHttpRequestAsync(Request request, CancellationToken cancellationToken) in /_/sdk/servicebus/Azure.Messaging.ServiceBus/src/Administration/HttpRequestAndResponse.cs:line 277
   at Azure.Messaging.ServiceBus.Administration.HttpRequestAndResponse.PutEntityAsync(String entityPath, String requestBody, Boolean isUpdate, String forwardTo, String fwdDeadLetterTo, CancellationToken cancellationToken) in /_/sdk/servicebus/Azure.Messaging.ServiceBus/src/Administration/HttpRequestAndResponse.cs:line 236
   at Azure.Messaging.ServiceBus.Administration.ServiceBusAdministrationClient.CreateQueueAsync(CreateQueueOptions options, CancellationToken cancellationToken) in /_/sdk/servicebus/Azure.Messaging.ServiceBus/src/Administration/ServiceBusAdministrationClient.cs:line 1605
   at Azure.Messaging.ServiceBus.Tests.ServiceBusScope.CreateWithQueue(Boolean enablePartitioning, Boolean enableSession, Nullable`1 lockDuration, Boolean useSecondaryNamespace, Nullable`1 defaultMessageTimeToLive, String caller) in D:\a\_work\1\s\sdk\servicebus\Azure.Messaging.ServiceBus\tests\Infrastructure\ServiceBusScope.cs:line 77
   at Azure.Messaging.ServiceBus.Tests.Receiver.ReceiverLiveTests.ReceiverThrowsWhenUsingSessionEntity() in D:\a\_work\1\s\sdk\servicebus\Azure.Messaging.ServiceBus\tests\Receiver\ReceiverLiveTests.cs:line 1032
   at NUnit.Framework.Internal.TaskAwaitAdapter.GenericAdapter`1.BlockUntilCompleted()
   at NUnit.Framework.Internal.MessagePumpStrategy.NoMessagePumpStrategy.WaitForCompletion(AwaitAdapter awaiter)
   at NUnit.Framework.Internal.AsyncToSyncAdapter.Await(Func`1 invoke)
   at NUnit.Framework.Internal.Commands.TestMethodCommand.RunTestMethod(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.TestMethodCommand.Execute(TestExecutionContext context)
   at NUnit.Framework.Internal.Execution.SimpleWorkItem.<>c__DisplayClass4_0.<PerformWork>b__0()
   at NUnit.Framework.Internal.ContextUtils.<>c__DisplayClass1_0`1.<DoIsolated>b__0(Object _)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   at NUnit.Framework.Internal.ContextUtils.DoIsolated(ContextCallback callback, Object state)
   at NUnit.Framework.Internal.ContextUtils.DoIsolated[T](Func`1 func)
   at NUnit.Framework.Internal.Execution.SimpleWorkItem.PerformWork()
--RequestFailedException

Check failure on line 1 in Azure.Messaging.ServiceBus.Tests.Receiver.ReceiverLiveTests.ReceiveDeferredMessagesReactsToClosingTheClient

See this annotation in the file changed.

@azure-pipelines azure-pipelines / net - servicebus - tests

Azure.Messaging.ServiceBus.Tests.Receiver.ReceiverLiveTests.ReceiveDeferredMessagesReactsToClosingTheClient 

Azure.Messaging.ServiceBus.ServiceBusException : Service request failed.
Status: 503 (Service Unavailable)

Content:
<Error><Code>503</Code><Detail>SubCode=50004. The request was terminated because the namespace sb-t6338608ca9964009 is being throttled. Error code : 50009. Please wait 2 seconds and try again. To know more visit https://aka.ms/sbResourceMgrExceptions and https://aka.ms/ServiceBusThrottling TrackingId:d536dbdc-0375-43ec-8224-f672e8226e5a_G7_B6, SystemTracker:sb-t6338608ca9964009:Queue:520718e1-e2d6-receivedeferred, Timestamp:2024-07-03T20:43:50</Detail></Error>

Headers:
Transfer-Encoding: chunked
Server: Microsoft-HTTPAPI/2.0
Strict-Transport-Security: REDACTED
Date: Wed, 03 Jul 2024 20:43:50 GMT
Content-Type: application/xml; charset=utf-8
 (ServiceBusy). For troubleshooting information, see https://aka.ms/azsdk/net/servicebus/exceptions/troubleshoot.
  ----> Azure.RequestFailedException : Service request failed.
Status: 503 (Service Unavailable)

Content:
<Error><Code>503</Code><Detail>SubCode=50004. The request was terminated because the namespace sb-t6338608ca9964009 is being throttled. Error code : 50009. Please wait 2 seconds and try again. To know more visit https://aka.ms/sbResourceMgrExceptions and https://aka.ms/ServiceBusThrottling TrackingId:d536dbdc-0375-43ec-8224-f672e8226e5a_G7_B6, SystemTracker:sb-t6338608ca9964009:Queue:520718e1-e2d6-receivedeferred, Timestamp:2024-07-03T20:43:50</Detail></Error>

Headers:
Transfer-Encoding: chunked
Server: Microsoft-HTTPAPI/2.0
Strict-Transport-Security: REDACTED
Date: Wed, 03 Jul 2024 20:43:50 GMT
Content-Type: application/xml; charset=utf-8
Raw output 
   at Azure.Messaging.ServiceBus.Administration.HttpRequestAndResponse.ThrowIfRequestFailed(Request request, Response response) in /_/sdk/servicebus/Azure.Messaging.ServiceBus/src/Administration/HttpRequestAndResponse.cs:line 108
   at Azure.Messaging.ServiceBus.Administration.HttpRequestAndResponse.SendHttpRequestAsync(Request request, CancellationToken cancellationToken) in /_/sdk/servicebus/Azure.Messaging.ServiceBus/src/Administration/HttpRequestAndResponse.cs:line 277
   at Azure.Messaging.ServiceBus.Administration.HttpRequestAndResponse.PutEntityAsync(String entityPath, String requestBody, Boolean isUpdate, String forwardTo, String fwdDeadLetterTo, CancellationToken cancellationToken) in /_/sdk/servicebus/Azure.Messaging.ServiceBus/src/Administration/HttpRequestAndResponse.cs:line 236
   at Azure.Messaging.ServiceBus.Administration.ServiceBusAdministrationClient.CreateQueueAsync(CreateQueueOptions options, CancellationToken cancellationToken) in /_/sdk/servicebus/Azure.Messaging.ServiceBus/src/Administration/ServiceBusAdministrationClient.cs:line 1605
   at Azure.Messaging.ServiceBus.Tests.ServiceBusScope.CreateWithQueue(Boolean enablePartitioning, Boolean enableSession, Nullable`1 lockDuration, Boolean useSecondaryNamespace, Nullable`1 defaultMessageTimeToLive, String caller) in D:\a\_work\1\s\sdk\servicebus\Azure.Messaging.ServiceBus\tests\Infrastructure\ServiceBusScope.cs:line 77
   at Azure.Messaging.ServiceBus.Tests.Receiver.ReceiverLiveTests.ReceiveDeferredMessagesReactsToClosingTheClient() in D:\a\_work\1\s\sdk\servicebus\Azure.Messaging.ServiceBus\tests\Receiver\ReceiverLiveTests.cs:line 1602
   at NUnit.Framework.Internal.TaskAwaitAdapter.GenericAdapter`1.BlockUntilCompleted()
   at NUnit.Framework.Internal.MessagePumpStrategy.NoMessagePumpStrategy.WaitForCompletion(AwaitAdapter awaiter)
   at NUnit.Framework.Internal.AsyncToSyncAdapter.Await(Func`1 invoke)
   at NUnit.Framework.Internal.Commands.TestMethodCommand.RunTestMethod(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.TestMethodCommand.Execute(TestExecutionContext context)
   at NUnit.Framework.Internal.Execution.SimpleWorkItem.<>c__DisplayClass4_0.<PerformWork>b__0()
   at NUnit.Framework.Internal.ContextUtils.<>c__DisplayClass1_0`1.<DoIsolated>b__0(Object _)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   at NUnit.Framework.Internal.ContextUtils.DoIsolated(ContextCallback callback, Object state)
   at NUnit.Framework.Internal.ContextUtils.DoIsolated[T](Func`1 func)
   at NUnit.Framework.Internal.Execution.SimpleWorkItem.PerformWork()
--RequestFailedException

Check failure on line 1 in Azure.Messaging.ServiceBus.Tests.Receiver.ReceiverLiveTests.ReceiverDrainsOnClosing

See this annotation in the file changed.

@azure-pipelines azure-pipelines / net - servicebus - tests

Azure.Messaging.ServiceBus.Tests.Receiver.ReceiverLiveTests.ReceiverDrainsOnClosing 

System.TimeoutException : The operation did not complete within the allocated time 00:01:00 for object drain.
Raw output 
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Microsoft.Azure.Amqp.AsyncResult.End[TAsyncResult](IAsyncResult result)
   at Microsoft.Azure.Amqp.ReceivingAmqpLink.<>c.<DrainAsyc>b__35_1(IAsyncResult r)
   at System.Threading.Tasks.TaskFactory`1.FromAsyncCoreLogic(IAsyncResult iar, Func`2 endFunction, Action`1 endAction, Task`1 promise, Boolean requiresSynchronization)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.ConfiguredTaskAwaitable.ConfiguredTaskAwaiter.GetResult()
   at Azure.Messaging.ServiceBus.Amqp.AmqpReceiver.<CloseAsync>d__76.MoveNext() in /_/sdk/servicebus/Azure.Messaging.ServiceBus/src/Amqp/AmqpReceiver.cs:line 1490
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.ConfiguredTaskAwaitable.ConfiguredTaskAwaiter.GetResult()
   at Azure.Messaging.ServiceBus.ServiceBusReceiver.<CloseAsync>d__41.MoveNext() in /_/sdk/servicebus/Azure.Messaging.ServiceBus/src/Receiver/ServiceBusReceiver.cs:line 266
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.ConfiguredTaskAwaitable.ConfiguredTaskAwaiter.GetResult()
   at Azure.Messaging.ServiceBus.ServiceBusReceiver.<DisposeAsync>d__66.MoveNext() in /_/sdk/servicebus/Azure.Messaging.ServiceBus/src/Receiver/ServiceBusReceiver.cs:line 1312
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.ValueTaskAwaiter.GetResult()
   at Azure.Messaging.ServiceBus.Tests.Receiver.ReceiverLiveTests.<>c__DisplayClass2_1.<<ReceiverDrainsOnClosing>g__Receive|0>d.MoveNext() in D:\a\_work\1\s\sdk\servicebus\Azure.Messaging.ServiceBus\tests\Receiver\ReceiverLiveTests.cs:line 108
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
   at Azure.Messaging.ServiceBus.Tests.Receiver.ReceiverLiveTests.<ReceiverDrainsOnClosing>d__2.MoveNext() in D:\a\_work\1\s\sdk\servicebus\Azure.Messaging.ServiceBus\tests\Receiver\ReceiverLiveTests.cs:line 94
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Azure.Messaging.ServiceBus.Tests.Receiver.ReceiverLiveTests.<ReceiverDrainsOnClosing>d__2.MoveNext() in D:\a\_work\1\s\sdk\servicebus\Azure.Messaging.ServiceBus\tests\Receiver\ReceiverLiveTests.cs:line 94
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Azure.Messaging.ServiceBus.Tests.Receiver.ReceiverLiveTests.<ReceiverDrainsOnClosing>d__2.MoveNext() in D:\a\_work\1\s\sdk\servicebus\Azure.Messaging.ServiceBus\tests\Receiver\ReceiverLiveTests.cs:line 121
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotifi

Check failure on line 1 in Azure.Messaging.ServiceBus.Tests.Receiver.SessionReceiverLiveTests.SessionOrderingIsGuaranteed(True)

See this annotation in the file changed.

@azure-pipelines azure-pipelines / net - servicebus - tests

Azure.Messaging.ServiceBus.Tests.Receiver.SessionReceiverLiveTests.SessionOrderingIsGuaranteed(True) 

Azure.Messaging.ServiceBus.ServiceBusException : The session lock was lost. Request a new session receiver. (SessionLockLost). For troubleshooting information, see https://aka.ms/azsdk/net/servicebus/exceptions/troubleshoot.
Raw output 
   at Azure.Messaging.ServiceBus.Amqp.AmqpReceiver.ThrowIfSessionLockLost() in /_/sdk/servicebus/Azure.Messaging.ServiceBus/src/Amqp/AmqpReceiver.cs:line 1564
   at Azure.Messaging.ServiceBus.Amqp.AmqpReceiver.ReceiveMessagesAsyncInternal(Int32 maxMessages, Nullable`1 maxWaitTime, TimeSpan timeout, CancellationToken cancellationToken) in /_/sdk/servicebus/Azure.Messaging.ServiceBus/src/Amqp/AmqpReceiver.cs:line 352
   at Azure.Messaging.ServiceBus.Amqp.AmqpReceiver.<>c.<<ReceiveMessagesAsync>b__44_0>d.MoveNext() in /_/sdk/servicebus/Azure.Messaging.ServiceBus/src/Amqp/AmqpReceiver.cs:line 322
--- End of stack trace from previous location ---
   at Azure.Messaging.ServiceBus.ServiceBusRetryPolicy.RunOperation[T1,TResult](Func`4 operation, T1 t1, TransportConnectionScope scope, CancellationToken cancellationToken, Boolean logTimeoutRetriesAsVerbose) in /_/sdk/servicebus/Azure.Messaging.ServiceBus/src/Primitives/ServiceBusRetryPolicy.cs:line 153
   at Azure.Messaging.ServiceBus.ServiceBusRetryPolicy.RunOperation[T1,TResult](Func`4 operation, T1 t1, TransportConnectionScope scope, CancellationToken cancellationToken, Boolean logTimeoutRetriesAsVerbose) in /_/sdk/servicebus/Azure.Messaging.ServiceBus/src/Primitives/ServiceBusRetryPolicy.cs:line 185
   at Azure.Messaging.ServiceBus.Amqp.AmqpReceiver.ReceiveMessagesAsync(Int32 maxMessages, Nullable`1 maxWaitTime, CancellationToken cancellationToken) in /_/sdk/servicebus/Azure.Messaging.ServiceBus/src/Amqp/AmqpReceiver.cs:line 319
   at Azure.Messaging.ServiceBus.ServiceBusReceiver.ReceiveMessagesAsync(Int32 maxMessages, Nullable`1 maxWaitTime, Boolean isProcessor, CancellationToken cancellationToken) in /_/sdk/servicebus/Azure.Messaging.ServiceBus/src/Receiver/ServiceBusReceiver.cs:line 330
   at Azure.Messaging.ServiceBus.ServiceBusReceiver.ReceiveMessagesAsync(Int32 maxMessages, Nullable`1 maxWaitTime, CancellationToken cancellationToken) in /_/sdk/servicebus/Azure.Messaging.ServiceBus/src/Receiver/ServiceBusReceiver.cs:line 289
   at Azure.Messaging.ServiceBus.Tests.Receiver.SessionReceiverLiveTests.<>c__DisplayClass31_0.<<SessionOrderingIsGuaranteed>g__ReceiveMessagesAsync|1>d.MoveNext() in D:\a\_work\1\s\sdk\servicebus\Azure.Messaging.ServiceBus\tests\Receiver\SessionReceiverLiveTests.cs:line 1247
--- End of stack trace from previous location ---
   at Azure.Messaging.ServiceBus.Tests.Receiver.SessionReceiverLiveTests.SessionOrderingIsGuaranteed(Boolean prefetch) in D:\a\_work\1\s\sdk\servicebus\Azure.Messaging.ServiceBus\tests\Receiver\SessionReceiverLiveTests.cs:line 1231
   at Azure.Messaging.ServiceBus.Tests.Receiver.SessionReceiverLiveTests.SessionOrderingIsGuaranteed(Boolean prefetch) in D:\a\_work\1\s\sdk\servicebus\Azure.Messaging.ServiceBus\tests\Receiver\SessionReceiverLiveTests.cs:line 1231
   at Azure.Messaging.ServiceBus.Tests.Receiver.SessionReceiverLiveTests.SessionOrderingIsGuaranteed(Boolean prefetch) in D:\a\_work\1\s\sdk\servicebus\Azure.Messaging.ServiceBus\tests\Receiver\SessionReceiverLiveTests.cs:line 1261
   at NUnit.Framework.Internal.TaskAwaitAdapter.GenericAdapter`1.BlockUntilCompleted()
   at NUnit.Framework.Internal.MessagePumpStrategy.NoMessagePumpStrategy.WaitForCompletion(AwaitAdapter awaiter)
   at NUnit.Framework.Internal.AsyncToSyncAdapter.Await(Func`1 invoke)
   at NUnit.Framework.Internal.Commands.TestMethodCommand.RunTestMethod(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.TestMethodCommand.Execute(TestExecutionContext context)
   at NUnit.Framework.Internal.Execution.SimpleWorkItem.<>c__DisplayClass4_0.<PerformWork>b__0()
   at NUnit.Framework.Internal.ContextUtils.<>c__DisplayClass1_0`1.<DoIsolated>b__0(Object _)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callb
View more details on Azure Pipelines