Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Service Bus] Batch delete test tweaks #44282

Merged
merged 1 commit into from
May 29, 2024

Conversation

jsquire
Copy link
Member

@jsquire jsquire commented May 28, 2024

Summary

The focus of these changes is to fix the order of "expected" and "actual" for the purge scenarios and to add a short delay between publishing messages and purging to ensure there is adequate time for
the messages to be made available in the queue.

The focus of these changes is to fix the order of
"expected" and "actual" for the purge scenarios and
to add a short delay between publishing messages
and purging to ensure there is adequate time for
the messages to be made available in the queue.
@jsquire jsquire added Service Bus Client This issue points to a problem in the data-plane of the library. labels May 28, 2024
@jsquire jsquire added this to the 2024-06 milestone May 28, 2024
@jsquire jsquire self-assigned this May 28, 2024
@jsquire jsquire requested a review from JoshLove-msft as a code owner May 28, 2024 21:11
@jsquire
Copy link
Member Author

jsquire commented May 28, 2024

/azp run net - servicebus - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@jsquire
Copy link
Member Author

jsquire commented May 29, 2024

Does not fix the Canary failures, but does provide proper expected/actual information and the publish delay is a good idea. Merging.

@jsquire
Copy link
Member Author

jsquire commented May 29, 2024

/check-enforcer override

@jsquire jsquire merged commit 02923ff into Azure:main May 29, 2024
40 of 47 checks passed
@jsquire jsquire deleted the servicebus/delete-tests branch May 29, 2024 14:04
benbp pushed a commit that referenced this pull request Jun 5, 2024
The focus of these changes is to fix the order of
"expected" and "actual" for the purge scenarios and
to add a short delay between publishing messages
and purging to ensure there is adequate time for
the messages to be made available in the queue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants