-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regenerate PolicyInsights based on latest spec for 2018-04-04 (GA version) #4361
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create a generate.ps1 similar to this and regenerate the code
Please run
msbuild build.proj /t:build /p:Scope=SDKs\PolicyInsights
@@ -4,7 +4,7 @@ | |||
<PackageId>PolicyInsights.Tests</PackageId> | |||
<Description>PolicyInsights.Tests Class Library</Description> | |||
<AssemblyName>PolicyInsights.Tests</AssemblyName> | |||
<VersionPrefix>0.9.0-preview</VersionPrefix> | |||
<VersionPrefix>1.0.0</VersionPrefix> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use Version
instead of VersionPrefix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Will merge on CIs passing |
@dsgouda Thanks! How long after the merge should I expect the package to be available at nuget.org? |
@bulentelmaci You will have to publish the nuget package yourself, instructions can be found here |
@dsgouda Thanks! I assume I can just do the Publish job which will sign and publish (i.e. no need to run the sign job separately beforehand)? |
Yes, that's correct. Please reach out to our alias in case you run into any publish issues. |
Swagger spec PR: Azure/azure-rest-api-specs#2929
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK.