Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate PolicyInsights based on latest spec for 2018-04-04 (GA version) #4361

Merged
merged 4 commits into from
May 23, 2018

Conversation

bulentelmaci
Copy link
Contributor

  • Regenerate PolicyInsights based on latest spec for 2018-04-04
  • Change client, assembly and file versions to 1.0.0; remove -preview
  • Rerecord tests

Swagger spec PR: Azure/azure-rest-api-specs#2929

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a generate.ps1 similar to this and regenerate the code

Please run
msbuild build.proj /t:build /p:Scope=SDKs\PolicyInsights

@@ -4,7 +4,7 @@
<PackageId>PolicyInsights.Tests</PackageId>
<Description>PolicyInsights.Tests Class Library</Description>
<AssemblyName>PolicyInsights.Tests</AssemblyName>
<VersionPrefix>0.9.0-preview</VersionPrefix>
<VersionPrefix>1.0.0</VersionPrefix>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use Version instead of VersionPrefix

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda
Copy link
Contributor

dsgouda commented May 23, 2018

Will merge on CIs passing

@bulentelmaci
Copy link
Contributor Author

@dsgouda Thanks! How long after the merge should I expect the package to be available at nuget.org?

@dsgouda dsgouda merged commit 6fa11c3 into Azure:psSdkJson6 May 23, 2018
@dsgouda
Copy link
Contributor

dsgouda commented May 23, 2018

@bulentelmaci You will have to publish the nuget package yourself, instructions can be found here

@bulentelmaci
Copy link
Contributor Author

@dsgouda Thanks! I assume I can just do the Publish job which will sign and publish (i.e. no need to run the sign job separately beforehand)?

@dsgouda
Copy link
Contributor

dsgouda commented May 23, 2018

Yes, that's correct. Please reach out to our alias in case you run into any publish issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants