[Service Bus] Model factory comments #43276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The focus of these changes is to add doc comments to the `ServiceBusModelFactory` members, specifically helping callers to understand what model properties each argument populates. Because some of the parameter names differ from the associated model property names, there has been some confusion.
jsquire
added
Service Bus
Client
sdk/servicebus/Azure.Messaging.ServiceBus/src/Primitives/ServiceBusModelFactory.cs
Outdated
Show resolved
Hide resolved
sdk/servicebus/Azure.Messaging.ServiceBus/src/Primitives/ServiceBusModelFactory.cs
Outdated
Show resolved
Hide resolved
sdk/servicebus/Azure.Messaging.ServiceBus/src/Primitives/ServiceBusModelFactory.cs
Outdated
Show resolved
Hide resolved
JoshLove-msft
approved these changes
Apr 8, 2024
…ceBusModelFactory.cs Co-authored-by: JoshLove-msft <[email protected]>
…ceBusModelFactory.cs Co-authored-by: JoshLove-msft <[email protected]>
…ceBusModelFactory.cs Co-authored-by: JoshLove-msft <[email protected]>
jsquire
commented
Apr 8, 2024
sdk/servicebus/Azure.Messaging.ServiceBus/src/Primitives/ServiceBusModelFactory.cs
Outdated
Show resolved
Hide resolved
…ceBusModelFactory.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The focus of these changes is to add doc comments to the
ServiceBusModelFactorymembers, specifically helping callers to understand what model properties each argument populates. Because some of the parameter names differ from the associated model property names, there has been some confusion.References and related