Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regenerate code with the latest spec #43182

Merged
merged 4 commits into from
Apr 13, 2024
Merged

Regenerate code with the latest spec #43182

merged 4 commits into from
Apr 13, 2024

Conversation

jecmenicanikola
Copy link
Contributor

This PR updates autorest input file with the latest commit hash and regenerates code.

@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Maps labels Apr 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

Thank you for your contribution @jecmenicanikola! We will review the pull request and get back to you soon.

@jecmenicanikola jecmenicanikola force-pushed the update-generated-code-with-the-latest-spec branch from 257274f to 2a7ff3f Compare April 3, 2024 23:13
@dubiety dubiety removed the request for review from khmic5 April 7, 2024 15:50
dubiety
dubiety approved these changes Apr 7, 2024
View reviewed changes
Copy link
Member

@dubiety dubiety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may also need to apply these updated comments to custom (manual) files.

@jecmenicanikola
Copy link
Contributor Author

@dubiety I updated custom(manual) files, for which I found a corresponding generated file.

@dubiety
Copy link
Member

dubiety commented Apr 8, 2024 •
edited
Loading

Hi @jecmenicanikola,
We may need to check all the Azure.Maps.<category>/src/Maps<category>Client.cs and <category>/src/Models/xxx.cs files.
For example:
In MapsGeolocationClient.cs and MapsRoutingClient.cs Azure AD needs to be replaced with Microsoft Entra ID
In MapsRenderingClient.cs, there are some /en-us/ in the URL that should be removed.
In RouteMatrixOptions.cs and RouteRangeOptions.cs (and some other custom layer files), we can append /regions after countries, becoming countries/regions.

@jecmenicanikola
Copy link
Contributor Author

@dubiety Done.

@dubiety dubiety merged commit 5c0b7ea into Azure:main Apr 13, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dubiety dubiety dubiety approved these changes

@andykao1213 andykao1213 Awaiting requested review from andykao1213

Assignees
No one assigned
Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Maps
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jecmenicanikola @dubiety