[Event Hubs] UpdateCheckpointAsync API tweaks #41829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run net - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run net - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
API change check APIView has identified API level changes in this PR and created following API reviews. Azure.Messaging.EventHubs |
m-redding
requested review from
KrzysztofCwalina,
tg-msft,
serkantkaraca and
jsquire
as code owners
jsquire
reviewed
Feb 7, 2024
sdk/eventhub/Azure.Messaging.EventHubs/src/Primitives/CheckpointStore.cs
Outdated
Show resolved
Hide resolved
sdk/eventhub/Azure.Messaging.EventHubs.Processor/src/EventProcessorClient.cs
Outdated
Show resolved
Hide resolved
...thub/Azure.Messaging.EventHubs.Shared/src/BlobCheckpointStore/BlobCheckpointStoreInternal.cs
Outdated
Show resolved
Hide resolved
sdk/eventhub/Azure.Messaging.EventHubs/src/Primitives/CheckpointStore.cs
Outdated
Show resolved
Hide resolved
sdk/eventhub/Azure.Messaging.EventHubs/src/Primitives/CheckpointStore.cs
Show resolved
Hide resolved
jsquire
approved these changes
Feb 7, 2024
|
/azp run net - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following feedback from the architects:
[EditorBrowsable(EditorBrowsableState.Never)]from the set of existingUpdateCheckpointAsyncmethodslong? OffsetfromCheckpointPositionCheckpointPosition checkpointStartingPositiontoCheckpointPosition startingPositionin allUpdateCheckpointAsyncmethods