Regenerating SDK based on swagger changes on List/Cancel operation for Azure database and Elastic pool #4106

payiAzure · 2018-03-05T18:22:33Z

… list database/pool operation

Description

This pull request is to regenerate SDK based on the swagger changes on List/Cancel Operation for Azure database and elastic pool.

The related swagger pull request that has been merged in the azure-rest-api-specs are:
Azure/azure-rest-api-specs#2520

Azure/azure-rest-api-specs#2592 (only update the sql-resourcemanager readme)

Azure/azure-rest-api-specs#2640 (refactor sql readme. List/Cancel operation is included in the refactored sql readme version)

[Do no merge] notice in the tile: we're doing the ARM manifest update on production currently for new version API. Will remove it from title and do the merge after the ARM manifest update is done.

This checklist is used to make sure that common guidelines for a pull request are followed.

Please add REST spec PR link to the SDK PR
I have read the contribution guidelines.
The pull request does not introduce breaking changes.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

SDK Generation Guidelines

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

… list database/pool operation

azuresdkci · 2018-03-05T18:22:36Z

Can one of the admins verify this patch?

azuresdkci · 2018-03-05T18:22:36Z

Can one of the admins verify this patch?

azuresdkci · 2018-03-05T18:22:36Z

Can one of the admins verify this patch?

azuresdkci · 2018-03-05T18:23:13Z

Can one of the admins verify this patch?

dsgouda

Code needs to be generated from the swagger spec checked into master
Package Version needs to be updated

dsgouda · 2018-03-05T22:07:08Z

src/SDKs/_metadata/sql_resource-manager.txt

-GitHub user: kosta-bizetic
-Branch:      master
-Commit:      fb9e1b2a7561e7bd7d697011bd063964f2521861
+GitHub user: payiAzure


Please pull down latest changes and run generate.cmd again, this should log the commit id here

Also, looks like you are generating code from your local branch, please generate the code from the checked in swagger

@dsgouda Sync with the checked-in swagger and regenerate the sdk from master in the second commit. Please take a look

shahabhijeet · 2018-03-10T02:30:45Z

@azuresdkci test this please

…ecked-in changes and renenerate the SDK

dsgouda · 2018-03-14T23:41:43Z

Restarting CI

dsgouda · 2018-03-14T23:42:34Z

@azuresdkci rebuild

dsgouda · 2018-03-14T23:44:23Z

@azuresdkci retest

jaredmoo · 2018-03-15T01:04:00Z

Please do the last 2 items from the checklist:

The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

:)

jaredmoo · 2018-03-15T01:07:23Z

csproj & AssemblyInfo.cs should have minor version bump (e.g. 1.12.0.0 -> 1.13.0.0) and please also edit release notes in csproj (remove old release notes describing 1.12 and add new notes describing 1.13)

…-specs. Bump the api version in Assembly file and csproj

payiAzure · 2018-03-15T18:35:04Z

@jaredmoo Update the pull request, address comments on:

The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

jaredmoo · 2018-03-15T18:40:09Z

src/SDKs/SqlManagement/Sql.Tests/ElasticPoolCrudScenarioTests.cs

+                    Dtu = 250,
+                    Tags = tags
+                });
+                Thread.Sleep(TimeSpan.FromSeconds(5));


We should only sleep when in record mode. Take a look at other tests e.g. Restore tests

// No need to sleep if we are playing back the recording. if (HttpMockServer.Mode == HttpRecorderMode.Record) { Thread.Sleep(TimeSpan.FromSeconds(5)); }

btw how reliable is this test? Does it generally pass every time?

yes, when I run the test for multiple time, it passed every time.

@jaredmoo update the test in the new commit of the PR: only sleep when in Record mode

dsgouda · 2018-03-15T18:41:49Z

src/SDKs/_metadata/sql_resource-manager.txt

@@ -1,11 +1,13 @@
-2018-01-31 10:51:15 UTC
+


Please pull down the latest changes from upstream and run the generate.cmd command again, this should log the commit id here.

@dsgouda . I did, but the interesting thing is no commit id shown in the file. I tried several times.
my forked azurePayi/azure-sdk-for-net repo is updated with the official azure/azure-sdk-for-net repo, and I run the generate.cmd against official azure/azure-rest-spi-specs
since my swagger changes already were merged to the official azure-rest-spi-specs

@dsgouda Thanks for your help! Update the PR which has commit id in the metadata file.

… into mybranch1

payiAzure · 2018-03-15T22:42:58Z

@dsgouda Hi Deepak, can we get this PR review complete asap and merge? The sdk-for-phyton publish has dependency on this

dsgouda · 2018-03-15T22:45:36Z

@payiAzure Please fix the build issues here

dsgouda

LGTM subject to CI passing

dsgouda · 2018-03-15T23:27:39Z

@azuresdkci ReTest this

dsgouda · 2018-03-15T23:32:44Z

@azuresdkci retest this please

Generate sdk from swagger, add new test for cancel pool operation and…

80848ef

… list database/pool operation

dsgouda suggested changes Mar 5, 2018

View reviewed changes

dsgouda added the Changes Requested label Mar 5, 2018

dsgouda self-assigned this Mar 5, 2018

dsgouda added Do Not Merge spec-not-merged labels Mar 5, 2018

Sync the SDK repo with original. Sync official rest-api-specs with ch…

f482bb4

…ecked-in changes and renenerate the SDK

dsgouda closed this Mar 14, 2018

dsgouda reopened this Mar 14, 2018

dsgouda removed spec-not-merged Do Not Merge labels Mar 14, 2018

generate the .net sdk from official swagger repo azure/azure-rest-api…

4cf916c

…-specs. Bump the api version in Assembly file and csproj

jaredmoo approved these changes Mar 15, 2018

View reviewed changes

dsgouda reviewed Mar 15, 2018

View reviewed changes

payiAzure added 4 commits March 15, 2018 13:26

Update ElasticPool test, only sleep when in Record mode

abb9040

Merge branch 'psSdkJson6' of https://github.com/Azure/azure-sdk-for-net…

d2942ef

… into mybranch1

do a git clean on working branch, rerun generate.cmd

1690adf

delete the release note for sdk version 1.12.0-preview

d40dcfd

payiAzure changed the title ~~[Do NOT MERGE] Regenerating SDK based on swagger changes on List/Cancel operation for Azure database and Elastic pool~~ Regenerating SDK based on swagger changes on List/Cancel operation for Azure database and Elastic pool Mar 15, 2018

fix build issue in ElasticPoolCrudScenarioTests.cs

497c848

dsgouda approved these changes Mar 15, 2018

View reviewed changes

dsgouda removed the Changes Requested label Mar 15, 2018

dsgouda merged commit 360a9f5 into Azure:psSdkJson6 Mar 16, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Regenerating SDK based on swagger changes on List/Cancel operation for Azure database and Elastic pool #4106

Regenerating SDK based on swagger changes on List/Cancel operation for Azure database and Elastic pool #4106

payiAzure commented Mar 5, 2018 •

edited

Loading

azuresdkci commented Mar 5, 2018

azuresdkci commented Mar 5, 2018

azuresdkci commented Mar 5, 2018

azuresdkci commented Mar 5, 2018

dsgouda left a comment

dsgouda Mar 5, 2018

dsgouda Mar 5, 2018

payiAzure Mar 14, 2018

shahabhijeet commented Mar 10, 2018

dsgouda commented Mar 14, 2018

dsgouda commented Mar 14, 2018

dsgouda commented Mar 14, 2018

jaredmoo commented Mar 15, 2018 •

edited

Loading

jaredmoo commented Mar 15, 2018

payiAzure commented Mar 15, 2018

jaredmoo Mar 15, 2018

jaredmoo Mar 15, 2018

payiAzure Mar 15, 2018

payiAzure Mar 15, 2018

dsgouda Mar 15, 2018

payiAzure Mar 15, 2018

payiAzure Mar 15, 2018

payiAzure commented Mar 15, 2018

dsgouda commented Mar 15, 2018

dsgouda left a comment

dsgouda commented Mar 15, 2018

dsgouda commented Mar 15, 2018

Regenerating SDK based on swagger changes on List/Cancel operation for Azure database and Elastic pool #4106

Regenerating SDK based on swagger changes on List/Cancel operation for Azure database and Elastic pool #4106

Conversation

payiAzure commented Mar 5, 2018 • edited Loading

Description

[Do no merge] notice in the tile: we're doing the ARM manifest update on production currently for new version API. Will remove it from title and do the merge after the ARM manifest update is done.

azuresdkci commented Mar 5, 2018

azuresdkci commented Mar 5, 2018

azuresdkci commented Mar 5, 2018

azuresdkci commented Mar 5, 2018

dsgouda left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shahabhijeet commented Mar 10, 2018

dsgouda commented Mar 14, 2018

dsgouda commented Mar 14, 2018

dsgouda commented Mar 14, 2018

jaredmoo commented Mar 15, 2018 • edited Loading

jaredmoo commented Mar 15, 2018

payiAzure commented Mar 15, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

payiAzure commented Mar 15, 2018

dsgouda commented Mar 15, 2018

dsgouda left a comment

Choose a reason for hiding this comment

dsgouda commented Mar 15, 2018

dsgouda commented Mar 15, 2018

payiAzure commented Mar 5, 2018 •

edited

Loading

jaredmoo commented Mar 15, 2018 •

edited

Loading