Machine Learning Compute: Add optional deleteAll parameter #3959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shutchings
changed the title
shahabhijeet
suggested changes
Dec 21, 2017
shutchings
force-pushed
the
psSdkJson6
branch
from
1c91139 to
20830bd
Compare
shutchings
force-pushed
the
psSdkJson6
branch
from
20830bd to
e44516f
Compare
|
Done. It looks like this created a new AzSdk.RP.props file. Are there any other expected changes? |
13 tasks
|
@shahabhijeet Could I get another look at this? My powershell cmdlet release deadline is coming up. Thanks! |
shahabhijeet
suggested changes
Jan 3, 2018
| <PackageTags>Microsoft Azure Machine Learning Compute management;</PackageTags> | ||
| <PackageReleaseNotes>Orchestrator properties and orchestrator service principal are optional since the resource provider will create one if not provided.</PackageReleaseNotes> | ||
| <Version>0.3.0</Version> | ||
| <PackageTags>Microsoft Azure Machine Learning Compute management;REST HTTP client;azureofficial;windowsazureofficial;netcore451511</PackageTags> |
There was a problem hiding this comment.
@shutchings please remove all the extra tags that were removed earlier. Those tags does not make any sense.
All these tags are not required for searching your nuget package. Please remove them. We are cleaning these tags across all SDKs.
|
@shahabhijeet I removed the tags. Anything else? |
shahabhijeet
approved these changes
Jan 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When deleting an operationalization cluster we leave behind the ACR, Application Insights, and Storage Accounts so the user has them for history. However some users do not want to delete these manually if they are not needed. The optional 'deleteAll' parameter adds the ability to delete all resources associated with the cluster as well.
REST spec PR
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.