Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a funtion to convert BinaryData to RequestContent #39316

Merged
merged 3 commits into from
Oct 19, 2023
Merged

add a funtion to convert BinaryData to RequestContent #39316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
63c9eb2
add serialize funtion for BinaryData
chunyu3 Oct 17, 2023
f805272
add more test
chunyu3 Oct 17, 2023
53a2f94
Update sdk/core/Azure.Core/src/Shared/RequestContentHelper.cs
chunyu3 Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions sdk/core/Azure.Core/src/Shared/RequestContentHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,5 +94,15 @@ public static RequestContent FromObject(object value)
content.JsonWriter.WriteObjectValue(value);
return content;
}
public static RequestContent FromObject(BinaryData value)
chunyu3 marked this conversation as resolved.
Show resolved Hide resolved
{
var content = new Utf8JsonRequestContent();
#if NET6_0_OR_GREATER
content.JsonWriter.WriteRawValue(value);
#else
JsonSerializer.Serialize(content.JsonWriter, JsonDocument.Parse(value).RootElement);
#endif
return content;
}
}
}
21 changes: 21 additions & 0 deletions sdk/core/Azure.Core/tests/RequestContentHelperTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,16 @@ public static IEnumerable<TestCaseData> GetOneDateTimeData()
yield return new TestCaseData(DateTimeOffset.Parse("2022-08-26T18:38:00Z"));
}

public static object[] BinaryDataCases =
{
new object[] { BinaryData.FromString("\"test\"") },
new object[] { new BinaryData(1)},
new object[] { new BinaryData(1.1)},
new object[] { new BinaryData(true)},
new object[] { BinaryData.FromObjectAsJson(new {name="a", age=1})},
new object[] { new BinaryData(DateTimeOffset.Parse("2022-08-26T18:38:00Z"))}
};

[TestCase(1, 2)]
[TestCase("a", "b")]
[TestCase(true, false)]
Expand Down Expand Up @@ -186,5 +196,16 @@ public void TestFromObject<T>(T value)
break;
}
}

[TestCaseSource(nameof(BinaryDataCases))]
public void TestFromObjectForBinaryData(BinaryData value)
{
var content = RequestContentHelper.FromObject(value);
var stream = new MemoryStream();
content.WriteTo(stream, default);
stream.Position = 0;
var document = JsonDocument.Parse(stream);
Assert.AreEqual(value.ToObjectFromJson(), BinaryData.FromString(document.RootElement.GetRawText()).ToObjectFromJson());
}
}
}