-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data Factory] Add readBehavior property to Salesforce Source in SDK #3925
Conversation
Sync up the fork with upstream
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use generate.cmd to generate your sdk. I need to see the generated metadata.txt file in this pr.
|
||
1) azure-rest-api-specs repository information | ||
GitHub user: Azure | ||
GitHub user: smilenow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smilenow why are you generating from your repo? This has to be generated from main azure fork and not yours?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because previously I heard from @gadongji , it could be OK no matter which branch is used to generated. But anyway, I will resolve the conflict and then re-generated by using the Azure fork branch.
@@ -1,11 +1,10 @@ | |||
2017-12-07 02:33:12 UTC | |||
2017-12-08 05:40:35 UTC | |||
|
|||
1) azure-rest-api-specs repository information | |||
GitHub user: Azure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smilenow I don't see the commit Id for the spec that is part of the meta data file?
Are you generating from the merged spec?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shahabhijeet Yes, I was generating from the Azure latest public repo yesterday, and didn't modify anything in this file. Do you mean it should input a certain commit id when using generate.cmd?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shahabhijeet , shall we go ahead with this PR? Or do you need a exact commit id when generating the SDK from the swagger spec?
@smilenow please take a look at the file which no longer has the commit Id. |
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK.