Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data Factory] Add readBehavior property to Salesforce Source in SDK #3925

Merged
merged 6 commits into from
Dec 13, 2017

Conversation

smilenow
Copy link
Contributor

@smilenow smilenow commented Dec 6, 2017

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Copy link
Member

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use generate.cmd to generate your sdk. I need to see the generated metadata.txt file in this pr.


1) azure-rest-api-specs repository information
GitHub user: Azure
GitHub user: smilenow
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smilenow why are you generating from your repo? This has to be generated from main azure fork and not yours?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because previously I heard from @gadongji , it could be OK no matter which branch is used to generated. But anyway, I will resolve the conflict and then re-generated by using the Azure fork branch.

@@ -1,11 +1,10 @@
2017-12-07 02:33:12 UTC
2017-12-08 05:40:35 UTC

1) azure-rest-api-specs repository information
GitHub user: Azure
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smilenow I don't see the commit Id for the spec that is part of the meta data file?
Are you generating from the merged spec?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shahabhijeet Yes, I was generating from the Azure latest public repo yesterday, and didn't modify anything in this file. Do you mean it should input a certain commit id when using generate.cmd?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shahabhijeet , shall we go ahead with this PR? Or do you need a exact commit id when generating the SDK from the swagger spec?

@shahabhijeet
Copy link
Member

shahabhijeet commented Dec 12, 2017

@smilenow please take a look at the file which no longer has the commit Id.
When you use generate.cmd, it actually not only generates the SDK, it goes and fetches the latest commit Id of your REST api spec and puts it into the .txt file.
In your latest change that commit id is not available.
Everytime you generated it basically tells that this particular generated code is from a particular commit Id of your spec.

@shahabhijeet shahabhijeet merged commit 694064a into Azure:psSdkJson6 Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants