Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PauseOnStart Recording Option #39132

Merged
merged 25 commits into from
Oct 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
17a88db
generated files using swagger
amariwest-msft Oct 5, 2023
97b1138
removed extra swagger file
amariwest-msft Oct 6, 2023
538be66
modified unit tests
amariwest-msft Oct 6, 2023
abaee0f
Merge branch 'main' into amariwest/pauseonstart-swagger
amariwest-msft Oct 6, 2023
1bf0078
undo status code change for mute participant in generated files
amariwest-msft Oct 6, 2023
8d5d102
Merge branch 'main' into amariwest/pauseonstart-swagger
amariwest-msft Oct 6, 2023
ac33fba
merged with main
amariwest-msft Oct 9, 2023
045b656
merged with main
amariwest-msft Oct 9, 2023
87eb601
reverted 202 change
amariwest-msft Oct 10, 2023
6cda95f
Both status code changed to 202
amariwest-msft Oct 11, 2023
88d7f95
modified test cases to check for 200 status code
amariwest-msft Oct 11, 2023
738cb14
Merge branch 'main' into amariwest/pauseonstart-swagger
amariwest-msft Oct 11, 2023
5f62ec5
regenerated code
amariwest-msft Oct 11, 2023
8b40113
Merge branch 'amariwest/pauseonstart-swagger' of https://github.com/A…
amariwest-msft Oct 11, 2023
a5a9e0e
regenerated code
amariwest-msft Oct 11, 2023
097e622
Revert "regenerated code"
amariwest-msft Oct 11, 2023
ac59d9b
Added TransciptionDataRequest Change
amariwest-msft Oct 11, 2023
f03117f
generated from latest swagger
amariwest-msft Oct 11, 2023
a9ed81b
Merge branch 'main' into amariwest/pauseonstart-swagger
amariwest-msft Oct 12, 2023
2a39b2d
generated netstandard2.0.cs
amariwest-msft Oct 12, 2023
7eb1425
edited changelog
amariwest-msft Oct 12, 2023
74fcc90
Revert "generated netstandard2.0.cs"
amariwest-msft Oct 12, 2023
dbf9932
Revert "edited changelog"
amariwest-msft Oct 12, 2023
def7f4a
added line to changelog and standard2.0.cs
amariwest-msft Oct 12, 2023
d8da073
Update CHANGELOG.md
amariwest-msft Oct 12, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## 1.1.0-beta.1 (Unreleased)

### Features Added
- StartRecording now accepts PauseOnStart.

### Breaking Changes

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1317,6 +1317,7 @@ public StartRecordingOptions(Azure.Communication.CallAutomation.CallLocator call
public System.Collections.Generic.IList<Azure.Communication.CommunicationIdentifier> AudioChannelParticipantOrdering { get { throw null; } }
public System.Collections.Generic.IList<Azure.Communication.CallAutomation.ChannelAffinity> ChannelAffinity { get { throw null; } set { } }
public Azure.Communication.CallAutomation.ExternalStorage ExternalStorage { get { throw null; } set { } }
public bool PauseOnStart { get { throw null; } set { } }
public Azure.Communication.CallAutomation.RecordingChannel RecordingChannel { get { throw null; } set { } }
public Azure.Communication.CallAutomation.RecordingContent RecordingContent { get { throw null; } set { } }
public Azure.Communication.CallAutomation.RecordingFormat RecordingFormat { get { throw null; } set { } }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ public virtual Response<RecordingStateResult> Start(StartRecordingOptions option
RecordingChannelType = options.RecordingChannel,
RecordingContentType = options.RecordingContent,
RecordingFormatType = options.RecordingFormat,
PauseOnStart = options.PauseOnStart,
};

if (options.AudioChannelParticipantOrdering != null && options.AudioChannelParticipantOrdering.Any())
Expand Down Expand Up @@ -119,6 +120,7 @@ public virtual async Task<Response<RecordingStateResult>> StartAsync(StartRecord
RecordingChannelType = options.RecordingChannel,
RecordingContentType = options.RecordingContent,
RecordingFormatType = options.RecordingFormat,
PauseOnStart = options.PauseOnStart,
};

if (options.AudioChannelParticipantOrdering != null && options.AudioChannelParticipantOrdering.Any())
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,11 @@ public StartRecordingOptions(CallLocator callLocator)
/// </summary>
public RecordingFormat RecordingFormat { get; set; }

/// <summary>
/// The pause on start option.
/// </summary>
public bool PauseOnStart { get; set; }

/// <summary>
/// The sequential order in which audio channels are assigned to participants in the unmixed recording.
/// When 'recordingChannelType' is set to 'unmixed' and `audioChannelParticipantOrdering is not specified,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ tag: package-2023-01-15-preview
require:
- https://github.com/williamzhao87/azure-rest-api-specs/blob/e31fe487ab3f775d659edf3945b9239ac910314a/specification/communication/data-plane/CallAutomation/readme.md


title: Azure Communication Services

generation1-convenience-client: true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,8 @@ private CallRecording getMockCallRecording(int statusCode, string? responseConte
RecordingChannel = RecordingChannel.Mixed,
RecordingFormat = RecordingFormat.Mp4,
AudioChannelParticipantOrdering = { new CommunicationUserIdentifier("test") },
ChannelAffinity = testChannelAffinities
ChannelAffinity = testChannelAffinities,
PauseOnStart = false,
})
},
new Func<CallRecording, TestDelegate>?[]
Expand Down Expand Up @@ -236,6 +237,7 @@ private CallRecording getMockCallRecording(int statusCode, string? responseConte
RecordingChannel = RecordingChannel.Mixed,
RecordingFormat = RecordingFormat.Mp4,
ChannelAffinity = testChannelAffinities,
PauseOnStart = false,
AudioChannelParticipantOrdering = { new CommunicationUserIdentifier("test"),}
}).ConfigureAwait(false),
},
Expand Down