Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[preview] apply enhanced analysis rules - trial 3 #38705

Closed
wants to merge 2 commits into from
Closed

[preview] apply enhanced analysis rules - trial 3 #38705

wants to merge 2 commits into from

Conversation

archerzz
Copy link
Member

  • update the client sdk analyzer to dev build
  • add globla config to suppress enhanced analysis rules
  • modify ci steps to support suppression by a property
  • applying the property to already impacted sdk projects for backward compatibility

preview for Azure/azure-sdk-tools#6916

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

Mingzhe Huang (from Dev Box) added 2 commits September 14, 2023 15:07
[preview] apply enhanced analysis rules - trial 3
cb4c7a1 
- update the client sdk analyzer to dev build
- add globla config to suppress enhanced analysis rules
- modify ci steps to support suppression by a property
- applying the property to already impacted sdk projects for backward compatibility
disable enhanced analysis for existing projects
817f09c
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@archerzz archerzz mentioned this pull request Sep 14, 2023
Merged
@scottaddie scottaddie added Monitor Monitor, Monitor Ingestion, Monitor Query and removed Monitor - Query labels Sep 26, 2023
@archerzz
Copy link
Member Author

Close since the changes have been applied in #39518

@archerzz archerzz closed this Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshLove-msft JoshLove-msft Awaiting requested review from JoshLove-msft JoshLove-msft will be requested when the pull request is marked ready for review JoshLove-msft is a code owner

@christothes christothes Awaiting requested review from christothes christothes will be requested when the pull request is marked ready for review christothes is a code owner

@annelo-msft annelo-msft Awaiting requested review from annelo-msft annelo-msft will be requested when the pull request is marked ready for review annelo-msft is a code owner

@KrzysztofCwalina KrzysztofCwalina Awaiting requested review from KrzysztofCwalina KrzysztofCwalina will be requested when the pull request is marked ready for review KrzysztofCwalina is a code owner

@tg-msft tg-msft Awaiting requested review from tg-msft tg-msft will be requested when the pull request is marked ready for review tg-msft is a code owner

@jsquire jsquire Awaiting requested review from jsquire jsquire will be requested when the pull request is marked ready for review jsquire is a code owner

@m-nash m-nash Awaiting requested review from m-nash m-nash will be requested when the pull request is marked ready for review m-nash is a code owner

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978 ArthurMa1978 will be requested when the pull request is marked ready for review ArthurMa1978 is a code owner

@hallipr hallipr Awaiting requested review from hallipr hallipr will be requested when the pull request is marked ready for review hallipr is a code owner

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard will be requested when the pull request is marked ready for review weshaggard is a code owner

@benbp benbp Awaiting requested review from benbp benbp will be requested when the pull request is marked ready for review benbp is a code owner

@ArcturusZhang ArcturusZhang Awaiting requested review from ArcturusZhang ArcturusZhang will be requested when the pull request is marked ready for review ArcturusZhang is a code owner

@giakas giakas Awaiting requested review from giakas giakas will be requested when the pull request is marked ready for review giakas is a code owner

@seanmcc-msft seanmcc-msft Awaiting requested review from seanmcc-msft seanmcc-msft will be requested when the pull request is marked ready for review seanmcc-msft is a code owner

@amnguye amnguye Awaiting requested review from amnguye amnguye will be requested when the pull request is marked ready for review amnguye is a code owner

@jaschrep-msft jaschrep-msft Awaiting requested review from jaschrep-msft jaschrep-msft will be requested when the pull request is marked ready for review jaschrep-msft is a code owner

@schaabs schaabs Awaiting requested review from schaabs schaabs will be requested when the pull request is marked ready for review schaabs is a code owner

@jalauzon-msft jalauzon-msft Awaiting requested review from jalauzon-msft jalauzon-msft will be requested when the pull request is marked ready for review jalauzon-msft is a code owner

@nickliu-msft nickliu-msft Awaiting requested review from nickliu-msft nickliu-msft will be requested when the pull request is marked ready for review nickliu-msft is a code owner

@ShivangiReja ShivangiReja Awaiting requested review from ShivangiReja ShivangiReja will be requested when the pull request is marked ready for review ShivangiReja is a code owner

@kinelski kinelski Awaiting requested review from kinelski kinelski will be requested when the pull request is marked ready for review kinelski is a code owner

@jpalvarezl jpalvarezl Awaiting requested review from jpalvarezl jpalvarezl will be requested when the pull request is marked ready for review jpalvarezl is a code owner

@trrwilson trrwilson Awaiting requested review from trrwilson trrwilson will be requested when the pull request is marked ready for review trrwilson is a code owner

@joseharriaga joseharriaga Awaiting requested review from joseharriaga joseharriaga will be requested when the pull request is marked ready for review joseharriaga is a code owner

@ralph-msft ralph-msft Awaiting requested review from ralph-msft ralph-msft will be requested when the pull request is marked ready for review ralph-msft is a code owner

@FlorianBorn71 FlorianBorn71 Awaiting requested review from FlorianBorn71 FlorianBorn71 will be requested when the pull request is marked ready for review FlorianBorn71 is a code owner

@MichaelZp0 MichaelZp0 Awaiting requested review from MichaelZp0 MichaelZp0 will be requested when the pull request is marked ready for review MichaelZp0 is a code owner

@ChristopherManthei ChristopherManthei Awaiting requested review from ChristopherManthei ChristopherManthei will be requested when the pull request is marked ready for review ChristopherManthei is a code owner

@nisha-bhatia nisha-bhatia Awaiting requested review from nisha-bhatia nisha-bhatia will be requested when the pull request is marked ready for review nisha-bhatia is a code owner

@dubiety dubiety Awaiting requested review from dubiety dubiety will be requested when the pull request is marked ready for review dubiety is a code owner

@JonathanCrd JonathanCrd Awaiting requested review from JonathanCrd JonathanCrd will be requested when the pull request is marked ready for review JonathanCrd is a code owner

@ethanann-ms ethanann-ms Awaiting requested review from ethanann-ms ethanann-ms will be requested when the pull request is marked ready for review ethanann-ms is a code owner

@vighatke vighatke Awaiting requested review from vighatke vighatke will be requested when the pull request is marked ready for review vighatke is a code owner

@Kishp01 Kishp01 Awaiting requested review from Kishp01 Kishp01 will be requested when the pull request is marked ready for review Kishp01 is a code owner

@m-redding m-redding Awaiting requested review from m-redding m-redding will be requested when the pull request is marked ready for review m-redding is a code owner

@johngallardo johngallardo Awaiting requested review from johngallardo johngallardo will be requested when the pull request is marked ready for review johngallardo is a code owner

@abhinav-ghai abhinav-ghai Awaiting requested review from abhinav-ghai abhinav-ghai will be requested when the pull request is marked ready for review abhinav-ghai is a code owner

@Aashish93-stack Aashish93-stack Awaiting requested review from Aashish93-stack Aashish93-stack will be requested when the pull request is marked ready for review Aashish93-stack is a code owner

@sjiherzig sjiherzig Awaiting requested review from sjiherzig sjiherzig will be requested when the pull request is marked ready for review sjiherzig is a code owner

@gfeitosa-msft gfeitosa-msft Awaiting requested review from gfeitosa-msft gfeitosa-msft will be requested when the pull request is marked ready for review gfeitosa-msft is a code owner

@phermanov-msft phermanov-msft Awaiting requested review from phermanov-msft phermanov-msft will be requested when the pull request is marked ready for review phermanov-msft is a code owner

@ilyapaliakou-msft ilyapaliakou-msft Awaiting requested review from ilyapaliakou-msft ilyapaliakou-msft will be requested when the pull request is marked ready for review ilyapaliakou-msft is a code owner

@besh2014 besh2014 Awaiting requested review from besh2014 besh2014 will be requested when the pull request is marked ready for review besh2014 is a code owner

@asaflevi-ms asaflevi-ms Awaiting requested review from asaflevi-ms asaflevi-ms will be requested when the pull request is marked ready for review asaflevi-ms is a code owner

@tomsft tomsft Awaiting requested review from tomsft tomsft will be requested when the pull request is marked ready for review tomsft is a code owner

@koen-mertens koen-mertens Awaiting requested review from koen-mertens koen-mertens will be requested when the pull request is marked ready for review koen-mertens is a code owner

@mengaims mengaims Awaiting requested review from mengaims mengaims will be requested when the pull request is marked ready for review mengaims is a code owner

@bowgong bowgong Awaiting requested review from bowgong bowgong will be requested when the pull request is marked ready for review bowgong is a code owner

@quentinRobinson quentinRobinson Awaiting requested review from quentinRobinson quentinRobinson will be requested when the pull request is marked ready for review quentinRobinson is a code owner

@bidisha-c bidisha-c Awaiting requested review from bidisha-c bidisha-c will be requested when the pull request is marked ready for review bidisha-c is a code owner

@anilba06 anilba06 Awaiting requested review from anilba06 anilba06 will be requested when the pull request is marked ready for review anilba06 is a code owner

@gkostal gkostal Awaiting requested review from gkostal gkostal will be requested when the pull request is marked ready for review gkostal is a code owner

Assignees
No one assigned
Labels
Cognitive - Form Recognizer Cognitive - Language Cognitive - Metrics Advisor Communication - SMS Communication Digital Twins Do Not Merge Event Grid IoT KeyVault Monitor Monitor, Monitor Ingestion, Monitor Query OpenAI Search Storage Storage Service (Queues, Blobs, Files) Synapse VideoAnalyzer Azure Video Analyzer
Projects
Azure SDK for Key Vault
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@archerzz @azure-sdk @jsquire @scottaddie