Remove metric telemetry for resource #38697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check API changes are not detected in this pull request. |
vishweshbankwar
requested review from
cijothomas,
reyang,
rajkumar-rangaraj and
TimothyMothra
as code owners
...lemetry.Exporter/tests/Azure.Monitor.OpenTelemetry.Exporter.Tests/ResourceExtensionsTests.cs
Outdated
Show resolved
Hide resolved
sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Internals/ResourceExtensions.cs
Outdated
Show resolved
Hide resolved
added 4 commits
September 14, 2023 11:12
rajkumar-rangaraj
approved these changes
Sep 14, 2023
vishweshbankwar
deleted the
vibankwa/add-metric-telemetry-based-on-var
branch
| bool shouldReportMetricTelemetry = false; | ||
| try | ||
| { | ||
| var exportResource = Environment.GetEnvironmentVariable(EnvironmentVariableConstants.EXPORT_RESOURCE_METRIC); |
There was a problem hiding this comment.
This should be changed to use the Platform abstraction
This was referenced Sep 15, 2023
yaotongms
pushed a commit
to yaotongms/azure-sdk-for-net
that referenced
this pull request
Oct 12, 2023
* remove metric telemetry for resource * distro test * rename env var * test * update test * const
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resource attributes are exported as a custom metric record with each batch of activities. This behavior is not yet stable and may change in future. This PR introduces an environment variable
EXPORT_METRIC_FOR_RESOURCE_ATTRIBUTESto control this behavior for auto-instrumentation scenario. By default, the metric telemetry will no longer be exported.