Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Cognitive Services Search into standalone SDKs #3869

Merged
merged 3 commits into from
Nov 21, 2017

Conversation

tdjin
Copy link
Contributor

@tdjin tdjin commented Nov 16, 2017

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

3 similar comments
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@sudhansu88
Copy link
Contributor

" The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK"--------We don't need to do a verison dump as we have not published yet

@shahabhijeet
Copy link
Member

@azuresdkci add to whitelist

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

1 similar comment
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@shahabhijeet
Copy link
Member

@azuresdkci add to whitelist

@mmitche
Copy link

mmitche commented Nov 17, 2017

You need to "ok to test" after whitelisting for this PR

@shahabhijeet
Copy link
Member

@azuresdkci test this please

@tdjin tdjin force-pushed the standalone-search branch from f1130e1 to 09dd485 Compare November 20, 2017 22:00
@brjohnstmsft brjohnstmsft changed the title Split Search into standalone SDKs Split Cognitive Services Search into standalone SDKs Nov 20, 2017
@tdjin tdjin force-pushed the standalone-search branch from 09dd485 to 21af3c3 Compare November 20, 2017 22:47
@shahabhijeet shahabhijeet merged commit 5f45c5b into Azure:psSdkJson6 Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants