Add Database Migration Service sdk for public preview #3867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nges. Changes: - Update tests using Azure Resource Manager 1.6.0-preview and other changes. - Update sdk models based on latest swagge in 'current' branch in 'azure-rest-spec-api-pr' - Add _metadata folder created by running generate.cmd
shahabhijeet
suggested changes
Nov 15, 2017
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.Azure.KeyVault" Version="2.3.2" /> | ||
| <PackageReference Include="Microsoft.Azure.Management.ResourceManager" Version="1.6.0-preview" /> | ||
| <PackageReference Update="Microsoft.NET.Test.Sdk" Version="15.3.0" /> |
There was a problem hiding this comment.
@hitenjava Microsoft.NET.Test.Sdk and Rest.ClientRuntime.Azure.TestFramework references are implicitly added to your project, so you don't have to explicitlty add them.
When we change these packages or upgrade them, your project will be automatically upgraded at the same time.
Having such explicit references inhibit us to upgrade repo wide such changes.
|
@hitenjava Update the full Azure github path to the swagger in the summary: https://github.com/Azure/azure-rest-api-specs/tree/current/specification/datamigration/resource-manager/Microsoft.DataMigration/2017-11-15-preview |
…estFramework references.
rohit-joy
approved these changes
Nov 16, 2017
shahabhijeet
approved these changes
Nov 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to swagger here -
https://github.com/Azure/azure-rest-api-specs/tree/current/specification/datamigration/resource-manager/Microsoft.DataMigration/2017-11-15-preview
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.