Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build issue and enum casing bug for Azure Batch #3861

Merged
merged 4 commits into from
Nov 17, 2017

Conversation

matthchr
Copy link
Member

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

The PR for the Swagger for this change is here: Azure/azure-rest-api-specs#2008

@matthchr
Copy link
Member Author

@shahabhijeet - I made some changes to csproj files... which at least for me and my coworkers were required to get things to work locally -- not sure what you guys changed/did to the common include projects but it looks like you turned signing off?

@xingwu1 @darylmsft - This fixes the enum casing bug reported by a few customers.

@matthchr matthchr force-pushed the feature/batch-enum-hotfix branch from f16f38b to f8709b3 Compare November 15, 2017 17:14
@shahabhijeet shahabhijeet merged commit 6da04f1 into Azure:psSdkJson6 Nov 17, 2017
@matthchr matthchr deleted the feature/batch-enum-hotfix branch November 17, 2017 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants