Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[preview] apply enhanced analysis rules #38560

Closed
wants to merge 4 commits into from

Conversation

archerzz
Copy link
Member

@archerzz archerzz commented Sep 7, 2023

  • update the client sdk analyzer to alpha build
  • add globla config to suppress enhanced analysis rules
  • modify ci steps to support suppression by a property
  • applying the property to already impacted sdk projects for backward compatibility

upstream PR on Azure.ClientSdk.Analyzers: Azure/azure-sdk-tools#6916

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

- update the client sdk analyzer to alpha build
- add globla config to suppress enhanced analysis rules
- modify ci steps to support suppression by a property
- applying the property to already impacted sdk projects for backward compatibility
@archerzz
Copy link
Member Author

archerzz commented Sep 7, 2023

I could not reproduce CS9057 on my local build dotnet build ./eng/service.proj. A google search indicates that it's probably because I upgraded the Roslyn of Azure.ClientSdk.Analyzers to a too high version which exceeds the version of the Roslyn bundled with .NET SDK we're using: https://stackoverflow.com/questions/76740942/how-to-fix-the-analyzer-assembly-references-version-4-7-0-0-of-the-compiler

I'll try to downgrade the Roslyn version and have another try.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@scottaddie scottaddie added Monitor Monitor, Monitor Ingestion, Monitor Query and removed Monitor - Query labels Sep 26, 2023
@archerzz
Copy link
Member Author

Close since the changes have been applied in #39518

@archerzz archerzz closed this Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants