Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebSites] Fixes to HTTP response codes, missing enum properties #3820

Merged
merged 3 commits into from
Nov 7, 2017

Conversation

nking-1
Copy link

@nking-1 nking-1 commented Oct 27, 2017

Description

This change adds some missing HTTP response codes for APIs required by the PowerShell project. It also adds missing SKUs to the AppServicePlans. It is needed to get our new PowerShell commands working. Most of the files have been modified with a small comment due to an Autorest update.


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@nking-1
Copy link
Author

nking-1 commented Oct 30, 2017

@shahabhijeet Can you please review this PR?

@@ -1,15 +1,15 @@
// <auto-generated>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generated code looks fine, but:

(1) Please include the metadata file here:https://github.com/Azure/azure-sdk-for-net/tree/psSdkJson6/src/SDKs/_metadata which is automatically generated by AutoRest
(2) Please update the csproj with release notes and a version update
(3) Please include tests

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(1) I can't find this metadata file anywhere after generating the code with AuotRest. I'm running "autorest --csharp" from azure-rest-api-specs/specification/web/resource-manager with autorest 2.0.4166. The only output I see is C# code. Any advice on how I can get the metadata?
(3) I'll include a test for the PremiumV2 SKU that was added, but other updates in the PR are just metadata changes. Recorded tests should still be passing. Hopefully that's good enough for now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nking92 if you do not have a generate.cmd under you sdk folder, you should create one by modelling it from other RPs.
Let me know if you cannot find the generate.cmd file which will generate your SDK

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, I was trying to directly use autorest instead of using the generate.cmd script. I regenerated with that script in the latest commit. It's a large number of changes once again, but it is working fine with our PowerShell project, which is good news.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened an issue to write more tests at #3844. Our API is so large that I would not be able to test it all without a huge time investment. I realize tests important, but we are also under pressure to get an SDK update published, which we can use for PowerShell, which has some broken commands that are causing pain for customers.

@markcowl markcowl merged commit 99834e2 into Azure:psSdkJson6 Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants