Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-generate SDKs/Resource with new Policy APIs #3768

Closed
wants to merge 2 commits into from

Conversation

pilor
Copy link
Contributor

@pilor pilor commented Oct 5, 2017

Description

Re-generates SDKs/Resource off of the latest swagger spec. The only changes compared to the previous version is the introduction of new parameters in existing policy resource types and the introduction of policySetDefinitions.

Swagger PR: Azure/azure-rest-api-specs#1691

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@@ -4,7 +4,7 @@
<PackageId>Microsoft.Azure.Management.ResourceManager</PackageId>
<Description>Provides resource group and resource management capabilities for Microsoft Azure.</Description>
<AssemblyName>Microsoft.Azure.Management.ResourceManager</AssemblyName>
<VersionPrefix>1.6.0-preview</VersionPrefix>
<VersionPrefix>1.7.0-preview</VersionPrefix>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pilor missing TargetFramework property

@shahabhijeet
Copy link
Member

@pilor please reopen this PR once you have addressed the feedback. Leaving PR open without addressing feedback causes us to get our SLA data our of sync.
You can always reopen PR once you are ready to merge or address it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants