Cancel pipeline run API #3757
Cancel pipeline run API #3757
Conversation
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. See License.txt in the project root for | ||
| // license information. | ||
| // | ||
| // Code generated by Microsoft (R) AutoRest Code Generator. | ||
| // Code generated by Microsoft (R) AutoRest Code Generator 2.2.22.0 |
There was a problem hiding this comment.
How did you generate the code? I don't get these version numbers when I do it
There was a problem hiding this comment.
I ran "autorest" that is installed with npm, I believe I have the latest version.
There was a problem hiding this comment.
I ran "autorest".
There was a problem hiding this comment.
I regenerated SDK based on latest instructions (use .md file as config source)
| ## Version 0.2.1-preview | ||
|
|
||
| ### Feature Additions | ||
| * Cancel pipeline run api |
There was a problem hiding this comment.
"Adding an API to cancel a pipeline run."
| @@ -4,3 +4,8 @@ | |||
|
|
|||
| ### Feature Additions | |||
| * Initial public release of the Azure Data Factory V2 .NET SDK. | |||
|
|
|||
| ## Version 0.2.1-preview | |||
There was a problem hiding this comment.
please move this section above the existing one, so the latest version is the first one from the top. thanks!
There was a problem hiding this comment.
Missing scenario tests for the entire product. Look at the issue assigned to @bgold09.
Also I don't see metadata.txt file that is generated when you use generate.cmd to generate your code.
Also please add description that clearly describes the PR and the change you are making, also add link to the spec change PR.
| @@ -3,7 +3,7 @@ | |||
| <PropertyGroup> | |||
| <PackageId>Microsoft.Azure.Management.DataFactory</PackageId> | |||
| <Description>Azure Data Factory V2 is the data integration platform that goes beyond Azure Data Factory V1's orchestration and batch-processing of time-series data, with a general purpose app model supporting modern data warehousing patterns and scenarios, lift-and-shift SSIS, and data-driven SaaS applications. Compose and manage reliable and secure data integration workflows at scale. Use native ADF data connectors and Integration Runtimes to move and transform cloud and on-premises data that can be unstructured, semi-structured, and structured with Hadoop, Azure Data Lake, Spark, SQL Server, Cosmos DB and many other data platforms.</Description> | |||
| <VersionPrefix>0.2.0-preview</VersionPrefix> | |||
| <VersionPrefix>0.2.1-preview</VersionPrefix> | |||
There was a problem hiding this comment.
@milantomic6 missing package release notes
Add < PackageReleaseNotes > and add Release notes.
I would recommend to use < 
|
@milantomic6 please reopen this PR once you have addressed the PR feedback. |
|
Added scenario test. |
Description
Adding an API to cancel single pipeline run.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
Azure/azure-rest-api-specs#1782 (comment)