-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prototype sketching JSON Merge Patch convenience APIs #37341
Closed
Closed
Changes from all commits
Commits
Show all changes
121 commits
Select commit
Hold shift + click to select a range
b2e5f4c
Update serializer (#35735)
nisha-bhatia 87671e8
Update serializer (#35741)
nisha-bhatia c1497f7
[Azure.Core] add List property tests and update ReadOnly Test (#35904)
nisha-bhatia be4d2de
[Azure.Core] Update SerializableOptions.cs (#35947)
nisha-bhatia b9a827c
[Azure.Core] add test helper for Models (#35968)
nisha-bhatia 3653783
[Azure.Core] Update IJsonSerializable with non Try methods (#36164)
nisha-bhatia 678a804
Add scaffolding for readme (#36342)
m-nash 2f6b08b
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-net int…
m-nash ab768c5
Add use cases for explicit casts (#36391)
m-nash 79bb9f6
[Azure.Core] Update Serializer (#36376)
nisha-bhatia 7da48fa
Add use cases for stj (#36399)
m-nash 3ea55f7
[Azure.Core] Add public static deserializer (#36402)
nisha-bhatia 03d2c71
Add model serializer example (#36418)
m-nash 6126493
[Azure.Core] Add NewtonSoft Json example (#36453)
nisha-bhatia 7696902
add generic modeljsonconverter (#36854)
m-nash bf164e9
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-net int…
m-nash 8069f69
[Azure.Core] Add Newton soft BYOM case (#36794)
nisha-bhatia a905618
merge from main
m-nash e67e2c0
regen api after merge
m-nash c18eba6
Demo of what it would look like for public surface (#36857)
m-nash 8ce8618
[Azure.Core] Add XmlSerializer (#37155)
nisha-bhatia 852fd64
add examples for combined interface (#37245)
m-nash c4838b9
merge main
m-nash 6c173b0
regen api after merge
m-nash 74bd112
Update to v1 api surface (#37276)
m-nash 6532ade
Starting prototype 2
annelo-msft 7928e8a
Initial pass on non tree-building implementation
annelo-msft 4ed9c30
fix
annelo-msft 85ccca6
fix but needs tidy
annelo-msft 1413df1
add tests
annelo-msft dc3f1f9
delete
annelo-msft 11f2de8
Handle more cases - midstream
annelo-msft 3710781
metric test - pass
annelo-msft 9ee484e
wip
m-nash 3eb1a0a
nit
annelo-msft d5323bd
update benchmark to use a real model from compute
m-nash 619c6cf
update api
m-nash 651c016
wip (#37351)
nisha-bhatia 64d0aec
add multi buffer option and benchmarks for larger object
m-nash 6502ff4
minor fixes on perf
m-nash c8694ad
Merge branch 'feature/updateSerializer' of https://github.com/Azure/a…
m-nash 59bce55
perf updates and split the xml / json interfaces so we can take Utf8J…
m-nash 39cdcec
wip (#37544)
nisha-bhatia 1da1e4b
add delayed RequestContent to improve implicit cast perf
m-nash 234e4ca
merge from feature/updateSerializer
m-nash d520bea
fixes after merge
m-nash 334e672
add utf8jsonreader deserialize
m-nash ebc6e4d
update for the rest of the test models with jsonreader
m-nash f06e0bb
update api
m-nash c8c7586
fix typo
m-nash 95f8795
[Azure.Core] Update options to use Format string (#37467)
nisha-bhatia 752bb88
upload bimodal repro
m-nash 9ec2b5a
return values from benchmarks
m-nash b2e85cf
merge from feature/updateSerializer
m-nash 1499973
updates after merge
m-nash 20a3e99
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-net int…
m-nash ad923da
Merge branch 'feature/updateSerializer' of https://github.com/Azure/a…
m-nash 8fd2442
Merge remote-tracking branch 'upstream/main' into core-mergepatch-proto2
annelo-msft 3fba075
update modelserializeroptions to a struct
m-nash 62984b2
Merge remote-tracking branch 'upstream/mnash-perfChecks' into core-me…
annelo-msft 66b486f
Merge remote-tracking branch 'upstream/main' into core-mergepatch-proto2
annelo-msft 8002f7b
move core bits to IJusonModelSerializable
annelo-msft 08cad66
Merge remote-tracking branch 'upstream/main' into core-mergepatch-proto2
annelo-msft 95f1ee0
Update load balancer with interfaces
annelo-msft 42a6698
remove WritePatch method and move to IJsonModelSerializable.Serialize
annelo-msft 511a7c7
nit
annelo-msft b660174
Update helper types for collection interfaces
annelo-msft 08fa4d8
Updates
annelo-msft 86efc30
wip
m-nash cee1dd0
Merge remote-tracking branch 'upstream/main' into core-mergepatch-proto2
annelo-msft a69fdf5
Merge remote-tracking branch 'upstream/mnash-perfChecks' into core-me…
annelo-msft 7f8dff0
update to split request content and sequence writer
m-nash 89f20a6
update api
m-nash 5f7bcfa
remove static azure default options since new is zero alloc
m-nash 34c0f6b
update api
m-nash 7794f4c
Update format to have J and W and implement json always on xml models…
m-nash c331189
add non generic overloads in modelserializer
m-nash 4efe90d
Revert "update api"
m-nash e94342d
Revert "remove static azure default options since new is zero alloc"
m-nash f0a6dee
wip
m-nash 7130324
merge from feature/updateSerializer
m-nash 85bec36
Merge remote-tracking branch 'upstream/main' into core-mergepatch-proto2
annelo-msft 2f5f450
updates after merge
m-nash e6c8b33
update api
m-nash 5ed46aa
Make client tests pass and record
annelo-msft d483d53
Add test for round-trip
annelo-msft 8fc2075
Use cast to deserialize
annelo-msft 73d7936
Remove GetBytes helper method
annelo-msft 8fcd01a
Merge remote-tracking branch 'upstream/mnash-perfChecks' into core-me…
annelo-msft e7c5f83
Implement new IModelSerializable.Serialize API
annelo-msft 55fc435
Back up initial benchmark work
annelo-msft 8211f45
complete benchmark
annelo-msft 4a15aba
Merge remote-tracking branch 'upstream/main' into core-mergepatch-proto2
annelo-msft 5b19c87
renames and comments for clarity in the write PATCH JSON loop, small …
annelo-msft 129a3fa
pre-span updates
annelo-msft de0ca93
WIP on span impl
annelo-msft ac87b57
Merge remote-tracking branch 'upstream/main' into core-mergepatch-proto4
annelo-msft 4a96e92
Update
annelo-msft 76edeed
move segment iteration to span APIs; works but pls refactor
annelo-msft 05a1828
light refactor
annelo-msft e3f8761
bug fix and new failing test
annelo-msft 3a3aff5
bug fix; more tests
annelo-msft 5e1b402
more refactoring
annelo-msft 7db4c62
more refactorig
annelo-msft 1ea89dd
Add a span API for GetProperty
annelo-msft a156a10
reshuffle
annelo-msft edd3e98
more refactoring
annelo-msft da8518c
Merge remote-tracking branch 'upstream/main' into core-mergepatch-proto4
annelo-msft b3ff017
Merge remote-tracking branch 'upstream/main' into core-mergepatch-proto2
annelo-msft 0a63b92
Merge branch 'core-mergepatch-proto4' into core-mergepatch-proto2
annelo-msft 405f3d8
Merge remote-tracking branch 'upstream/main' into core-mergepatch-proto2
annelo-msft 9626c59
Merge remote-tracking branch 'upstream/main' into core-mergepatch-proto4
annelo-msft a31b8c3
rewrite sorted change retrieval
annelo-msft 6e50985
remove descendants from change enumeration
annelo-msft dd0c911
simple delete
annelo-msft 2dca05d
Merge branch 'core-mergepatch-proto4' into core-mergepatch-proto2
annelo-msft 6bba73f
small refactor
annelo-msft 70d764f
nits
annelo-msft 660076f
Merge remote-tracking branch 'upstream/main' into core-mergepatch-proto2
annelo-msft bc113bc
Update Test model with required property in constructor
annelo-msft 10bbac9
Add validation that required property isn't included in Merge Patch b…
annelo-msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add an overload of Create that takes the same format enum as we plan to use for IModelSerializable?
i.e. RequestContent.Create(data, ModelFormat.Patch);