Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add release notes for 1.7.0-preview #3732

Merged
merged 2 commits into from
Sep 26, 2017
Merged

Add release notes for 1.7.0-preview #3732

merged 2 commits into from
Sep 26, 2017

Conversation

jaredmoo
Copy link
Contributor

@jaredmoo jaredmoo commented Sep 22, 2017 •
edited
Loading

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

shahabhijeet
shahabhijeet previously requested changes Sep 22, 2017
View reviewed changes
src/SDKs/SqlManagement/Management.Sql/Microsoft.Azure.Management.Sql.csproj Outdated
@@ -9,5 +9,79 @@
</PropertyGroup>
<PropertyGroup>
<TargetFrameworks>net452;netstandard1.4</TargetFrameworks>
<PackageReleaseNotes>Disclaimer:

We were using a slightly unorthodox convention for some operation ids. Some resource operations were “nested” inside others, e.g. blob auditing policies was nested inside databases as in client.Databases.GetBlobAuditingPolicies(..) instead of the flattened ARM standard client.DatabaseBlobAuditingPolicies.Get(…).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to use <[CData that helps to format xml upto quite some extent

@markcowl markcowl dismissed shahabhijeet’s stale review September 26, 2017 00:29

Comments addressed

@markcowl markcowl merged commit 0b7e015 into Azure:psSdkJson6 Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markcowl markcowl markcowl approved these changes

@shahabhijeet shahabhijeet shahabhijeet left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaredmoo @markcowl @shahabhijeet @msftclas