-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] Support SAS authentication #37310
Conversation
API change check APIView has identified API level changes in this PR and created following API reviews. Azure.Maps.Common |
@dubiety could you please add your self and team to the code owners alias list here - https://github.com/Azure/azure-sdk-for-net/blob/main/.github/CODEOWNERS. Also, please let us know if you need any help with the reviews. |
@dubiety I am assuming you are already working with the architects on the API review and shape and merely looking for help from us for merging etc.? |
Hi @pallavit , yes, the API is reviewed by API review board previously. Just some minor changes and need your help to confirm if the updated changes follows SDK best practice or coding convention etc. :) |
@pallavit and @christothes , I've addressed all the comments, it would be much appreciated if you can help to review the PR. Thank you so much! |
LGTM. /cc: @christothes in case you have any further comments. |
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.