Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Support SAS authentication #37310

Merged
merged 22 commits into from
Jul 6, 2023
Merged

Conversation

dubiety
Copy link
Member

@dubiety dubiety commented Jun 29, 2023

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jun 29, 2023

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.Maps.Common
Azure.Maps.Search
Azure.Maps.Geolocation
Azure.Maps.Rendering
Azure.Maps.Routing

@pallavit
Copy link
Contributor

@dubiety could you please add your self and team to the code owners alias list here - https://github.com/Azure/azure-sdk-for-net/blob/main/.github/CODEOWNERS. Also, please let us know if you need any help with the reviews.

@dubiety dubiety requested a review from ronniegeraghty as a code owner June 30, 2023 01:42
@dubiety
Copy link
Member Author

dubiety commented Jun 30, 2023

Hi @pallavit and @jsquire , I updated codeowner for /sdk/maps and need your help to review this PR. Thank you so much!

@pallavit
Copy link
Contributor

@dubiety I am assuming you are already working with the architects on the API review and shape and merely looking for help from us for merging etc.?

@dubiety
Copy link
Member Author

dubiety commented Jul 3, 2023

I am assuming you are already working with the architects on the API review and shape and merely looking for help from us for merging etc.?

Hi @pallavit , yes, the API is reviewed by API review board previously. Just some minor changes and need your help to confirm if the updated changes follows SDK best practice or coding convention etc. :)

@dubiety dubiety requested review from andykao1213 and khmic5 July 4, 2023 01:49
@dubiety dubiety changed the title Feature/support sas auth [Maps] Support SAS authentication Jul 4, 2023
@dubiety dubiety added the Maps label Jul 4, 2023
@dubiety
Copy link
Member Author

dubiety commented Jul 5, 2023

@pallavit and @christothes , I've addressed all the comments, it would be much appreciated if you can help to review the PR. Thank you so much!

@pallavit
Copy link
Contributor

pallavit commented Jul 5, 2023

LGTM. /cc: @christothes in case you have any further comments.

@dubiety dubiety merged commit 2b39d1a into Azure:main Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants