Add trailing newlines to shared code #36250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without newlines, shared files may break linting rules in the autorest.csharp repo
hallipr
requested review from
JoshLove-msft,
christothes,
annelo-msft and
KrzysztofCwalina
as code owners
m-nash
approved these changes
May 12, 2023
|
Why do we have this linting rule? I worry that since we don't have the same rules in this repo, nothing prevents this from breaking in the future. |
|
API change check API changes are not detected in this pull request. |
I don't disagree with the rule for consistency sake. We also don't have a standard encoding for the repo. Just looking at cs files, 71k have no bom, 9.5k do. 79k have trailing new lines, 1.5k don't. |
This was referenced May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without newlines, shared files may break linting rules in the autorest.csharp repository