Bug fix and small perf improvement to MJD WriteTo() #35744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annelo-msft
requested review from
KrzysztofCwalina,
tg-msft,
JoshLove-msft and
christothes
as code owners
annelo-msft
requested review from
heaths,
jsquire and
AlexanderSher
and removed request for
tg-msft,
christothes,
KrzysztofCwalina,
JoshLove-msft and
heaths
annelo-msft
requested review from
tg-msft,
christothes,
KrzysztofCwalina and
JoshLove-msft
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
heaths
approved these changes
Apr 22, 2023
There was a problem hiding this comment.
The changes look good sans context, but I have to admit seeing the change to use ReadOnlyMemory<byte> threw me a bit for something called "mutable". With tests passing, and because you're using WriteTo to write to another stream (or throw), I see no reason to block.
jsquire
approved these changes
Apr 24, 2023
christothes
approved these changes
Apr 24, 2023
That makes sense! The thinking is -- we never make changes to the original JSON buffer -- instead, changes are held in the changelist and any reads/serialization operations consult the changelist prior to returning a value. |
|
@annelo-msft thanks for the explanation. I hadn't really been following the development of this part of the JSON-related code, but seems pretty handy. From your tests, seems it can also serialize/format a JSON merge+patch, yeah? |
Not today, but that is definitely on our roadmap! The changelist approach should enable that without a lot of addition. |
HuangXin-MS
added a commit
that referenced
this pull request
May 11, 2023
commit 84bb9e8d1e3fdc68228c14dd9bfef36bc347b030 Author: Arthur Ma <[email protected]> Date: Wed May 10 08:43:41 2023 +0800 Rename folder for 2 RPs (#36124) commit 8c97b6da304badd62aeaf5b8cce9a6d1285b401e Author: Rajkumar Rangaraj <[email protected]> Date: Tue May 9 16:36:54 2023 -0700 Set default SamplingRatio (#36163) commit 958088b15d90579eaa7d9bfbc055ec3e98523383 Author: Yingying Wu <[email protected]> Date: Tue May 9 15:41:30 2023 -0700 Feature/call automation improvements (#36158) * update swagger and add improvements commit 1da99c3364d056245ca8d548a85375328d882298 Author: Anne Thompson <[email protected]> Date: Tue May 9 15:31:27 2023 -0700 Move DynamicData to Experimental for release (#36145) * Move DynamicData to Experimental for release * docs * Changelog * fix * fix * fix commit 34ce68132cd72c0d1d4172f0bc68941917ae6fe2 Author: JoshLove-msft <[email protected]> Date: Tue May 9 13:31:53 2023 -0700 Prepare for release (#36146) * Prepare for release * format commit 07444655d60c52abcf11167ad598e627e3a8f0fd Author: Jacob Lauzon <[email protected]> Date: Tue May 9 13:00:30 2023 -0700 [Storage][DataMovement] Fixed `ContinueOnFailure` not being respected (#36121) commit dc1faafc465d35b303ce716098f6b703090331fe Author: Timothy Mothra <[email protected]> Date: Tue May 9 12:17:12 2023 -0700 prep release (#36138) commit ea3b6f9177f787168fb4564c474a997884874325 Author: Azure SDK Bot <[email protected]> Date: Tue May 9 12:09:15 2023 -0700 Increment package version after release of Azure.Messaging.EventHubs.Processor (#36140) commit 94dbfb8810d2921b4830fbf6c6b05cef95488424 Author: Rajkumar Rangaraj <[email protected]> Date: Tue May 9 11:18:05 2023 -0700 [AzureMonitorExporter] Update Changelog for _OTELRESOURCE_ metrics (#36136) * Update Changelog * Update * Update * Update commit 62fab24b3ff5b9c24d49b758364ecb23f6ee5693 Author: Anne Thompson <[email protected]> Date: Tue May 9 11:08:50 2023 -0700 [ACR] Update readme with blob samples (#36139) * Update readme with blob samples * Add links commit 79fd982c0ef9944f113754ec9f17e393b2110f0e Author: Jesse Squire <[email protected]> Date: Tue May 9 12:22:41 2023 -0400 [Event Hubs] Temporarily resolve version conflict (#36135) The focus of these changes is to resolve a temporary version conflict resulting from project references to the core and processor, where the processor has an explicit reference to the core package on NuGet. commit 4f0f6bdc6e661871169abc1cc06114856399c999 Author: Jocelyn <[email protected]> Date: Tue May 9 12:17:37 2023 -0400 `PartitionedDownloader` master crc (#36110) * initial implementation * refactoring commit 76978b4c3d96df762972266036db33578e568ed1 Author: Vishwesh Bankwar <[email protected]> Date: Tue May 9 08:48:55 2023 -0700 [OpenTelemetry.AspNetCore] Add sampler config via options (#36111) * Add ampler config via options * chngelog * update test * update demo * fix test commit 46ec874efc8748feacd7deb81e075260c7515692 Author: Azure SDK Bot <[email protected]> Date: Tue May 9 08:24:43 2023 -0700 Increment package version after release of Azure.Messaging.EventHubs (#36134) commit d00cc4732513d87ef2d63b86f7efeadb75c8a317 Author: Jesse Squire <[email protected]> Date: Tue May 9 10:58:57 2023 -0400 [Event Hubs Processor] Prepare for May Release (#36107) The focus of these changes is to prepare the Event Hubs Processor package for the May release. commit e1e0f75f745488cb84a96a7209b6023783eb644f Author: buti1021 <[email protected]> Date: Tue May 9 14:34:38 2023 +0200 fix link (#36132) commit afb9c71bbd393ec8d46174852a90bd0c2e3462e1 Author: Azure SDK Bot <[email protected]> Date: Tue May 9 05:34:16 2023 -0700 Increment package version after release of Azure.AI.AnomalyDetector (#36128) commit 999c623f5d9f90a80f67988642ec15786dba8728 Author: malpaniHMC <[email protected]> Date: Mon May 8 22:37:21 2023 -0700 updating api version for traffic controller (#36026) * updating api version for traffic controller * updating test records * addressing comments, removing azure.core nuget --------- Co-authored-by: Arthur Ma <[email protected]> commit e6942846e8a32e6ef4ddad4483706e3f37eaad94 Author: m-nash <[email protected]> Date: Mon May 8 21:43:26 2023 -0700 prepare mvad for release of preview.7 (#36125) commit 0e60cf60c3e178fe27e563eeed997faaf622b629 Author: Theodore Chang <[email protected]> Date: Mon May 8 22:36:02 2023 -0400 Feature/cplat 2023 03 01 track2 (#35676) commit 5c85f2ac2720fdb814bded141096b91308d18a76 Author: JoshLove-msft <[email protected]> Date: Mon May 8 17:39:37 2023 -0700 Remove unreleased customHeaders property (#36123) commit 09d945f5647a9116aaed0bd01f80adecf2220115 Author: Azure SDK Bot <[email protected]> Date: Mon May 8 16:14:33 2023 -0700 Update AutoRest C# version to 3.0.0-beta.20230508.2 (#36118) * Update SDK codes * Update SDK codes * Update SDK codes * Update SDK codes * Update SDK codes * Update Generator Version 3.0.0-beta.20230508.2 * Update SDK codes commit 7632e617a3c4043db9139a38b77d3ec5c9d350dd Author: nisha-bhatia <[email protected]> Date: Mon May 8 15:53:37 2023 -0700 wip (#36112) commit 44a159609fc2051e5cad9a650aa257059c02f084 Author: Azure SDK Bot <[email protected]> Date: Mon May 8 14:56:07 2023 -0700 Fix broken podman link (#36114) Co-authored-by: Wes Haggard <[email protected]> commit 459de248e07f47b51ba91ee81ae652e9dedf382b Author: Liudmila Molkova <[email protected]> Date: Mon May 8 14:31:32 2023 -0700 Update Sample05_UploadDownloadImage.md (#36115) commit 531391ea5bdce3739072297e945e03deb2cd6aa3 Author: Jesse Squire <[email protected]> Date: Mon May 8 16:08:26 2023 -0400 [Event Hubs] Prepare for May Release (#36106) * [Event Hubs] Prepare for May Release The focus of these changes is to prepare the Event Hubs core package for the May release. * Removing empty change log sections. commit 0dbe382cb2067f5f442f3f7142b499f28264bf37 Author: Anne Thompson <[email protected]> Date: Mon May 8 12:11:07 2023 -0700 Enable MutableJsonDocument to use DynamicData serializer options for changes (#36102) * Add implicit cast operators for types supported by JsonElement * Reimplement as TryGet, add try cast and catch to numbers * Refactor * Add some tests * Delegate type converstion to JsonElement * Update tests to use InvalidCastException * string * Numbers * API * More numbers * Guid tests and some updates to number tests * Make reference type casts explicit casts; more Guid tests * DateTime and DateTimeOffset * Export API * Pass serialization options to DynamicData * tidy * tidy * Fix change.ToString() * Address numerical precision issues on net462 * PR FB * Fix bad merge * Update public test * Enable case-insensitive deserialization while keeping case-mappings for serialization * revert test change * nit tidy * pr fb * pr fb commit 637b1e5cbdbd978f52aa6baada1340f7e7939616 Author: Jesse Squire <[email protected]> Date: Mon May 8 14:31:01 2023 -0400 [EngSys] Remove Outdated Stress Framework (#36064) * [EngSys] Remove Outdated Stress Framework The focus of these changes is to delete the outdated stress framework that should no longer be used and remove references to it. The stress projects removed were confirmed to have been empty from the example template and did not contain any actual tests. It has also been confirmed that this change does not impact code generation. commit b13d458c07bdba40f48e55b5fc4c4bf657bf25eb Author: Rajkumar Rangaraj <[email protected]> Date: Mon May 8 11:01:51 2023 -0700 [AzureMonitorExporter] Add _OTELRESOURCE_ metrics (#36063) * _OTELRESOURCE_ * PR feedback commit af1fedb011e930d4c5265f246154efe49909ff60 Author: williamzhao87 <[email protected]> Date: Mon May 8 13:37:57 2023 -0400 Fix manual reclassify action (#36060) commit 018dd6d067d0eb8c19f2f783ca520ef84a4093d5 Author: Anne Thompson <[email protected]> Date: Mon May 8 10:04:32 2023 -0700 Add implicit cast operators to DynamicData for types supported by JsonElement (#36054) * Add implicit cast operators for types supported by JsonElement * Reimplement as TryGet, add try cast and catch to numbers * Refactor * Add some tests * Delegate type converstion to JsonElement * Update tests to use InvalidCastException * string * Numbers * API * More numbers * Guid tests and some updates to number tests * Make reference type casts explicit casts; more Guid tests * DateTime and DateTimeOffset * Export API * Fix change.ToString() * Address numerical precision issues on net462 * PR FB commit 4b4391a9ba5c7e155b276a54e98ac74efd3613d2 Author: Azure SDK Bot <[email protected]> Date: Mon May 8 07:27:57 2023 -0700 Update Generator Version 3.0.0-beta.20230508.1 (#36096) commit 3dabe803237d666074acbe5059703389ea8b3cf4 Author: Arthur Ma <[email protected]> Date: Mon May 8 11:57:59 2023 +0800 Upgrade the Azure.ResourceManager dependent to 1.5.0 (#35895) commit 6b1372a2cbaa29e1c28b4c7c1b60c362f8a77f2e Author: Azure SDK Bot <[email protected]> Date: Sat May 6 07:06:14 2023 -0700 Increment package version after release of Azure.ResourceManager.ResourceHealth (#36083) commit 166f919fbdaf96ba89cdac6b6199432ed2327625 Author: Chenyang Liu <[email protected]> Date: Sat May 6 19:37:09 2023 +0800 Fix the issue that connectionId is not set (#36070) commit d6d116a37f1b72ce25ee57ff00d48ccfde303215 Author: Arthur Ma <[email protected]> Date: Sat May 6 19:05:08 2023 +0800 Polish the Azure.ResourceManager.ResourceHealth for first stable (#35899) commit 4a361bc862c3fb584ca33c1a9553c420196d9802 Author: Azure SDK Bot <[email protected]> Date: Sat May 6 02:29:48 2023 -0700 Update Generator Version 3.0.0-beta.20230505.7 (#36075) commit 13c61af814f4bd970e06c4426343620464ffd159 Author: mcgallan <[email protected]> Date: Sat May 6 15:56:30 2023 +0800 fixed issue (#36071) commit 9469e022e25cb3109bf90672aff1ff3145f8b156 Author: Azure SDK Bot <[email protected]> Date: Fri May 5 22:26:44 2023 -0700 Update AutoRest C# version to 3.0.0-beta.20230505.6 (#36073) * Update Generator Version 3.0.0-beta.20230505.6 * Update SDK codes * Update SDK codes * Update SDK codes * Update SDK codes * Update SDK codes * Update SDK codes * Update SDK codes * introduce a new test case in resource manager to validate the new fix could work * migrate the customized code to configuration --------- Co-authored-by: Arcturus Zhang <[email protected]> commit bb5422139cfd118e2a51d8f7d7dcf0ec5dbcde62 Author: Azure SDK Bot <[email protected]> Date: Fri May 5 17:20:28 2023 -0700 Update AutoRest C# version to 3.0.0-beta.20230505.5 (#36068) * Update Generator Version 3.0.0-beta.20230505.5 * Update SDK codes * Update SDK codes * Update SDK codes * Update SDK codes * Update SDK codes * Update SDK codes * Update SDK codes commit 882f9d99787b596eb4238abd817a8fa13c1e3c84 Author: Scott Addie <[email protected]> Date: Fri May 5 17:52:39 2023 -0500 Add Monitor Query README section for metric splitting (#36053) * Add Monitor Query README section for metric splitting * React to feedback * Enable query metrics tests * Move comment commit 407b666a0ad4a2c020874d86645b34abb5bbb7eb Author: Adam Tazi <[email protected]> Date: Fri May 5 15:05:22 2023 -0700 Update CallMedia, CallConnection, and CallRecording methods and models based on ABR feedback (#35746) * add media fixes * add callconnection and callrecording updates * revert playmedia() method back to play() * export api * update media docstrings and playoptions * update api * add simple method overloads for play commit 03cc79f5333406a26a2f4b455539e8fb8e6e10d5 Author: Amanda Nguyen <[email protected]> Date: Fri May 5 13:53:55 2023 -0700 [Storage] [DataMovement] Updated sync copy tests to actually use the sync option and not default to async (#36022) * Updated sync copy tests to actually use the sync option and not default to async * Added missing Async option in the directory async copy tests * Disable large tests again commit ed179888f12c57618b6ab84ef0aa79daeaa0e66d Author: Jacob Lauzon <[email protected]> Date: Fri May 5 13:21:45 2023 -0700 [Storage][DataMovement] Fix transfers using root `BlobStorageResourceContainer` (#36023) commit 656d6b3dad042cfd5886fed74dee97f239e345df Author: JoshLove-msft <[email protected]> Date: Fri May 5 13:10:03 2023 -0700 Add new system events for May release (#36062) * Add new system events for May release * Change log commit fe473ceb8a77746247f4bfe941f11d1438787f80 Author: Azure SDK Bot <[email protected]> Date: Fri May 5 12:40:51 2023 -0700 Update AutoRest C# version to 3.0.0-beta.20230505.4 (#36057) * Update Generator Version 3.0.0-beta.20230505.4 * Update SDK codes * Update SDK codes * Update SDK codes * Update SDK codes * Update SDK codes * Update SDK codes * ignore failing tests --------- Co-authored-by: m-nash <[email protected]> commit 33872e4a53c9b888ad753aca28020b5e68ffe99b Author: Heath Stewart <[email protected]> Date: Fri May 5 12:01:58 2023 -0700 Test authentication when Key Vault switches tenants (#35087) * Support switching tenant IDs Fixes #25086 * Resolve PR feedback * Assert the call count Alternatively, I could increment the count only when the tenant ID is specified, but @christothes and I agree the comments here are clearer. commit aa4642b2c26cc04d3b14c98c622d5e3e4747085c Author: wangrui-msft <[email protected]> Date: Fri May 5 11:32:53 2023 -0700 revert evendata back to original name (#36055) * revert evendata back to original name * fix event parse commit add187a1460369927102d4bdde84bd00abde07ad Author: Azure SDK Bot <[email protected]> Date: Fri May 5 11:09:14 2023 -0700 Update GitHubEventProcessor version and remove pull_request_review procesing (#36056) Co-authored-by: James Suplizio <[email protected]> commit 4e825661d336196400bf2f47f740d758f68ca0a7 Author: Amanda Nguyen <[email protected]> Date: Fri May 5 11:04:09 2023 -0700 Disable test cause of flakiness of reading the file while it's still in use (#36017) commit ad5431bab9d59e67c6c4c67156d76d09bdc32eb0 Author: Amanda Nguyen <[email protected]> Date: Fri May 5 10:46:23 2023 -0700 Fix to prevent empty strings or null to be passed as paths for LocalFileStorageResource and LocalDirectoryStorageResourceContainer. (#36015) commit f6c7e520a21acf29c1fa7fda7af2dfb7f4ca818f Author: Jesse Squire <[email protected]> Date: Fri May 5 13:44:32 2023 -0400 [Smoke Tests] Update target frameworks (#36050) The focus of these changes is to update the target frameworks to replace `net461` with `net462` now that the former has gone out of support. commit 35be0f8fdae6d4ebeed7b6cda3e6890ff1e40d75 Author: mcgallan <[email protected]> Date: Sat May 6 01:37:17 2023 +0800 Automation tests (#35545) commit b66a02df1d7ae05d88f8fcbee1b373b5740890db Author: mcgallan <[email protected]> Date: Sat May 6 01:36:56 2023 +0800 Add Data protection test (#35757) commit 1a29975770a27acc938d325d52a1a14baff09b8a Author: mcgallan <[email protected]> Date: Sat May 6 01:36:33 2023 +0800 Data share tests (#34563) commit 0d4aa79d8f015ced6e95d97eb983ce8711d3374f Author: Heath Stewart <[email protected]> Date: Fri May 5 10:23:58 2023 -0700 Change default MHSM location to France Central (#36020) Resolves #36007 commit 804b1d54aa0d29cccdc1bb2d30c91a9b388d1af1 Author: Azure SDK Bot <[email protected]> Date: Fri May 5 09:15:11 2023 -0700 Update Generator Version 3.0.0-beta.20230505.3 (#36051) commit 373954a5587eaca8443ebddc3b364f521865e6ec Author: Anne Thompson <[email protected]> Date: Fri May 5 08:25:04 2023 -0700 Remove DynamicData name mapping APIs (#36005) * Considering DynamicDataNameMapping * Remove name mapping APIs * pr fb commit ad49f21e14edff68ac1d25c21b0085e151ab6488 Author: Jocelyn <[email protected]> Date: Fri May 5 11:21:31 2023 -0400 Merge sync/async code paths (#36010) commit b6e493b7b96ca082da6cc20d307acc5561e369c0 Author: Azure SDK Bot <[email protected]> Date: Fri May 5 07:51:39 2023 -0700 Increment package version after release of Azure.ResourceManager.Qumulo (#36048) commit 193a26efd7528528c5ab0fc09ccac89e7a3741ae Author: David Watrous <[email protected]> Date: Fri May 5 09:50:57 2023 -0400 Update Azure Batch CODEOWNERS (#36047) commit db417dbba509a5bc3bf3f558008e95a0a61bb3fb Author: Azure SDK Bot <[email protected]> Date: Fri May 5 06:27:07 2023 -0700 Increment package version after release of Azure.ResourceManager.KeyVault (#36036) commit 14c10144c234562da9c77612bea7ebb35ed790ef Author: Azure SDK Bot <[email protected]> Date: Fri May 5 03:04:41 2023 -0700 Increment package version after release of Azure.ResourceManager.MachineLearning (#36038) commit 6559ee98bd76ccb4b725e9a984874c1143010867 Author: Arthur Ma <[email protected]> Date: Fri May 5 17:21:18 2023 +0800 Add missing properties to the PolicyAssignmentData (#36041) commit f0fd3d4960e7c487e4d9abbd112e8e86254621dd Author: Arthur Ma <[email protected]> Date: Fri May 5 17:19:27 2023 +0800 Update test case for EvenGrid Track 1 (#36031) commit 433a9c990908c008f48ea78700adc01f5e8042d0 Author: Nikhil Gupta <[email protected]> Date: Fri May 5 14:08:10 2023 +0530 Qumulo DotNet SDK stable version (#35830) commit 8cad60b69b8f31602c1bb1a5173dd83dc1e92218 Author: Chengming <[email protected]> Date: Fri May 5 14:02:54 2023 +0800 [KeyVault] Bump api-version to 2023-02 (#35482) * Add Secret operations * bump api-version * update record file api-version * Add secret test * update samples * remove referenced record of ServiceBus * remove reference record of ServiceLinker * remove reference record of EventHubs * resolve comments * update samples * update samples * update record file * re-record * Update ManagementRecordedTestBase.cs * revert test changes of other RPs * Revert "Update ManagementRecordedTestBase.cs" This reverts commit e50bc63dacec3e155b1be5c04708b76fd9f1fce7. * update service linker test * update * Update EventHubNamespaceTests.cs * Update ServiceBusTestBase.cs * re-record * Revert "re-record" This reverts commit 2772e0346a943a483a1445fe5105d95e5f3f544a. * revert * ignore some cases * update * CheckManagedHsmNameAvailabilityContent => ManagedHsmNameAvailabilityContent * Secret => KeyVaultSecret * update samples * update secret data * remove test case ignore attribute * Update CHANGELOG.md commit 788526482f5e2e2e9d5c29573fd17a7b3a40f5e4 Author: Dapeng Zhang <[email protected]> Date: Fri May 5 13:49:19 2023 +0800 Prepare release for Azure.ResourceManager.MachineLearning (#36033) * update changelog * prepare release for machinelearning commit f711921858e7fe42c0ecb326a814df3edc2f30ef Author: Azure SDK Bot <[email protected]> Date: Thu May 4 22:42:50 2023 -0700 Update AutoRest C# version to 3.0.0-beta.20230504.1 (#36032) * Update Generator Version 3.0.0-beta.20230504.1 * Update SDK codes --------- Co-authored-by: Arcturus Zhang <[email protected]> commit cc063c12fedf73194f8512ed5bc8aca65e22e630 Author: Azure SDK Bot <[email protected]> Date: Thu May 4 22:06:28 2023 -0700 Update AutoRest C# version to 3.0.0-beta.20230503.1 (#35984) * Update Generator Version 3.0.0-beta.20230503.1 * Update SDK codes commit 755eb560af35de2a560b5d561459f9801e3fed57 Author: Azure SDK Bot <[email protected]> Date: Thu May 4 20:51:15 2023 -0700 Increment package version after release of Azure.ResourceManager.PaloAltoNetworks.Ngfw (#36000) commit 44e61e999470cedf8950c0972c6d9ba0e66d9092 Author: Azure SDK Bot <[email protected]> Date: Thu May 4 20:50:40 2023 -0700 Increment package version after release of Azure.ResourceManager.ContainerInstance (#36028) commit ba0b88e7c5a04ab473be52dae06d5c876c6d43fc Author: Azure SDK Bot <[email protected]> Date: Thu May 4 20:43:46 2023 -0700 Increment package version after release of Azure.ResourceManager.SelfHelp (#35998) commit 74176dcad9e1dbccb14ae90fb0b4d6084fde2350 Author: JoshLove-msft <[email protected]> Date: Thu May 4 18:30:12 2023 -0700 Update minimum test version (#35978) * Update minimum test version * More updates * KV tests * oops * test guide commit 8abc28820a55aa8e6e772c77cfe79c7ef7de13dd Author: Azure SDK Bot <[email protected]> Date: Thu May 4 16:51:42 2023 -0700 Update azure-sdk-build-tools Repository Resource Refs in Yaml files (#35820) commit 116ccaf0116e3e351f8abdcdab2f1d99d82b16e3 Author: JoshLove-msft <[email protected]> Date: Thu May 4 15:27:57 2023 -0700 Improve DelayStrategy docs (#36008) commit 2175388a12091863fb4f38a83c486af56ee00cc3 Author: Azure SDK Bot <[email protected]> Date: Thu May 4 15:03:07 2023 -0700 Eng workflows sync and branch cleanup additions (#36012) Co-authored-by: James Suplizio <[email protected]> commit 1cbc3386807fbef5b67d306faaaa6507c1c729a1 Author: Madalyn Redding <[email protected]> Date: Thu May 4 12:32:39 2023 -0600 [Service Bus Extensions] Add MinMessageBatchSize and MaxWaitTime to options (#35877) * initial commit * progress * changes * additions * more updates * updates * bug fixes / improvements * test cleanup * various test updates * APIGEN * quick test fix * cleanup * doc updates / another test * changing some comments, changing leftover variable names with 'event' in it * Update sdk/servicebus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/src/Config/ServiceBusOptions.cs Co-authored-by: JoshLove-msft <[email protected]> * Update sdk/servicebus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/src/Config/ServiceBusOptions.cs Co-authored-by: JoshLove-msft <[email protected]> * feedback part 1 * Update sdk/servicebus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/src/Listeners/ServiceBusMessageManager.cs Co-authored-by: JoshLove-msft <[email protected]> * Update sdk/servicebus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/src/Listeners/ServiceBusMessageManager.cs Co-authored-by: JoshLove-msft <[email protected]> * feedback part 2 * something is wrong with my vs * missed a couple batch option references * WIP adding additional test * api gen * fix bug and add test * removing unnecessary cancel on linked cts and adding a bit better documentation in stopasync method --------- Co-authored-by: JoshLove-msft <[email protected]> commit 56e91f8ed137e215c575d7ab1f0db395f49c8d46 Author: sorrego-msft <[email protected]> Date: Thu May 4 13:49:46 2023 -0400 Remove if statement from tests that don't need it (#36003) commit 60929021e12e3527a2f7b14e6309ce1ea9359ae3 Author: Anne Thompson <[email protected]> Date: Thu May 4 10:13:29 2023 -0700 DynamicData array Length property (#35974) * Move DynamicData into Azure.Core.Dynamic namespace * Make DynamicDataProperty internal * fix bad merge * Add Length dynamic pseudo-property for arrays * Export API * tidy * Implement dynamic pseudo-propery Length * nit * pr fb commit f8ddb0aa373663d50a3f8fbbf07a00cb5a3dafda Author: Amanda Nguyen <[email protected]> Date: Thu May 4 09:39:12 2023 -0700 [DataMovement] Removed double JobPartEvent being added and updated all tests to track events raised (#35975) * Removed double JobPartEvent being added and updated all tests to track EventHandler * Disabled flakiness test checks for status events commit e755bece8296a9a925c3a8c9f38655229c253948 Author: Jocelyn <[email protected]> Date: Thu May 4 11:45:31 2023 -0400 OpenWrite Master CRC (#35955) * checkpoint * fixed conflicting checksums * removed pageblobwritestream custom writeinternal * fix some tests * recording * fixed test commit 166403856ba57d76b4079312e3414836cec64ffc Author: Jocelyn <[email protected]> Date: Thu May 4 11:23:46 2023 -0400 bug fix (#35967) commit 55637031ea3ae056c482d1f71ddf896b2a1673d9 Author: Dapeng Zhang <[email protected]> Date: Thu May 4 22:41:15 2023 +0800 prepare release for containerinstance (#35996) commit cde402565052243f133b6fca18baf157383332a1 Author: Chengming <[email protected]> Date: Thu May 4 22:29:56 2023 +0800 Remove KeyVault dependency for some RPs (#35989) commit c5e61ec67f1526c702ba38b6552541b4d1a4f6ce Author: Arthur Ma <[email protected]> Date: Thu May 4 22:24:34 2023 +0800 Prepare to release Azure.ResourceManager.PaloAltoNetworks.Ngfw (#35985) commit 7a5df05a1b0c29be5785752a55c52eb6dd0f99aa Author: mcgallan <[email protected]> Date: Thu May 4 21:25:03 2023 +0800 Azure.ResourceManager.SelfHelp Generated (#35684) * update * update * up * update * Update CHANGELOG.md * Create Azure.ResourceManager.SelfHelp.netstandard2.0.cs * Merge remote-tracking branch 'upstream/main' into Release_SelfHelp * update * update * fixed * update * update commit 8afcb0ca16fda8ae96fe533aac56724d4bd7f8c3 Author: Azure SDK Bot <[email protected]> Date: Thu May 4 04:09:59 2023 -0700 Increment package version after release of Azure.ResourceManager.AppService (#35994) commit b802c07a9f2bb723b9943477a6f371fb678d3574 Author: Azure SDK Bot <[email protected]> Date: Thu May 4 04:09:36 2023 -0700 Increment package version after release of Azure.ResourceManager.ContainerInstance (#35993) commit 6b1d42f3e5b4d2a792834d19e343c7b86f6f7f40 Author: Dapeng Zhang <[email protected]> Date: Thu May 4 18:04:21 2023 +0800 refine the samples (#35995) commit 792e34a172bb558f1caa7414a068608b441720aa Author: Azure SDK Bot <[email protected]> Date: Thu May 4 01:40:50 2023 -0700 Increment package version after release of Azure.ResourceManager.NewRelicObservability (#35988) commit 1887e1f022c4c5af4ea43c670850df2cbf91f093 Author: vipray-ms <[email protected]> Date: Thu May 4 12:12:41 2023 +0530 Fixing Namespace for NewRelic (#35937) commit a5a4ed21c5a5352422f16bef7b10504b26d607cd Author: Asaf Levi <[email protected]> Date: Thu May 4 09:10:07 2023 +0300 fix: test-resources.json kind (#35750) * fix: test-resources.json kind * add 'Location' parameter to tests pipeline commit 8cf8b561a815ae567b26fe7d4473589d3da06674 Author: fnuarnav <[email protected]> Date: Wed May 3 22:53:05 2023 -0700 Containerinstance 2023 05 01 ga (#35715) * initial code gen for api-version 2023-05-01 * update tests and recordings * record tests without managed identity * updated changelog * run Export-API.ps1 * version name for CI test * remov empty sections from change logs * Run all tests against ACI Test Automation Subscription, and prod location (westus) * resolve issues --------- Co-authored-by: ArcturusZhang <[email protected]> commit 9d94f053ac782a32ec602366e25389de108c706f Author: Anne Thompson <[email protected]> Date: Wed May 3 15:08:42 2023 -0700 Hide DynamicDataProperty (#35970) * Move DynamicData into Azure.Core.Dynamic namespace * Make DynamicDataProperty internal * fix bad merge * Export API * tidy commit 7971fd981868c01d2000466133ab59b23788f046 Author: Jesse Squire <[email protected]> Date: Wed May 3 16:53:10 2023 -0400 [Service Bus] Fixing typo in client options (#35958) * [Service Bus] Fixing typo in client options Fixing a typo in the doc comments left over from my shameless copy/paste. * Update sdk/servicebus/Azure.Messaging.ServiceBus/src/Client/ServiceBusClientOptions.cs * Update sdk/servicebus/Azure.Messaging.ServiceBus/src/Client/ServiceBusClientOptions.cs commit 8e1c73787f57a0bd994820fbafaa59a65150aa9b Author: Anne Thompson <[email protected]> Date: Wed May 3 12:39:30 2023 -0700 Move DynamicData into Azure.Core.Dynamic namespace (#35961) * Move DynamicData into Azure.Core.Dynamic namespace * fix bad merge commit ed2abc6ed3f41efaf220cf42d1ac95872cd6e64b Author: Azure SDK Bot <[email protected]> Date: Wed May 3 11:53:34 2023 -0700 pass along the artifact name so we can override it later (#35960) Co-authored-by: scbedd <[email protected]> commit c3fc409b1baabfdf936e5084848e8d5258b7f22a Author: Anne Thompson <[email protected]> Date: Wed May 3 11:46:33 2023 -0700 Update Azure.Core docs for dynamic JSON (#34001) * Initial work on DynamicJson docs * add samples for docs * Add DynamicContent.md * Add links from response and protocol method samples * nits * pr fb * Update and add samples * pr fb * Update samples * pr fb * pr fb * fix link compliance * pr fb * pr fb * port samples to latest * Add sample cases * nits * Simplify sample code * More samples updates * pr fb * Let DynamicDataOptions.Default specify case-insensitive serialization options. * sample feedback from arch board * fix merge conflict * pr fb commit d10b50b52be6a61fbd17b594672540542682a8f6 Author: JoshLove-msft <[email protected]> Date: Wed May 3 10:52:51 2023 -0700 Add Response to RequestFailedException (#35716) * Add Response property to RequestFailedException * Use ctor * Fix tests * Use a method * change log * Fix tests * Update search * KeyVault * Update more libraries * API * Fix SB * Update doc translation to use new constructor * Fix tests * Use RequestFailedDetailsParser * Add and * fix commit f40976e9395a52a24ef4ccd73c37f2e7a993604c Author: wangrui-msft <[email protected]> Date: Wed May 3 10:01:46 2023 -0700 Add updated channel affinity (#35940) commit 66946a9764d1b10b28bf6acb4a81c8a99f347b50 Author: Vishwesh Bankwar <[email protected]> Date: Wed May 3 09:41:47 2023 -0700 Add tests.yml for OpenTelemetry.AspNetCore (#35957) commit 3b158898bde8e918057168192acc745705f14deb Author: Sean McCullough <[email protected]> Date: Wed May 3 11:26:22 2023 -0500 Updated files swagger (#35945) commit f9be46c221cdcafda39aad3ea23cf60d90792bf5 Author: m-nash <[email protected]> Date: Wed May 3 09:17:10 2023 -0700 update broken link (#35956) commit 592b7ef06cb8a93e00830d95c6d88da02df16580 Author: Juntu Chen <[email protected]> Date: Tue May 2 22:46:30 2023 -0400 Juntuchen/bug fixing (#35928) * fixed bug * changed the constructor * updated tests * updated api file commit cd3dec5ef822a9f8701a7ec1b6b93a2de34f4f54 Author: Caio Saldanha <[email protected]> Date: Tue May 2 17:51:07 2023 -0700 [FormRecognizer] Document model administration tests cleanup (2/2) (#35908) commit 1bacb6cef7ae2d8767d494d9599f0c04e1f84461 Author: Rajkumar Rangaraj <[email protected]> Date: Tue May 2 14:08:21 2023 -0700 [AzureMonitorExporter] Add tests to cover Azure Namespace (#35941) * Add tests to cover Azure Namespace * Rename HasAzureNameSpace commit 559d483a73b031c016ef6bf3295f3e6d95452650 Author: minnieliu <[email protected]> Date: Tue May 2 13:03:46 2023 -0700 Add tentative release date for .Net Rooms SDK (#35943) * Add tentative release date for .Net Rooms SDK * Update changelog --------- Co-authored-by: Minnie Liu <[email protected]> commit e07f1f6c627f1aebc139d9c7f83ec8840096eca1 Author: Anne Thompson <[email protected]> Date: Tue May 2 12:15:09 2023 -0700 Fix bug when serializing DynamicData in net461 (#35930) * Fix bug in serialization of DynamicData * test nit * pr fb * Clean up to address PR FB commit 126d3536d115a133613e0208cb2bee87cdfdcc0f Author: Sean McCullough <[email protected]> Date: Tue May 2 13:57:16 2023 -0500 Storage STG 88 (#35837) commit 0e927579dfecdf781cf95338d38b60e5ee11795b Author: Jesse Squire <[email protected]> Date: Tue May 2 14:18:07 2023 -0400 [Service Bus] Connection Idle Timeout (#35920) * [Service Bus] Connection Idle Timeout The focus of these changes is to add an option to the ServiceBusClient to customize the idle timeout. Previously, this was a hard-coded value of 60 seconds; that value has been preserved as the default. * Regeneration of API surface * Updating change log commit 093653359032784969cb61b7b89c07d36abf9d5b Author: Fang Chen - Microsoft <[email protected]> Date: Tue May 2 11:10:16 2023 -0700 Remove SourceCallerIdNumber from Transfer API (#35927) * remove SourceCallerId from Transfer API * add simple method and fix unit test * update public api * add description commit 1c7133563c89e2487a6198ce3d1d40e88ba8e79a Author: Rajkumar Rangaraj <[email protected]> Date: Tue May 2 09:37:13 2023 -0700 [AzureMonitorExporter] Handle Azure Namespace / Refactor (#35934) * Handle Azure Namespace. * PR feedback commit 15c542e45e3405fdd3bbd2fe356190543b32ca72 Author: JoshLove-msft <[email protected]> Date: Tue May 2 09:34:08 2023 -0700 Fix build solution in VS (#35933) commit 4d921ae323f69e6e04dbc8a641e5c874aa10171f Author: Azure SDK Bot <[email protected]> Date: Mon May 1 16:04:01 2023 -0700 Update AutoRest C# version to 3.0.0-beta.20230501.3 (#35929) * Update Generator Version 3.0.0-beta.20230501.3 * Update SDK codes * Update SDK codes * Update SDK codes * Update SDK codes * Update SDK codes * Update SDK codes * Update SDK codes commit 498f3b3d46cbf6b0df51c88cbe8ae3f31f672dce Author: Azure SDK Bot <[email protected]> Date: Mon May 1 14:25:50 2023 -0700 Increment package version after release of Azure.Monitor.Query (#35925) commit 103ac3e5869371b53e5beffb4cfe14170fc506e3 Author: Azure SDK Bot <[email protected]> Date: Mon May 1 13:09:05 2023 -0700 Update AutoRest C# version to 3.0.0-beta.20230501.2 (#35918) * Update Generator Version 3.0.0-beta.20230501.2 * Update SDK codes * Update SDK codes * Update SDK codes * Update SDK codes * Update SDK codes * Update SDK codes * Update SDK codes commit a0831a1525c05019165df113937436996e370a29 Author: Azure SDK Bot <[email protected]> Date: Mon May 1 12:52:21 2023 -0700 Sync eng/common directory with azure-sdk-tools for PR 6063 (#35886) * update proxy version * bump target version where it is actually consumed --------- Co-authored-by: Scott Beddall <[email protected]> Co-authored-by: scbedd <[email protected]> commit 9181b3b1c831da393111242f36163705c266f992 Author: nisha-bhatia <[email protected]> Date: Mon May 1 12:23:02 2023 -0700 update date (#35923) commit 460363f233c128f02bd2748eaabac9e90ad56c02 Author: Amanda Nguyen <[email protected]> Date: Mon May 1 09:18:48 2023 -0700 [DataMovement] [Tests] Using DisposingLocalDirectory across all DataMovement tests where applicable (#35907) * Use DisposingLocalDirectory where needed; Fixes to 0 byte transfer tests * Rerecorded tests, seed change commit 57f854e7c7be0bb23d7da8b9ccd5062cc91daf71 Author: Raviraj <[email protected]> Date: Mon May 1 10:18:28 2023 -0400 [Issue - 32542] Updating snippets in SchemaRegistry (#35912) Co-authored-by: Raviraj Nallasivam <[email protected]> commit 4d19e4b76e2685fcc21c6e720dfa0607dd5671e6 Author: Timothy Mothra <[email protected]> Date: Fri Apr 28 15:38:48 2023 -0700 [AzureMonitorDistro] Integration Tests for Distro (#35782) * wip. refactoring existing test * metrics working * add logs example * new class, need to convert to WebAppBuilder * semi-working poc. * extra helper classes * saving wip * saving wip * fix AppRoleName for logs * remove first draft * cleanup * cleanup * cleanup * cleanup * add readme * readme scaffold * update readme * update * update * remove hardcoded test mode * update readme * update readme * investigating Linux test failure * testing fix * revert change * update to use a different localhost port * cleanup * addressing code review comments * cleanup * rename TestEnvironment class commit 239ede1a89f2d78968313501a5f729af6b7774ea Author: nisha-bhatia <[email protected]> Date: Fri Apr 28 15:09:26 2023 -0700 [Azure.Monitor.Query] add Parse ResourceIdentifier check (#35850) commit 06dbd66a6a8677a17d7ea69ea820177b6324251c Author: Caio Saldanha <[email protected]> Date: Fri Apr 28 13:44:34 2023 -0700 [FormRecognizer] Fixing test issues (#35883) commit 67533ae00312a4042d48be034966e07c70936cbc Author: Heath Stewart <[email protected]> Date: Fri Apr 28 07:35:29 2023 -0700 Remove CA1825 suppression (#35885) Now that #35376 is merged and includes the fix to dotnet/roslyn analyzers, we can remove the suppression in lieu of Azure/autorest.csharp#3262. commit 6a03e431f882a894a19249023f12d1565b094d78 Author: JialinXin <[email protected]> Date: Fri Apr 28 22:14:08 2023 +0800 [WebPubSub] Ready for beta release. (#35862) * Ready for beta release. * Update sdk/webpubsub/Microsoft.Azure.Functions.Worker.Extensions.WebPubSub/CHANGELOG.md Co-authored-by: Jesse Squire <[email protected]> * Update README.md Add `--prerelease` --------- Co-authored-by: Jesse Squire <[email protected]> commit a9e0583af12d75c4b9254b6d739c4ac98373590d Author: Azure SDK Bot <[email protected]> Date: Fri Apr 28 07:11:53 2023 -0700 Increment version for storage releases (#35889) * Increment package version after release of Microsoft.Azure.WebJobs.Extensions.Storage.Queues * Increment package version after release of Microsoft.Azure.WebJobs.Extensions.Storage.Blobs * Increment package version after release of Microsoft.Azure.WebJobs.Extensions.Storage commit 5394903eee0a68aa7929947bee72af59b848bb2f Author: Azure SDK Bot <[email protected]> Date: Fri Apr 28 07:11:36 2023 -0700 Increment package version after release of Azure.ResourceManager.Network (#35896) commit c0bd13f58c92c045364d42cd1a57a9b3c16c986b Author: vipray-ms <[email protected]> Date: Fri Apr 28 14:42:34 2023 +0530 adding newrelic dotnet sdk [Public Preview] (#35754) commit 2b305b25b7ea70b8ae0510ae7c0ef7540f4753ef Author: Sean McCullough <[email protected]> Date: Thu Apr 27 19:17:53 2023 -0500 Storage WebJob Extensions patch release prep (#35825) commit 85bbe7a38f67e0c8b9d3d59643d933b644a2802e Author: Heath Stewart <[email protected]> Date: Thu Apr 27 15:37:11 2023 -0700 Add CertificateProperties.X509ThumbprintString (#35882) Resolves #35878 commit 66b4716ff68709115f13414344f85a4f022af446 Author: James Suplizio <[email protected]> Date: Thu Apr 27 14:49:06 2023 -0700 Add task to verify json files contain required members after ToC generation (#35875) * Add task to verify json files contain required members after ToC generation * Verification call needs to be after both Update-DocsMsToc.ps1 calls commit 5a7a3b708a53f7996afa668392cc06efb43e56c1 Author: Jocelyn <[email protected]> Date: Thu Apr 27 17:13:45 2023 -0400 Caller suppled CRC PartitionedUpload (#35872) * caller-provided crc partitioned upload * one-shot uses caller-provided crc * updated tests to accomodate file share lack of crc support commit f92f55678ba40c68bb7af1831bec0bdb87b90bcf Author: Heath Stewart <[email protected]> Date: Thu Apr 27 13:49:45 2023 -0700 Fix Key Vault's ShareLink sample (#35876) commit a2bd36ba8c2385328921de16311dd3001e1fc0a8 Author: Azure SDK Bot <[email protected]> Date: Thu Apr 27 13:18:15 2023 -0700 Increment version for storage releases (#35873) * Increment package version after release of Azure.Storage.DataMovement * Increment package version after release of Azure.Storage.DataMovement.Blobs commit 85e3a004abc4c18179beb68d10b10dc67cac8441 Author: Anne Thompson <[email protected]> Date: Thu Apr 27 12:50:14 2023 -0700 Add RequestContent.Create() overload for DynamicData (#35852) * Add RequestContent.Create() overload for DynamicData * Export API * pr fb * Don't allocate a stream * pr fb: add usings commit 4b99bb4f981f524f4c13235a32c4f452c7068db0 Author: Azure SDK Bot <[email protected]> Date: Thu Apr 27 12:41:36 2023 -0700 Increment package version after release of Azure.ResourceManager (#35869) commit 567bf841eee83448eb1960c74b98edc56ac1bb35 Author: Christopher Scott <[email protected]> Date: Thu Apr 27 12:17:37 2023 -0500 implement ManagedIdentityRequestFailedDetailsParser (#35867) commit 9a651218bea808bfa046705b02ed1fb2ea625969 Author: Amanda Nguyen <[email protected]> Date: Thu Apr 27 10:15:05 2023 -0700 Adding Azure.Storage.Common to Package Dependencies and changing DMLib to use package dependencies (#35853) * Adding Azure.Storage.Common to Package Dependencies and changing DataMovement to use package ref instead of project ref * Convert tab to spaces commit b538d1dd9fe1ea0bdb294cc622afa64e8e889fe9 Author: Azure SDK Bot <[email protected]> Date: Thu Apr 27 09:29:55 2023 -0700 Update AutoRest C# version to 3.0.0-beta.20230427.2 (#35870) * Update Generator Version 3.0.0-beta.20230427.2 * Update SDK codes f*,g*,h*,i*,j*,k*,l* * Update SDK codes p*,q*,r* * Update SDK codes m*,n*,o* * Update SDK codes s*,t*,u* * Update SDK codes a*,b*,c* * polish all the new APIs --------- Co-authored-by: Arcturus Zhang <[email protected]> commit 1f2120dae731f9383bd0cc19ac499d0fbe1b82b8 Author: minnieliu <[email protected]> Date: Thu Apr 27 09:25:23 2023 -0700 Introducing Rooms .Net SDK GA Candidate (#35114) * Introducing Rooms .Net SDK GA Candidate * Export-Api update * Rename private function * Address comments in API view * Update change log * Add test recordings * Add null role tests * Fix test sanitization * Fix test timestamp * Make participants in createRoom optional * Make participants in createRoom optional * small fix * Address comments and fix export api * Address comments * Update readme * Add next steps link * Remove InvitedRoomParticipants and update RoomParticipants * Fix build pipeline * Address feedback from SDK arch board * Do not use vars in samples * make update participant properties non-optional * Update changelog * Regenerate rest clients * Address PR comments --------- Co-authored-by: Minnie Liu <[email protected]> commit 547d1987f67f355205ff0a07efb3a0d15cd2397a Author: Dapeng Zhang <[email protected]> Date: Thu Apr 27 22:53:57 2023 +0800 fix another one (#35865) commit 035c972f491a88ae416042e0d9b2d2f3986af679 Author: Dapeng Zhang <[email protected]> Date: Thu Apr 27 22:10:38 2023 +0800 Bump version of policy (#35038) commit dbb1ff232e833412f97d6e0e66bb649e3cc0da93 Author: williamzhao87 <[email protected]> Date: Thu Apr 27 09:49:29 2023 -0400 Fix classification policy cannot delete selectors + cleanup (#35854) commit 9db1f21d9e5954e3e6fdd5b14d0a14d4962142d0 Author: Dapeng Zhang <[email protected]> Date: Thu Apr 27 17:52:32 2023 +0800 skip those problematic sample operations (#35860) commit ce2db0848e4d544451f044fe15f9657a8fd25ce1 Author: Azure SDK Bot <[email protected]> Date: Thu Apr 27 01:47:04 2023 -0700 Increment package version after release of Azure.ResourceManager.CosmosDB (#35861) commit e8c40cc204b8cf750fcc820eab90d11f80612c3a Author: JialinXin <[email protected]> Date: Thu Apr 27 11:03:58 2023 +0800 [WebPubSub]Add isolated-process extension for WebPubSub (#34618) * Add isolated-process extension for WebPubSub * clean changelog * export API. * fix changelog. * uniform version. * update README and minor fixes. * property fix. * re-factor samples * Add allowed product slug and link fix. * minor description fix. * fix link * Revert eng changes, need separate PR. * Fix cached name would be mixed in the same function. * update sample products tag. * Support polymorphic serialization in output. * Sync to latest extension version. * update sample * Sync sample to fix CI. commit 9164bfd981d3f967bcab8bb542ba2cfff64c111c Author: htippanaboya <[email protected]> Date: Wed Apr 26 19:35:01 2023 -0400 Generating .NET Track2 sdk FOR NETWORK (#34959) commit 6b18d745cc3d09529b8323b648feaab37fb613d7 Author: Heath Stewart <[email protected]> Date: Wed Apr 26 16:15:49 2023 -0700 Run MHSM tests weekly, disable attestation in Canary (#35770) * Only run Managed HSM weekly * Disable attestation testing in Canary * Replace matrix configuration Thanks to @benbp for help figuring this out. * Use correct key/value separator Mixing too much JSON and PowerShell. 🤦♂️ * Add condition to Microsoft.Web/sites resource commit 3bd56e0e0b1d4d1ad16549cebfa5c49cc84ee361 Author: Anne Thompson <[email protected]> Date: Wed Apr 26 15:57:29 2023 -0700 Move DynamicData into Azure.Core package (#35777) * Move DynamicData type to Azure.Core package * Move tests from experimental to core * Export APIs * Updates to CLU tests to pick up DynamicData from Azure.Core * Remove public tests from Azure.Core.Tests and Experimental benchmark projects from sln * Update experimental benchmark project so it builds * Add DynamicDataOptions.Default * Don't return null from ToString() * exception message formatting nits * Change name of options property to match name of enum * Missed file in rename * pr fb: binary data extensions commit 6d292ffd915978de6d6a326ef0de3156e2820feb Author: Sourabh Jain <[email protected]> Date: Thu Apr 27 03:53:05 2023 +0530 Diagnostic Scope improvements (#35371) * first draft * made changes for parent based samplimg * test fix * set switch false * fixed tests * fix storage test * addded more tests * remove override * opene telemetry version * add diagnostic flag checks * code refcatoring * changed approach * fix tests commit 5c2ead4a82c4081d78b9cedc79f23931385a2deb Author: Amanda Nguyen <[email protected]> Date: Wed Apr 26 14:55:14 2023 -0700 Prepare for DataMovement Release Preview 2 (#35849) * Prepare for Storage DataMovement library release * Update base datamovement changelog commit 2dd0ec953d21064cedcd04261cf9b7a5c6ae9535 Author: nisha-bhatia <[email protected]> Date: Wed Apr 26 14:26:57 2023 -0700 [Azure.Monitor.Query] Add QueryResource (#35385) commit 9cf66eea5e0687a48523f215554af7ea45aee9de Author: Amanda Nguyen <[email protected]> Date: Wed Apr 26 14:21:10 2023 -0700 [DataMovement] [Storage] Change Default CreateMode from Overwrite to Fail on existing destination resource (#35765) * Changed the default StorageResourceCreateMode to default to failing instead of overwriting * ExportAPI * Update overwrite directory test to actually pass the overwrite options bag commit 6978602a2754e169345431d3efd91db8fbad4e70 Author: Sean McCullough <[email protected]> Date: Wed Apr 26 15:41:01 2023 -0500 Updated Azure.Storage.Blobs and *.Queues versions in Packages.Data.props (#35841) commit fe3935fac1b5c66a73d175eae2fa482e0f7ac9fe Author: Azure SDK Bot <[email protected]> Date: Wed Apr 26 13:28:47 2023 -0700 Update Generator Version 3.0.0-beta.20230426.2 (#35843) commit 4d705cb5f35f8316894ea04bd9374913d2dc71fb Author: Jocelyn <[email protected]> Date: Wed Apr 26 16:16:08 2023 -0400 partitioned upload calculates master crc and compares to composed crc (#35839) commit a21152fea20cb8348341b5e44eb87586813ccb3c Author: Jocelyn <[email protected]> Date: Wed Apr 26 14:25:58 2023 -0400 Partitioned download checksumming (#35731) * partitioned downloader validates checksums itself * convert assertion to mock setup * error commit ca66b870ad39ffdd7d04ceba7c3d180ffc9302da Author: Caio Saldanha <[email protected]> Date: Wed Apr 26 11:13:33 2023 -0700 [FormRecognizer] Updating ExpiresOn validation due to service bug (#35810) commit 2a7d07174b57c528d83b7ec06373f34cc69e0712 Author: Amanda Nguyen <[email protected]> Date: Wed Apr 26 10:57:50 2023 -0700 [DataMovement] [Storage] Add verification for matching Source, Destination and CreateMode when Resuming (#35766) * WIP * Add verification for mismatch source, destination, and overwrite-enabling/createmode when resuming commit 4df31d7eaf70221b1fabe48443259416662d7691 Author: Amanda Nguyen <[email protected]> Date: Wed Apr 26 10:07:59 2023 -0700 Updated DataMovement Blobs changelog to include extension methods (#35805) commit a2f9f112eeea92a9816fcf05ce45f229fbf14edd Author: wangrui-msft <[email protected]> Date: Wed Apr 26 09:37:21 2023 -0700 fix event data naming (#35774) * fix event data naming fixed items: 1. L160 Adopt EG convetion of using a common EventData suffix 2. L171 and L172 Rename event processor properties * update live test commit f98064f15f54d8939e1b8cff444d025cb241ae5a Author: Jesse Squire <[email protected]> Date: Wed Apr 26 11:42:30 2023 -0400 [Event Hubs] Fix management README (#35838) The focus of these changes is to fix invalid links in the management README. commit 018c43645ec986be617730dd5c4a097427d0e693 Author: Arthur Ma <[email protected]> Date: Wed Apr 26 22:46:16 2023 +0800 Fix Network dependency for some RPs to unblock Network release (#35831) commit 60b084ffef10ec8e8097852aa5db55e2b292e889 Author: Azure SDK Bot <[email protected]> Date: Wed Apr 26 06:23:40 2023 -0700 Increment package version after release of Azure.ResourceManager.DataProtectionBackup (#35833) commit 169daa5012300e190c18383a9832ef80dbb314ce Author: ddhamotharan <[email protected]> Date: Wed Apr 26 02:55:06 2023 -0700 [CosmosDB] Introduce new features from latest swagger 11-15-Preview and add test coverage (#34743) * generated code using autorest * fix mongo collection functions in Custom/RestorableCosmosDBAccountResource.cs * Fix breaking changes that coming from the safeflatten * InAccount restore changes for all api kinds * resolve build errors and update mongo db inaccount restore tests * update session records * resolve build errors after merge conflicts * regenerated changes using dotnet build /t:GenerateCode * update default values * fix test with default identity * updated with eng\scripts\CodeChecks.ps1 -ServiceDirectory cosmosdb * update sesion records for failing pipeline * update sesion records for failing pipeline * update inaccount restore tests to use static time and session records for table and gremlin tests * Update recording * Update recording * update session records for sql and mongo and disable mongo inaccount restore tests * update generated files with latest * updated test case for burst capacity * update session records for database account operations * updated test case to not enable burst capacity in account creation (#2) * recorded all tests in DatabaseAccount (#3) * updated test case to not enable burst capacity in account creation * recorded all tests in DatabaseAccount * session recordings of DatabaseAccountTests * cross region restore updated test * test recordings update * updated recordings * added new group cross region restore * udpated recordings with playback verification * updated RestorabledatabaseAccountTests groupo * update session records for private end point tests * Rename BackupResource to CassandraClusterBackupResource * Update API * update changelog for new sdk release --------- Co-authored-by: Arthur Ma <[email protected]> Co-authored-by: Wei Hu <[email protected]> Co-authored-by: Richa Sharma <[email protected]> Co-authored-by: Richa Sharma <[email protected]> Co-authored-by: dsapaliga <[email protected]> commit dd90afeaa7880e8dabbac8b447b3f516f26f2b7c Author: Azure SDK Bot <[email protected]> Date: Wed Apr 26 01:31:00 2023 -0700 Update Generator Version 3.0.0-beta.20230425.3 (#35832) commit fbd045fd853edd9eb59def2b6f4c8d506cd822f1 Author: Minghao Chen <[email protected]> Date: Wed Apr 26 13:55:42 2023 +0800 Update to release (#35826) commit 3915ee91d3513d9d07efe9974a5f837b79709681 Author: Azure SDK Bot <[email protected]> Date: Tue Apr 25 20:15:00 2023 -0700 Update Generator Version 3.0.0-beta.20230425.2 (#35821) commit 76919ecafdbdde7314d4e30f12b64e9f8805016a Author: Crystal YU <[email protected]> Date: Wed Apr 26 09:28:08 2023 +0800 Register new mgmt sdk to core client (#35722) * typespec renaming for unified pipeline * register mgmt sdk to mgmt core client * add test * use for instead of foreach * normalize the path * remove unused code * share the common function to remove duplicate commit 1aad75bd5889b95944a596fecf655bfc2b096529 Author: Azure SDK Bot <[email protected]> Date: Tue Apr 25 15:26:15 2023 -0700 Add script to verify that our docs metadata json files. (#35815) Co-authored-by: James Suplizio <[email protected]> commit a75ecb2e005e9989deeff2dd338e7f8b7eb5d333 Author: Azure SDK Bot <[email protected]> Date: Tue Apr 25 14:35:18 2023 -0700 Update AutoRest C# version to 3.0.0-beta.20230425.1 (#35808) * Update Generator Version 3.0.0-beta.20230425.1 * Update SDK codes f*,g*,h*,i*,j*,k*,l* * Update SDK codes p*,q*,r* * Update SDK codes d*,e* * Update SDK codes m*,n*,o* * Update SDK codes s*,t*,u* * Update SDK codes a*,b*,c* commit 190fa2634930835272a66b78d11b6e21488a098d Author: hemarina <[email protected]> Date: Tue Apr 25 13:54:31 2023 -0700 update to azd auth login (#35779) commit beee8463ff92948c14a311203710821d5ce4ea91 Author: Caio Saldanha <[email protected]> Date: Tue Apr 25 13:05:26 2023 -0700 [FormRecognizer] Document model administration tests cleanup (#35747) commit de248c02e1535ed0f5929474d1676ee25d4dae37 Author: wangrui-msft <[email protected]> Date: Tue Apr 25 11:30:10 2023 -0700 fix speechresult type and endsilence timeout (#35803) * fix speechresult type * change endsilence to timespan and put to optional construct commit 6e4309b28b1b31c30dca68f5c12959816d40cb94 Author: Christopher Scott <[email protected]> Date: Tue Apr 25 10:01:12 2023 -0500 Implement arch board feedback (#35661) * Implement arch board feedback for Identity commit b7869bcf73e34d2b1ccde4d1680910213aef82ea Author: Azure SDK Bot <[email protected]> Date: Tue Apr 25 06:47:03 2023 -0700 Increment package version after release of Azure.ResourceManager.Workloads (#35796) commit 3d4eb3e7d570e43255184412310bcdac87f5cf29 Author: Azure SDK Bot <[email protected]> Date: Tue Apr 25 01:33:31 2023 -0700 Use overload for convenience method and protocol method (#35724) * Update Generator Version 3.0.0-alpha.20230421.3 * Update SDK codes s*,t*,u* * Update SDK codes a*,b*,c* * Update * Update * Update * Update * Update --------- Co-authored-by: pshao25 <[email protected]> commit d8f857dfbd817a507707c80b3fb2ab4cea925bbd Author: Minghao Chen <[email protected]> Date: Tue Apr 25 14:40:55 2023 +0800 [DataProtectionBackup] Change ResourceUri type in DataSourceInfo and DataSourceSetInfo class (#35627) * Change resource type * Fix pipeline * Update CHANGELOG.md * Update to fix comment * Remove useless code * Update to fix comments * Update BackupVaultTests.cs commit 766f0f4a09f5af97a7bbba543e94aa349d14fcc0 Author: Wei Hu <[email protected]> Date: Tue Apr 25 14:36:38 2023 +0800 Polish Azure.ResourceManager.Workloads for first stable release (#35657) * WIP * update * update * update samples * update installation to stable * Update version in csproj * Address comments * Revert type IPAddress to string commit eafc883c8eadb080fc2014d1f7edd6deec877522 Author: Azure SDK Bot <[email protected]> Date: Mon Apr 24 22:42:23 2023 -0700 Update Generator Version 3.0.0-beta.20230424.5 (#35789) commit 9d298bdce7dc6cf9808cc804062008e9ef14cebf Author: Azure SDK Bot <[email protected]> Date: Mon Apr 24 19:04:02 2023 -0700 Update AutoRest C# version to 3.0.0-beta.20230424.4 (#35784) * Update Generator Version 3.0.0-beta.20230424.4 * Update SDK codes f*,g*,h*,i*,j*,k*,l* * Update SDK codes m*,n*,o* * Update SDK codes s*,t*,u* * Update SDK codes a*,b*,c* commit 673528ae5447553e01c97cf5b8e3a3e2acc1d8bb Author: Scott Schaab <[email protected]> Date: Mon Apr 24 16:37:22 2023 -0700 Adding BlobContainerClient data movement extensions (#35382) * Adding BlobContainerClient data movement extensions * xml comments * fb * adding extension tests * update snippets * export api commit 96119cfc0d76bdd5ae99afe598e5b57e872f7cd0 Author: Jocelyn <[email protected]> Date: Mon Apr 24 15:02:26 2023 -0400 composer helper and composition tests (#35767) commit b1ee6c99c97e1730026f5c5d8e2f2cff0e4abdb9 Author: JoshLove-msft <[email protected]> Date: Mon Apr 24 11:32:39 2023 -0700 Prototype making DelayStrategy public (#33040) * Prototype making DelayStrategy public * Remove Delay property from ClientOptions * Rename suggestedInterval to suggestedDelay * Add exponential/fixed implementations * Remove shared strategies * Fix nullability * rename to delayHint * Remove internal modifier from GetServerDelay * PR fb * DelayHint * Regenerate API * PR fb * RetryPolicy public * PR fb * Add factor parameter * Remove ctor * Add GetNextDelayCore * Add GetNextDelay to retry policy * context bag * Add protected property and method to RetryPolicy * Get tests to build * Get tests to pass * pr fb * rename to Delay to avoid collision with old class that needs to be added back * Add back old strategies temporarily * rename * back compat * temp refactor to avoid ambiguous calls * Remove context * Add overload * snippets * sync * snippets * rename * api review feedback * Update to use public DelayStrategy * Remove project ref * back compat * regen * remove shared file refs * Update maps * remove extra includes * Remove Argument.cs * revert gen changes * remove includes * cref issue * revert * Temporarily disable test * Fix tests * revert temp changes * Fix ref docs * Update KV operations * Add ref docs to internal delay strategies * More custom LROs * more custom LROs * Communication LROs * confidential ledger commit 02800a3c01b6f7951345ac4a9c85c096c3282c82 Author: Anne Thompson <[email protected]> Date: Mon Apr 24 11:29:30 2023 -0700 Add Equals to DynamicData (#35733) * Implement equality * Update API and a few more tests * Remove * Add TryGetXx to MJE to prevent exceptions thrown from Equals * Update tests to show intended use of == for nullable value types. * Updates to docs per pr fb * pr fb commit 5146c895ca07c0dfec55b247ece14c0148e0a95d Author: Azure SDK Bot <[email protected]> Date: Mon Apr 24 11:25:11 2023 -0700 Update azure-sdk-build-tools Repository Resource Refs in Yaml files (#35743) commit b6c723c6ad9b5f4b183a05654283d81886df243c Author: Anne Thompson <[email protected]> Date: Mon Apr 24 09:27:19 2023 -0700 Bug fix and small perf improvement to MJD WriteTo() (#35744) * Bug fix and small perf improvement to MJD WriteTo() * more perf * pr fb commit 42e0234448cbf114e2db8333b1ccfac337a0e3ac Author: James Suplizio <[email protected]> Date: Mon Apr 24 08:02:26 2023 -0700 Update event processor version and remove the sparse-checkout (#35748) * Update event processor version and remove the sparse-checkout * Return ref in build section back to its original state. commit 0776b4c93e1265ed63e6e397763bf84bc1697d20 Author: Azure SDK Bot <[email protected]> Date: Mon Apr 24 04:12:29 2023 -0700 Increment package version after release of Azure.ResourceManager.Monitor (#35756) co…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a few outstanding issues in #33856
Addresses #33856