Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asaflevi/fix/nuget references #35347

Merged
merged 5 commits into from
Apr 17, 2023

Conversation

asaflevi-ms
Copy link
Member

@asaflevi-ms asaflevi-ms commented Apr 4, 2023

update nuget links in readme files.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@asaflevi-ms
Copy link
Member Author

@pallavit , @chunyu3
Can one of you approve and merge this one?
I just updated links to our nuget packages.

@pallavit
Copy link
Contributor

pallavit commented Apr 5, 2023

@asaflevi-ms thank you for fixing these. Could you please also add the SDK to the codeowners alias file - https://github.com/Azure/azure-sdk-for-net/blob/main/.github/CODEOWNERS. We usually add two people from the team (primary, secondary).

@pallavit
Copy link
Contributor

@chunyu3, @asaflevi-ms please let me know if you have any comments before I merge.

@asaflevi-ms
Copy link
Member Author

asaflevi-ms commented Apr 17, 2023

Hi @pallavit
I updated the codeowners file.
Please review and let me know if I did it correctly.
If it's ok, you may merge the changes, no other comments.

@pallavit pallavit merged commit 67ab02d into Azure:main Apr 17, 2023
@pallavit
Copy link
Contributor

Done.

@asaflevi-ms asaflevi-ms deleted the asaflevi/fix/nuget-references branch April 18, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants