Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Non-OCI Manifests #33663

Merged
merged 13 commits into from
Jan 31, 2023
Merged

Support Non-OCI Manifests #33663

merged 13 commits into from
Jan 31, 2023

Conversation

annelo-msft
Copy link
Member

This PR makes modifications to the Manifest APIs to accomplish the following:

  • Caller can specify the manifest media type in the UploadManifest() operation.
  • Caller can request a specific media type for a manifest in the DownloadManifest() operation.
  • Let caller lazily deserialize the manifest based on the known media type
  • Remove base ArtifactManifest type (which didn't contribute much) to simplify types in the API

OCI formats are compatible with Docker formats, so these types can be used with corresponding Docker manifests.

Fixes #23828
Fixes #32351

@annelo-msft annelo-msft requested a review from lmolkova January 25, 2023 00:51
@annelo-msft annelo-msft mentioned this pull request Jan 25, 2023
Closed
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.Containers.ContainerRegistry

@annelo-msft annelo-msft mentioned this pull request Jan 25, 2023
Closed
lmolkova
lmolkova reviewed Jan 27, 2023
View reviewed changes
Copy link
Member

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few ideas for API improvements to consider.

@ShivangiReja
Copy link
Member

LGTM

@annelo-msft annelo-msft merged commit e76b0f0 into Azure:main Jan 31, 2023
@timovv timovv mentioned this pull request Feb 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmolkova lmolkova lmolkova left review comments

@ShivangiReja ShivangiReja ShivangiReja approved these changes

@KrzysztofCwalina KrzysztofCwalina Awaiting requested review from KrzysztofCwalina

@tg-msft tg-msft Awaiting requested review from tg-msft

@pallavit pallavit Awaiting requested review from pallavit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Deserialization throws exception [ACR] [BlobClient] Add support for non-OCI Manifests
4 participants
@annelo-msft @azure-sdk @ShivangiReja @lmolkova