Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AzureMonitorExporter] fix test dependency #33554

Merged
merged 2 commits into from
Jan 18, 2023
Merged

[AzureMonitorExporter] fix test dependency #33554

merged 2 commits into from
Jan 18, 2023

Conversation

TimothyMothra
Copy link
Contributor

@TimothyMothra TimothyMothra commented Jan 17, 2023 •
edited
Loading

Fixes #33403

Changes

  • add dependency Microsoft.AspNetCore.Mvc.Testing for net7.0
  • update dependency Microsoft.AspNetCore.Mvc.Testing for net6.0
  • remove dependency Microsoft.AspNetCore.Mvc.Testing for netcoreapp3.1
  • enable skipped tests (disabled in Drop netcoreapp3.1, add net7.0 support #32814)

@TimothyMothra TimothyMothra added the Monitor - Exporter Monitor OpenTelemetry Exporter label Jan 17, 2023
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

vishweshbankwar
vishweshbankwar approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@vishweshbankwar vishweshbankwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TimothyMothra TimothyMothra enabled auto-merge (squash) January 17, 2023 23:46
@TimothyMothra TimothyMothra merged commit 830a602 into main Jan 18, 2023
@TimothyMothra TimothyMothra deleted the tilee/33403_fixtest branch January 18, 2023 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishweshbankwar vishweshbankwar vishweshbankwar approved these changes

@reyang reyang reyang approved these changes

@cijothomas cijothomas cijothomas approved these changes

@rajkumar-rangaraj rajkumar-rangaraj Awaiting requested review from rajkumar-rangaraj rajkumar-rangaraj is a code owner

Assignees
No one assigned
Labels
Monitor - Exporter Monitor OpenTelemetry Exporter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some Azure.Monitor.OpenTelemetry.Exporter tests fail under net7.0
5 participants
@TimothyMothra @azure-sdk @cijothomas @reyang @vishweshbankwar