Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AzureMonitorExporter] nullable enable #33166

Merged
merged 3 commits into from
Dec 23, 2022
Merged

Conversation

TimothyMothra
Copy link
Contributor

@TimothyMothra TimothyMothra commented Dec 23, 2022

Towards #34013

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

Changes

  • update Directory.Build.props
    • nullable enable
      this turns on nullable for all projects
  • add #nullable disable to any classes with errors
    there were over 400 violations. these will need to be individually addressed.

@TimothyMothra TimothyMothra enabled auto-merge (squash) December 23, 2022 00:12
@TimothyMothra TimothyMothra merged commit 59a1f21 into main Dec 23, 2022
@TimothyMothra TimothyMothra deleted the tilee/nullable_enable branch December 23, 2022 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Monitor - Exporter Monitor OpenTelemetry Exporter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants