Azure Communication Services (ACS) Email .NET SDK (Public Preview 2 before GA) #33110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
… prevent apiview from being generated.
apattath
changed the title
|
@tg-msft @KrzysztofCwalina - could you please review this PR? We are hoping to release this by next week. |
|
To my knowledge, the ACS team has rights to the repository and have been handling reviews for Communication packages. @petrsvihlik: Would you be so kind as to help engage the right ACS folks here? |
|
@m-nash: Would you please review the autorest configuration? |
|
@jsquire - adding @DominikMe, @mbakalov from the ACS Side who were engaged with this SDK review. |
pallavit
reviewed
Feb 27, 2023
pallavit
reviewed
Feb 27, 2023
pallavit
reviewed
Feb 27, 2023
sdk/communication/Azure.Communication.Email/src/CommunicationEmailModelFactory.cs
Show resolved
Hide resolved
kagbakpem
approved these changes
Feb 27, 2023
…into individual files, fix links in md files
I believe @yogeshmo and @kagbakpem are the code owners of the Email service. If that's right, could you folks also update the https://github.com/Azure/azure-sdk-for-net/blob/main/.github/CODEOWNERS ? |
m-nash
reviewed
Feb 28, 2023
sdk/communication/Azure.Communication.Email/src/EmailClientOptions.cs
Outdated
Show resolved
Hide resolved
sdk/communication/Azure.Communication.Email/src/Generated/Models/ErrorDetail.cs
Show resolved
Hide resolved
sdk/communication/Azure.Communication.Email/src/Generated/EmailModelFactory.cs
Show resolved
Hide resolved
sdk/communication/Azure.Communication.Email/api/Azure.Communication.Email.netstandard2.0.cs
Show resolved
Hide resolved
m-nash
reviewed
Mar 1, 2023
sdk/communication/Azure.Communication.Email/src/EmailClientBuilderExtensions.cs
Show resolved
Hide resolved
m-nash
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.
This PR is for a new public preview version of Azure Communication Services Email SDK. This version is planned to be the last preview version before we go to GA next month. So, please consider this as GA review itself.
The APIView for this SDK is here: https://apiview.dev/Assemblies/Review/10d44d4ede934894a2f3661bec7758ce?revisionId=c2336304638a46dab9a5c462d41f181c&doc=False#Azure.Communication.Email.EmailMessage
The swagger PR is here: Azure/azure-rest-api-specs#21841