[Azure.Monitor.Ingestion] Update DPG Upload Parameter #32762
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisha-bhatia
requested review from
KrzysztofCwalina,
tg-msft and
sameergMS
as code owners
nisha-bhatia
added
Client
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
| @@ -192,5 +192,34 @@ public async Task ValidInputFromObjectAsJsonNoBatchingAsync() | |||
| Assert.AreEqual(204, response.Status); | |||
| Assert.IsFalse(response.IsError); | |||
| } | |||
|
|
|||
| [Test] | |||
| public async Task ValidInputGzippedNoBatchingAsync() | |||
There was a problem hiding this comment.
Can we also add a test where the protocol method is called without a Gzipped payload, and the content-encoding is left blank?
| /// <param name="ruleId"> The immutable Id of the Data Collection Rule resource. </param> | ||
| /// <param name="streamName"> The streamDeclaration name as defined in the Data Collection Rule. </param> | ||
| /// <param name="content"> The content to send as the body of the request. Details of the request body schema are in the Remarks section below. </param> | ||
| /// <param name="contentEncoding"> The ContentEncoding of the content. If content is gzipped, put "gzip". Default value is null. </param> |
There was a problem hiding this comment.
Can we explicitly mention that the library will not apply any compression to the passed in data for this method?
We should mention in the convenience method docs that the data will be gzipped.
JoshLove-msft
approved these changes
Nov 30, 2022
|
@nisha-bhatia this PR has been open for a while, are we planning to merge this? |
|
This PR can be closed. |
scottaddie
added
Monitor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.