Fixing Repatability headers + Tests + Bugs for HMAC in custom headers #31993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
minwoolee-msft
commented
Oct 25, 2022
minwoolee-msft
commented
- Fixing RepeatabilityHeaders: Allow null to be passed (Do not send repeataiblity headers)
- Auto-create repeatabilityHeaders by default
- Updated CustomeHMACHeaders to allow rawId in HMAC authentication (See this: 5c0a1b8)
- Updated all tests and re-recorded based on changes
…epeataiblity headers) - Auto-create repeatabilityHeaders by default - Updated CustomeHMACHeaders to allow rawId in HMAC authentication - Updated all tests and re-recorded based on changes
minwoolee-msft
requested review from
sarkar-rajarshi,
juntuchen-msft and
yyw-msft
ghost
added
the
minwoolee-msft
requested review from
KrzysztofCwalina and
tg-msft
as code owners
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
yyw-msft
reviewed
Oct 25, 2022
sdk/communication/Azure.Communication.CallAutomation/src/CallConnection.cs
Outdated
Show resolved
Hide resolved
yyw-msft
reviewed
Oct 25, 2022
sdk/communication/Azure.Communication.CallAutomation/src/CallConnection.cs
Outdated
Show resolved
Hide resolved
yyw-msft
reviewed
Oct 25, 2022
sdk/communication/Azure.Communication.CallAutomation/src/Models/AddParticipantsOptions.cs
Show resolved
Hide resolved
Initializing repeatability headers in all options
yyw-msft
approved these changes
Oct 25, 2022
sofiar-msft
pushed a commit
to sofiar-msft/azure-sdk-for-net
that referenced
this pull request
Dec 7, 2022
…Azure#31993) * - Fixing RepeatabilityHeaders: Allow null to be passed (Do not send repeataiblity headers) - Auto-create repeatabilityHeaders by default - Updated CustomeHMACHeaders to allow rawId in HMAC authentication - Updated all tests and re-recorded based on changes * Updating API doc * Fixing hangup + repeatability headers Initializing repeatability headers in all options * Fixing Tests + recorded tests Co-authored-by: Min Woo Lee 🧊 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.