Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL new capabilities, moved operations, and type fixes #3126

Merged
merged 4 commits into from
Apr 25, 2017

Conversation

jaredmoo
Copy link
Contributor

@jaredmoo jaredmoo commented Apr 24, 2017

Description

  • Added new elastic pool capabilities APIs
  • Moved SqlManagementClient.ListOperations() to SqlManagementClient.Operations.List() as per Swagger team guidance (breaking change)
  • Various type fixes (breaking changes):
    • Database.DatabaseId: string -> Guid
    • Database.RecoveryServicesRecoveryPointResourceId: DateTime -> string
    • ElasticPoolActivity.OperationId: string -> Guid
    • MaxSizeCapability.Limit: long? -> long
    • ServiceObjective.IsDefault: bool? -> bool
    • ServiceObjective.IsSystem: bool? -> bool
    • ServiceObjective.Enabled: bool? -> bool
    • ServiceObjectiveCapability.Id: string -> Guid
    • ServiceTierAdvisor.Confidence: double? -> double
    • SloUsageMetric.ServiceLevelObjectiveId: Guid? -> Guid
    • SloUsageMetric.InRangeTimeRatio: double? -> double
  • SloUsageMetric properties are now all readonly (breaking change)

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as a link to the swagger spec, used to generate the code.
  • The project.json and AssemblyInfo.cs files have been updated with the new version of the SDK.

  - Database.DatabaseId: string -> Guid
  - Database.RecoveryServicesRecoveryPointResourceId: DateTime -> string
  - ElasticPoolActivity.OperationId: string -> Guid
  - MaxSizeCapability.Limit: long? -> long
  - ServiceObjective.IsDefault: bool? -> bool
  - ServiceObjective.IsSystem: bool? -> bool
  - ServiceObjective.Enabled: bool? -> bool
  - ServiceObjectiveCapability.Id: string -> Guid
  - ServiceTierAdvisor.Confidence: double? -> double
  - SloUsageMetric.ServiceLevelObjectiveId: Guid? -> Guid
  - SloUsageMetric.InRangeTimeRatio: double? -> double
- SloUsageMetric properties are now all readonly (breaking change)
Copy link
Member

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing test coverage for the new "ElasticPool" feature?

@@ -1,5 +1,5 @@
{
"version": "1.2.0-preview",
"version": "1.3.0-preview",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaredmoo post migration, we no longer need project.json, global.json and *.xproj.
These might have been left around if I found it will be useful to reference what package references were used earlier prior to migration.
If everything looks good, you can delete these files.

These are no longer used due to the build migration.
@jaredmoo
Copy link
Contributor Author

jaredmoo commented Apr 24, 2017

@shahabhijeet shahabhijeet merged commit e5f49e5 into Azure:vs17Dev Apr 25, 2017
@jaredmoo jaredmoo deleted the sqltypefixes branch June 7, 2017 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants