Removed storage dependency on FxCopAnalyzers reference and NUnit in Storage AesGcm Tests when upgrading to VS2022 17.3 #30453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…regarding upgrade to VS2022 17.3
amnguye
requested review from
seanmcc-msft,
jaschrep-msft and
tg-msft
as code owners
ghost
added
the
jaschrep-msft
approved these changes
Aug 10, 2022
…d props and Nunuit in AcmGcm tests
amnguye
changed the title
|
API change check API changes are not detected in this pull request. |
seanmcc-msft
approved these changes
Aug 11, 2022
sofiar-msft
pushed a commit
to sofiar-msft/azure-sdk-for-net
that referenced
this pull request
Dec 7, 2022
…torage AesGcm Tests when upgrading to VS2022 17.3 (Azure#30453) * Undo NoWarn, removed double FxCopAnalyzer Reference in directory build props and Nunuit in AcmGcm tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See github discussion dotnet/sdk#24747 (comment)This NoWarn is added to mitigate this issue for the storage SDK when upgrading to Visual Studio 2022 17.3.0. Without it we cannot build while using 17.3.0. Downgrading will run into a different bug where we cannot load various test projects in the storage solution.When upgrading to Visual Studio 2022 17.3.0, it pointed out double dependencies we had in the storage solutions. Removed the FxCopAnalyzer dependencies from the storage Directory.Build.props file, since it's in the repo wide file and the NUnit dependency in the AesGcm.Tests csproj file.