[SQL] Generate SDK for ManagedDatabaseRestoreDetails and ManagedDatabase #30126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ostojicb
changed the title
ostojicb
requested review from
fengzhou-msft,
archerzz,
ArcturusZhang,
Yao725 and
ArthurMa1978
as code owners
ostojicb
commented
Aug 29, 2022
There was a problem hiding this comment.
pipeline err seems a bit unrelated (not sql sdk)
With a base path length of 49 the following file path exceed the allow path length of 260 characters
sdk\cognitiveservices\Azure.ResourceManager.CognitiveServices\tests\SessionRecords\CognitiveServicesPrivateEndpointConnectionCollectionTests\CognitiveServicesPrivateEndpointConnectionCollectionApiTests()Async.json
Some file paths are too long. Please reduce path lengths
##[error]The process 'C:\hostedtoolcache\windows\Python\3.6.8\x64\python.exe' failed with exit code 1
Finishing: Analyze Path Lengths
ArthurMa1978
reviewed
Sep 1, 2022
sdk/sqlmanagement/Microsoft.Azure.Management.Sql/src/Microsoft.Azure.Management.Sql.csproj
Show resolved
Hide resolved
should contact engsys team to fix it |
Not sure who exactly should I ping, I see those tests were added by @mcgallan in #30267 |
archerzz
approved these changes
Sep 7, 2022
sofiar-msft
pushed a commit
to sofiar-msft/azure-sdk-for-net
that referenced
this pull request
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping SDK per Azure/azure-rest-api-specs#19955
Why track1? - PowerShell. Track 2 is not yet supported, and we need to update existing cmdlets
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.