-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Azure.ResourceManager.AppPlatform #29059
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurMa1978
requested review from
chidozieononiwu,
weshaggard,
benbp,
KrzysztofCwalina,
tg-msft,
m-nash,
fengzhou-msft,
archerzz,
ArcturusZhang and
Yao725
as code owners
June 1, 2022 08:58
/azp run prepare-pipelines |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run net - appplatform - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
API change check APIView has identified API level changes in this PR and created following API reviews. |
...rm/Azure.ResourceManager.AppPlatform/api/Azure.ResourceManager.AppPlatform.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
...rm/Azure.ResourceManager.AppPlatform/api/Azure.ResourceManager.AppPlatform.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
...rm/Azure.ResourceManager.AppPlatform/api/Azure.ResourceManager.AppPlatform.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
Yao725
reviewed
Jun 2, 2022
sdk/appplatform/Azure.ResourceManager.AppPlatform/src/Generated/AppResource.cs
Outdated
Show resolved
Hide resolved
sdk/appplatform/Azure.ResourceManager.AppPlatform/src/Generated/Models/BuildCollection.cs
Outdated
Show resolved
Hide resolved
sdk/appplatform/Azure.ResourceManager.AppPlatform/src/Generated/BuildResource.cs
Outdated
Show resolved
Hide resolved
sdk/appplatform/Azure.ResourceManager.AppPlatform/src/Generated/BuilderResource.cs
Outdated
Show resolved
Hide resolved
...platform/Azure.ResourceManager.AppPlatform/src/Generated/Models/BuilderResourceCollection.cs
Outdated
Show resolved
Hide resolved
...tform/Azure.ResourceManager.AppPlatform/src/Generated/Models/CheckNameAvailabilityContent.cs
Outdated
Show resolved
Hide resolved
...atform/Azure.ResourceManager.AppPlatform/src/Generated/Models/CheckNameAvailabilityResult.cs
Outdated
Show resolved
Hide resolved
sdk/appplatform/Azure.ResourceManager.AppPlatform/src/Generated/Models/ResourceSku.cs
Outdated
Show resolved
Hide resolved
sdk/appplatform/Azure.ResourceManager.AppPlatform/src/Generated/Models/ResourceSku.cs
Outdated
Show resolved
Hide resolved
sdk/appplatform/Azure.ResourceManager.AppPlatform/src/Generated/Models/SsoProperties.cs
Show resolved
Hide resolved
benbp
reviewed
Jun 2, 2022
Yao725
approved these changes
Jun 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, it looks good to me, still a few minor comments, thanks!
...pplatform/Azure.ResourceManager.AppPlatform/src/Generated/Models/ResourceUploadDefinition.cs
Outdated
Show resolved
Hide resolved
sdk/appplatform/Azure.ResourceManager.AppPlatform/src/Generated/Models/DiagnosticParameters.cs
Outdated
Show resolved
Hide resolved
sdk/appplatform/Azure.ResourceManager.AppPlatform/src/Generated/AppDeploymentResource.cs
Outdated
Show resolved
Hide resolved
...tform/Azure.ResourceManager.AppPlatform/src/Generated/Models/CustomPersistentDiskResource.cs
Outdated
Show resolved
Hide resolved
sdk/appplatform/Azure.ResourceManager.AppPlatform/src/Generated/Models/Error.cs
Outdated
Show resolved
Hide resolved
...pplatform/Azure.ResourceManager.AppPlatform/src/Generated/Models/SupportedRuntimePlatform.cs
Outdated
Show resolved
Hide resolved
sdk/appplatform/Azure.ResourceManager.AppPlatform/src/Generated/Models/SupportedRuntimeValue.cs
Show resolved
Hide resolved
sarkar-rajarshi
pushed a commit
to sarkar-rajarshi/azure-sdk-for-net
that referenced
this pull request
Jun 10, 2022
* Initial Azure.ResourceManager.AppPlatform * Update api sig * Update spell check * Update the `CheckNameAvailability` func name * Rename `CheckNameAvailabilityContent` and `CheckNameAvailabilityResult` * Another bunch of directives * Renames... * Change the template path * renames...
zhihaoxue
pushed a commit
to zhihaoxue/azure-sdk-for-net
that referenced
this pull request
Jul 27, 2022
* Initial Azure.ResourceManager.AppPlatform * Update api sig * Update spell check * Update the `CheckNameAvailability` func name * Rename `CheckNameAvailabilityContent` and `CheckNameAvailabilityResult` * Another bunch of directives * Renames... * Change the template path * renames...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.