Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove if statement in ci.yml #28794

Merged
merged 2 commits into from
May 18, 2022
Merged

remove if statement in ci.yml #28794

merged 2 commits into from
May 18, 2022

Conversation

chunyu3
Copy link
Member

@chunyu3 chunyu3 commented May 16, 2022

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

Remove if-statement since we donot have pipeline runs for various engsys related PRs that rely on the template tests as our primary CI gate.

@ghost ghost added the EngSys This issue is impacting the engineering system. label May 16, 2022
sdk/template/ci.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@sima-zhu sima-zhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add the trigger of "eng/common" under pr triggers as well. It is at #L23

@chunyu3 chunyu3 requested a review from benbp May 18, 2022 01:00
@chunyu3 chunyu3 dismissed sima-zhu’s stale review May 18, 2022 01:10

I have applied the change. But I cannot find out where to close the change request to unblock merge. So I dismiss the change as workaround.

@chunyu3 chunyu3 merged commit 796f8d0 into Azure:main May 18, 2022
sarkar-rajarshi pushed a commit to sarkar-rajarshi/azure-sdk-for-net that referenced this pull request Jun 10, 2022
* remove if statement

* add eng/common on pr trigger
paterasMSFT pushed a commit that referenced this pull request Jun 15, 2022
* remove if statement

* add eng/common on pr trigger
@chunyu3 chunyu3 deleted the CIUpate branch July 7, 2022 09:26
zhihaoxue pushed a commit to zhihaoxue/azure-sdk-for-net that referenced this pull request Jul 27, 2022
* remove if statement

* add eng/common on pr trigger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EngSys This issue is impacting the engineering system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants