SDK Client Library for AzureRM.Billing and tests #2838
Conversation
Add the newly generated SDK Client for Azure Resource Management Billing Service and tests.
|
Can one of the admins verify this patch? |
|
Hi @Panda-Wang, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution! TTYL, AZPRBOT; |
|
Can you help to remove the CLA required label as I'm MSFT FTE and should not require CLA? thanks a lot. |
|
@azuresdkci add to whitelist |
1 similar comment
|
@azuresdkci add to whitelist |
|
@azuresdkci test this please |
|
@jlian fyi |
|
@azuresdkci add to whitelist |
| [assembly: AssemblyDescription("Provides management functionality for Microsoft Azure Billing.")] | ||
|
|
||
| [assembly: AssemblyVersion("2.0.0.0")] | ||
| [assembly: AssemblyFileVersion("3.0.0.0")] |
There was a problem hiding this comment.
please align these versions with the project.json file for this project
| [assembly: AssemblyConfiguration("")] | ||
| [assembly: AssemblyCompany("Microsoft")] | ||
| [assembly: AssemblyProduct("Billing.Tests")] | ||
| [assembly: AssemblyCopyright("Copyright � Microsoft Corporation")] |
There was a problem hiding this comment.
� [](start = 40, length = 1)
please change this sign to '(C)'
| Project("{8BB2217D-0F2D-49D1-97BC-3654ED321F3B}") = "Microsoft.Rest.ClientRuntime.Azure.Authentication", "..\..\ClientRuntime\Microsoft.Rest.ClientRuntime.Azure.Authentication\Microsoft.Rest.ClientRuntime.Azure.Authentication.xproj", "{6319205D-BBFC-4150-BEAE-31B1C9B911DD}" | ||
| EndProject | ||
| Project("{8BB2217D-0F2D-49D1-97BC-3654ED321F3B}") = "TestFramework", "..\..\TestFramework\Microsoft.Rest.ClientRuntime.Azure.TestFramework\TestFramework.xproj", "{C4C4E1C8-B99D-4D90-8C27-6D0C0A268BA5}" | ||
| EndProject |
There was a problem hiding this comment.
you do not need to reference all these projects. just Microsoft.Azure.Management.Billing and Billing.Tests should be enough.
… should not compare time with current time
| </PropertyGroup> | ||
| <Import Project="$(VSToolsPath)\DotNet\Microsoft.DotNet.Props" Condition="'$(VSToolsPath)' != ''" /> | ||
| <PropertyGroup Label="Globals"> | ||
| <ProjectGuid>4ee713c9-0164-4a9d-b573-5552c76f3dda</ProjectGuid> |
There was a problem hiding this comment.
@Panda-Wang please make sure these guids are unique. In case if you are using another test project to model your test project
There was a problem hiding this comment.
good catch! i did copy from CDN and forgot to update GUID.
| public class InvoicesTests : TestBase | ||
| { | ||
| const string DownloadUrlExpand = "downloadUrl"; | ||
| const string RangeFilter = "invoicePeriodEndDate ge 2017-01-31 and invoicePeriodEndDate le 2017-02-28"; |
There was a problem hiding this comment.
@Panda-Wang is this still valid in sdk? If yes then the SDK and PS developer experience is different.
You are fine with this difference in functionality?
There was a problem hiding this comment.
yes, the filter is valid in SDK. For PS, we decided to have different behavior for the 1st release. If customer gives feedback on requesting date range filter, we will add it in later release. The reason we dont want to add it in 1st release is because we think it's a bit confusing and since we only have very few data (3 month data) for now, the data range filter might not be very useful.
Add the newly generated SDK Client for Azure Resource Management Billing
Service and tests.
Description
We are going to ship Billing Resource Provider via ARM as our first preview release. Here's the swagger spec: https://raw.githubusercontent.com/Azure/azure-rest-api-specs/master/arm-billing/2017-02-27-preview/swagger/billing.json
The SDK library was generated based on the swagger and tests have been added as requested.
Here's the link to internal code review: http://codeflow/Client/CodeFlow2010.application?server=http://codeflow/Services/DiscoveryService.svc&review=caixiaw-ad44ccf2cfab428090be3046975f2e7f
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
project.jsonandAssemblyInfo.csfiles have been updated with the new version of the SDK.