Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eventhub Stress Test Onboarding #28320
Eventhub Stress Test Onboarding #28320
Changes from 1 commit
31ef454
2c97223
7e67bda
bcf27f8
32d1a79
99f6135
d68b9a8
3bb3cfc
72de30e
8e3ee3f
9c24f75
7f63000
2ee7f56
52bfa86
78cc71b
a798c8f
25ec412
f16edd8
8c6ac6d
dbb7258
1013982
ae204ce
bf4230b
925888e
a86d0a6
518aa6d
eafe6a5
da89c76
c5cd920
3dab67c
02ce4ee
2161001
ca66f38
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This png fails to load on the readme.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loads for me; it's one of our tracking pixels, so it will look like nothing. @benbp: Are you seeing it 404 or just nothing show up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsquire it looks like the problem is a missing
F
character in the url encoding:EventHubs %2 stress
. I added a commit suggestion below.It looks like this on the readme, that's how I caught it:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahhh.... I see it now. Yeah, that's on me. Thanks for the catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chrome/Edge do a nice job of fixing the malformed encoding. Checking in the browser worked.