Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SDKs with new autorest.csharp version #27447

Merged
merged 24 commits into from
Mar 15, 2022
Merged

Update SDKs with new autorest.csharp version #27447

merged 24 commits into from
Mar 15, 2022

Conversation

fengzhou-msft
Copy link
Member

@fengzhou-msft fengzhou-msft commented Mar 9, 2022 •
edited
Loading

The changes included are type renaming and removal of ErrorResponse model from common type.

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@fengzhou-msft fengzhou-msft added the Mgmt This issue is related to a management-plane library. label Mar 9, 2022
@ghost ghost added App Configuration Azure.ApplicationModel.Configuration Communication Event Hubs labels Mar 9, 2022
@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.AppConfiguration. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.EventHubs. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.CosmosDB. You can review API changes here

API changes

+         public string CassandraColumnType { get; set; }
-         public string Type { get; set; }

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.ConnectedVMwarevSphere. You can review API changes here

API changes

+         public string ExtendedLocationType { get; set; }
-         public string Type { get; set; }
+         public string MachineExtensionInstanceViewType { get; }
-         public string Type { get; }
+         public string MachineExtensionUpdatePropertiesType { get; set; }
-         public string Type { get; set; }
+         public string ResourceStatusType { get; }
-         public string Type { get; }
+         public ScsiControllerType? ScsiControllerType { get; }
-         public ScsiControllerType? Type { get; }

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.Cdn. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.Communication. You can review API changes here

API changes

-         public NameAvailabilityOptions(string type, string name);
+         public NameAvailabilityOptions(string nameAvailabilityOptionsType, string name);
-         public string Type { get; }
+         public string NameAvailabilityOptionsType { get; }

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.Dashboard. You can review API changes here

API changes

+         public IdentityType? IdentityType { get; set; }
-         public IdentityType? Type { get; set; }

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.Compute. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.Network. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.EventHubs. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.Storage. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.Sql. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.Cdn. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.WebPubSub. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.Analytics.Purview.Catalog. You can review API changes here

API changes

-         public virtual Operation<BinaryData> ImportGlossaryTermsViaCsv(bool waitForCompletion, string glossaryGuid, RequestContent content, bool? includeTermHierarchy = null, RequestContext context = null);
-         public virtual Task<Operation<BinaryData>> ImportGlossaryTermsViaCsvAsync(bool waitForCompletion, string glossaryGuid, RequestContent content, bool? includeTermHierarchy = null, RequestContext context = null);
-         public virtual Operation<BinaryData> ImportGlossaryTermsViaCsvByGlossaryName(bool waitForCompletion, string glossaryName, RequestContent content, bool? includeTermHierarchy = null, RequestContext context = null);
-         public virtual Task<Operation<BinaryData>> ImportGlossaryTermsViaCsvByGlossaryNameAsync(bool waitForCompletion, string glossaryName, RequestContent content, bool? includeTermHierarchy = null, RequestContext context = null);
+         public virtual Operation<BinaryData> ImportGlossaryTermsViaCsv(WaitUntil waitUntil, string glossaryGuid, RequestContent content, bool? includeTermHierarchy = null, RequestContext context = null);
+         public virtual Task<Operation<BinaryData>> ImportGlossaryTermsViaCsvAsync(WaitUntil waitUntil, string glossaryGuid, RequestContent content, bool? includeTermHierarchy = null, RequestContext context = null);
+         public virtual Operation<BinaryData> ImportGlossaryTermsViaCsvByGlossaryName(WaitUntil waitUntil, string glossaryName, RequestContent content, bool? includeTermHierarchy = null, RequestContext context = null);
+         public virtual Task<Operation<BinaryData>> ImportGlossaryTermsViaCsvByGlossaryNameAsync(WaitUntil waitUntil, string glossaryName, RequestContent content, bool? includeTermHierarchy = null, RequestContext context = null);

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.AI.Language.QuestionAnswering. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.Verticals.AgriFood.Farming. You can review API changes here

fengzhou-msft
fengzhou-msft commented Mar 14, 2022
View reviewed changes
Yao725
Yao725 reviewed Mar 14, 2022
View reviewed changes
Copy link
Member

@Yao725 Yao725 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cdn, DeviceUpdate, EventHubs and ServiceBus LGTM, thanks!

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.AppConfiguration. You can review API changes here

API changes

-         public CheckNameAvailabilityParameters(string name, ConfigurationResourceType type);
+         public CheckNameAvailabilityParameters(string name, ConfigurationResourceType resourceType);
-         public ConfigurationResourceType Type { get; }
+         public ConfigurationResourceType ResourceType { get; }

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.KeyVault. You can review API changes here

API changes

-         public string Type { get; }
+         public string ResourceType { get; }

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.WebPubSub. You can review API changes here

API changes

+         public ManagedIdentityType? ManagedIdentityType { get; set; }
-         public ManagedIdentityType? Type { get; set; }
-         public NameAvailabilityParameters(string type, string name);
+         public NameAvailabilityParameters(string resourceType, string name);
-         public string Type { get; }
+         public string ResourceType { get; }
-         public string Type { get; set; }
+         public string ShareablePrivateLinkPropertiesType { get; set; }
-         public UpstreamAuthType? Type { get; set; }
+         public UpstreamAuthType? UpstreamAuthType { get; set; }

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.DeviceUpdate. You can review API changes here

API changes

-         public string Type { get; set; }
+         public string ResourceType { get; set; }

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.Sql. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.Communication. You can review API changes here

API changes

-         public NameAvailabilityOptions(string type, string name);
+         public NameAvailabilityOptions(string resourceType, string name);
-         public string Type { get; }
+         public string ResourceType { get; }

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.Storage. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.Compute. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.ConnectedVMwarevSphere. You can review API changes here

archerzz
archerzz reviewed Mar 14, 2022
View reviewed changes
Copy link
Member

@archerzz archerzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

network, cosmosdb, and storage look fine. Thanks.

@fengzhou-msft fengzhou-msft mentioned this pull request Mar 14, 2022
Closed
@fengzhou-msft fengzhou-msft merged commit 873de4b into main Mar 15, 2022
@fengzhou-msft fengzhou-msft deleted the bump_version_with_type_rename branch March 15, 2022 02:59
This was linked to issues Mar 15, 2022
Improve ResponseError #27325
Closed
Renaming any properties that use the name “Type” as this conflicts with the dotnet concept of a Type #27297
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archerzz archerzz archerzz left review comments

@Yao725 Yao725 Yao725 left review comments

@m-nash m-nash m-nash approved these changes

@chidozieononiwu chidozieononiwu Awaiting requested review from chidozieononiwu

@weshaggard weshaggard Awaiting requested review from weshaggard

@benbp benbp Awaiting requested review from benbp

@KrzysztofCwalina KrzysztofCwalina Awaiting requested review from KrzysztofCwalina KrzysztofCwalina is a code owner

@tg-msft tg-msft Awaiting requested review from tg-msft tg-msft is a code owner

@ArcturusZhang ArcturusZhang Awaiting requested review from ArcturusZhang ArcturusZhang is a code owner

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978 ArthurMa1978 is a code owner

Assignees
No one assigned
Labels
App Configuration Azure.ApplicationModel.Configuration Communication Event Hubs Mgmt This issue is related to a management-plane library.
Projects
None yet
Milestone
No milestone
6 participants
@fengzhou-msft @azure-sdk @ArthurMa1978 @archerzz @m-nash @Yao725