Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Conversations live tests #26346

Merged
merged 4 commits into from
Jan 14, 2022
Merged

Enable Conversations live tests #26346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a1d9ae0
Enable Conversations live tests
heaths Jan 13, 2022
2780279
Fix environment variables
heaths Jan 14, 2022
46422c6
Temporarily disable some tests
heaths Jan 14, 2022
255b4e9
Fix AnswersFollowupKnowledgeBaseQuestion results
heaths Jan 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...tivelanguage/Azure.AI.Language.Conversations/tests/ConversationAnalysisClientLiveTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ public async Task AnalyzeConversation()
}

[RecordedTest]
[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/26379")]
public async Task AnalyzeConversationWithLanguage()
{
AnalyzeConversationOptions options = new AnalyzeConversationOptions()
Expand Down
2 changes: 2 additions & 0 deletions .../Azure.AI.Language.Conversations/tests/Samples/Sample3_AnalyzeConversationWithLanguage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ public partial class ConversationAnalysisClientSamples
{
[SyncOnly]
[RecordedTest]
[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/26379")]
public void AnalyzeConversationWithLanguage()
{
ConversationAnalysisClient client = Client;
Expand Down Expand Up @@ -49,6 +50,7 @@ public void AnalyzeConversationWithLanguage()

[AsyncOnly]
[RecordedTest]
[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/26379")]
public async Task AnalyzeConversationWithLanguageAsync()
{
ConversationAnalysisClient client = Client;
Expand Down
2 changes: 1 addition & 1 deletion ...ivelanguage/Azure.AI.Language.QuestionAnswering/tests/QuestionAnsweringClientLiveTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public async Task AnswersFollowupKnowledgeBaseQuestion()
{
Size = 3,
UserId = "sd53lsY=",
ConfidenceThreshold = 0.2,
ConfidenceThreshold = 0.5,
AnswerContext = new(27)
{
PreviousQuestion = "How long should my Surface battery last?",
Expand Down
119 changes: 57 additions & 62 deletions ...SessionRecords/QuestionAnsweringClientLiveTests/AnswersFollowupKnowledgeBaseQuestion.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

119 changes: 57 additions & 62 deletions ...onRecords/QuestionAnsweringClientLiveTests/AnswersFollowupKnowledgeBaseQuestionAsync.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

52 changes: 28 additions & 24 deletions sdk/cognitivelanguage/test-resources.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,29 +20,33 @@
"variables": {},
"resources": [],
"outputs": {
"CONVERSATIONS_KEY": {
"type": "string",
"value": ""
},
"CONVERSATIONS_PROJECT": {
"type": "string",
"value": ""
},
"CONVERSATIONS_URI": {
"type": "string",
"value": ""
},
"QUESTIONANSWERING_ENDPOINT": {
"type": "string",
"value": "https://wuppe.api.cognitive.microsoft.com"
},
"QUESTIONANSWERING_KEY": {
"type": "string",
"value": ""
},
"QUESTIONANSWERING_PROJECT": {
"type": "string",
"value": "190a9e13-8ede-4e4b-a8fd-c4d7f2aeab6c"
}
// TODO: Uncomment and define when test resources are deployed dynamically.
// Developers should define the following environment variables to run tests locally.
// Live test CIs will use environment variables defined via tests.yml.
//
// "CONVERSATIONS_KEY": {
// "type": "string",
// "value": ""
// },
// "CONVERSATIONS_PROJECT": {
// "type": "string",
// "value": "antischOne"
// },
// "CONVERSATIONS_URI": {
// "type": "string",
// "value": ""
// },
// "QUESTIONANSWERING_ENDPOINT": {
// "type": "string",
// "value": "https://wuppe.api.cognitive.microsoft.com"
// },
// "QUESTIONANSWERING_KEY": {
// "type": "string",
// "value": ""
// },
// "QUESTIONANSWERING_PROJECT": {
// "type": "string",
// "value": "190a9e13-8ede-4e4b-a8fd-c4d7f2aeab6c"
// }
}
}
Loading