update description for all properties, new autorest client and vnet get on vnet peering from vnet #2621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @DeepakRajendranMsft, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution! TTYL, AZPRBOT; |
cormacpayne
suggested changes
Dec 7, 2016
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "version": "8.1.0-preview", | |||
| "version": "9.0.0-preview", | |||
There was a problem hiding this comment.
@DeepakRajendranMsft is there a breaking change in this PR? If you are just regenerating the code based on a newer version of AutoRest, you should bump the version to 8.1.1-preview
| @@ -19,8 +19,8 @@ | |||
| [assembly: AssemblyTitle("Microsoft Azure Network Management Library")] | |||
| [assembly: AssemblyDescription("Provides Microsoft Azure Network management functions for managing the Microsoft Azure Network service.")] | |||
|
|
|||
| [assembly: AssemblyVersion("8.1.0.0")] | |||
| [assembly: AssemblyFileVersion("8.1.0.0")] | |||
| [assembly: AssemblyVersion("9.0.0.0")] | |||
There was a problem hiding this comment.
@DeepakRajendranMsft same comment about version number
| @@ -214,5 +214,160 @@ public void VirtualNetworkCheckIpAddressAvailabilityTest() | |||
| networkManagementClient.VirtualNetworks.Delete(resourceGroupName, vnetName); | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
@DeepakRajendranMsft what new functionality are you trying to test here?
cormacpayne
approved these changes
Dec 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #2530. I have generated the sdk with the latest autorest client
@cormacpayne @markcowl