Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change IMessageWithContentType to MessageWithMetadata #25569

Merged
merged 8 commits into from
Dec 1, 2021

Conversation

JoshLove-msft
Copy link
Member

No description provided.

@azure-sdk
Copy link
Collaborator

API changes have been detected in Microsoft.Azure.Data.SchemaRegistry.ApacheAvro. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.Messaging.ServiceBus. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.Messaging.EventHubs. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.Core.Experimental. You can review API changes here

API changes

+ namespace Azure.Messaging {
+     public abstract class MessageWithMetadata {
+         protected MessageWithMetadata();
+         public abstract string ContentType { get; set; }
+         public abstract BinaryData Data { get; set; }
+     }
+ }

Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; I left a couple of small formatting nits and wanted to consider leaving the body setter for events.

@JoshLove-msft
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@azure-sdk
Copy link
Collaborator

API changes have been detected in Microsoft.Azure.Data.SchemaRegistry.ApacheAvro. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.Messaging.EventHubs. You can review API changes here

API changes

-     public class EventData {
+     public class EventData : MessageWithMetadata {
-         public string ContentType { get; set; }
+         public override string ContentType { get; set; }
+         [EditorBrowsable(EditorBrowsableState.Never)]
+         public override BinaryData Data { get; set; }
-         public AmqpAnnotatedMessage GetRawAmqpMessage();
+         public AmqpAnnotatedMessage GetRawAmqpMessage();

@check-enforcer
Copy link

check-enforcer bot commented Dec 1, 2021

This pull request is protected by Check Enforcer.
For more information about how to run a pipeline against this pull request, see this.

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.Core.Experimental. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.Core.Experimental. You can review API changes here

API changes

+ namespace Azure.Messaging {
+     public abstract class MessageWithMetadata {
+         protected MessageWithMetadata();
+         public abstract string ContentType { get; set; }
+         public abstract BinaryData Data { get; set; }
+         public abstract bool IsReadOnly { get; }
+     }
+ }

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.Messaging.ServiceBus. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.Messaging.EventHubs. You can review API changes here

API changes

-     public class EventData {
+     public class EventData : MessageWithMetadata {
-         public string ContentType { get; set; }
+         public override string ContentType { get; set; }
+         [EditorBrowsable(EditorBrowsableState.Never)]
+         public override BinaryData Data { get; set; }
+         [EditorBrowsable(EditorBrowsableState.Never)]
+         public override bool IsReadOnly { get; }
-         public AmqpAnnotatedMessage GetRawAmqpMessage();
+         public AmqpAnnotatedMessage GetRawAmqpMessage();

@JoshLove-msft JoshLove-msft enabled auto-merge (squash) December 1, 2021 01:31
@JoshLove-msft JoshLove-msft merged commit b8f395e into Azure:main Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants