-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change IMessageWithContentType to MessageWithMetadata #25569
Conversation
sdk/schemaregistry/Microsoft.Azure.Data.SchemaRegistry.ApacheAvro/README.md
Show resolved
Hide resolved
...hemaRegistry.ApacheAvro/api/Microsoft.Azure.Data.SchemaRegistry.ApacheAvro.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
API changes have been detected in |
API changes have been detected in |
API changes have been detected in |
API changes have been detected in API changes + namespace Azure.Messaging {
+ public abstract class MessageWithMetadata {
+ protected MessageWithMetadata();
+ public abstract string ContentType { get; set; }
+ public abstract BinaryData Data { get; set; }
+ }
+ } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; I left a couple of small formatting nits and wanted to consider leaving the body setter for events.
sdk/eventhub/Azure.Messaging.EventHubs/src/Azure.Messaging.EventHubs.csproj
Outdated
Show resolved
Hide resolved
...venthub/Azure.Messaging.EventHubs.Shared/tests/Azure.Messaging.EventHubs.Shared.Tests.csproj
Outdated
Show resolved
Hide resolved
sdk/core/Azure.Core.Experimental/api/Azure.Core.Experimental.netstandard2.0.cs
Show resolved
Hide resolved
/azp run |
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
62bc33a
to
967994a
Compare
API changes have been detected in |
API changes have been detected in API changes - public class EventData {
+ public class EventData : MessageWithMetadata {
- public string ContentType { get; set; }
+ public override string ContentType { get; set; }
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ public override BinaryData Data { get; set; }
- public AmqpAnnotatedMessage GetRawAmqpMessage();
+ public AmqpAnnotatedMessage GetRawAmqpMessage(); |
967994a
to
b983ac0
Compare
This pull request is protected by Check Enforcer. |
API changes have been detected in |
API changes have been detected in API changes + namespace Azure.Messaging {
+ public abstract class MessageWithMetadata {
+ protected MessageWithMetadata();
+ public abstract string ContentType { get; set; }
+ public abstract BinaryData Data { get; set; }
+ public abstract bool IsReadOnly { get; }
+ }
+ } |
API changes have been detected in |
API changes have been detected in API changes - public class EventData {
+ public class EventData : MessageWithMetadata {
- public string ContentType { get; set; }
+ public override string ContentType { get; set; }
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ public override BinaryData Data { get; set; }
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ public override bool IsReadOnly { get; }
- public AmqpAnnotatedMessage GetRawAmqpMessage();
+ public AmqpAnnotatedMessage GetRawAmqpMessage(); |
No description provided.