Add RepairAction property to VMSS AutoRepairs feature #25095

frank-pang-msft · 2021-11-02T23:27:51Z

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

Please open PR in Draft mode if it is:
- Work in progress or not intended to be merged.
- Encountering multiple pipeline failures and working on fixes.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
- Add repair action to automatic repairs api azure-rest-api-specs#16535
I have read the contribution guidelines.
The pull request does not introduce breaking changes.

General Guidelines and Best Practices

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

SDK Generation Guidelines

The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
- N/A
The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.
- Had issues running the UpdatePkg_Version.ps1 command

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

Include updated management metadata.
- N/A
Update AzureRP.props to add/remove version info to maintain up to date API versions.
- Added Compute_2021-11-01

Management plane SDK Troubleshooting

If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.
If the check fails at the Verify Code Generation step, please ensure:
- Do not modify any code in generated folders.
- Do not selectively include/remove generated files in the PR.
- Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
  Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.
Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:
```
  `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`
```

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

Yao725 · 2021-12-02T07:51:41Z

/azp run net - mgmt - ci

azure-pipelines · 2021-12-02T07:51:51Z

Azure Pipelines successfully started running 1 pipeline(s).

Yao725 · 2021-12-02T08:25:59Z

@frank-pang-msft , could you please fix the failed tests?

sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/AutomaticRepairsPolicy.cs

sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/DedicatedHost.cs

AnupVasudevaRao · 2021-12-02T19:34:24Z

sdk/compute/Microsoft.Azure.Management.Compute/tests/VMScaleSetTests/VMScaleSetScenarioTests.cs

+                        Assert.Equal("replace", getResponse.AutomaticRepairsPolicy.RepairAction, ignoreCase: true);
+
+                        // Test other repair actions. Must disable before changing repair action
+                        foreach (string repairAction in new List<string> { "restart", "reimage" })


"restart", "reimage"

as in previous comment, constants (or enums) are preferred

AnupVasudevaRao · 2021-12-02T19:35:03Z

sdk/eng/mgmt/mgmtmetadata/compute_resource-manager.txt

@@ -0,0 +1,15 @@
+Installing AutoRest version: v2
+AutoRest installed successfully.


curious: what is this file for?

it gets generated with SDK generation. Not to worry about. I will take it out if it needs be

grizzlytheodore · 2021-12-02T22:17:21Z

/azp run

azure-pipelines · 2021-12-02T22:17:26Z

Pull request contains merge conflicts.

…ctionToAutoRepairsFeature

sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/RollingUpgradePolicy.cs

sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/DedicatedHostUpdate.cs

* update with api version 2021-11-01 * update with api version 2021-11-01 * update virtualmachine to virtualMachine in swagger * update test to preserve resource group until finally block * test updates and new recordings * update from swagger sync * Added SDK changes for scaling VMSS with PublicIpPrefix (patch updates) (#26031) * Add RepairAction property to VMSS AutoRepairs feature (#25095) * Add RepairAction property to VMSS AutoRepairs feature * Include metadata file * Add session record and updated test * Update TestVMScaleSetScenarioOperations_OrchestrationService.json * Restore files that shouldn't have been changed * Add orchestration service record * Delete compute_resource-manager.txt Co-authored-by: Theodore Chang <[email protected]> * sdk gen (#25670) Co-authored-by: Chase Van Buskirk <[email protected]> * Added sdk changes for vmss vm customization (#25785) * Added sdk changes for vmss vm customization * Added sdk changes for vmss vm customization * init (#25620) Co-authored-by: Theodore Chang <[email protected]> * Initial commit (#25383) * SDK changes for CVM for api-version 2021-11-01 (#25645) * sdk changes for CVM * save changes for securityType and diskSecurityprofile Add PMK scenario * Added recorded file * DedicatedHost Reboot Feature SDK (#25258) * ran autorest on azure-rest-api-specs after adding dhreboot to compute.json * ran autorest again, since i made some swagger changes * created test * renamed reboot to restart * updated swagger, and ran the generate command again to update the sdk * restart test passing. Added recorded test as well * rebuilt sdk with async=true, removed unnecessary line in test, and reran test after change * Adding the new paramaters zone/placementGroupId to ForceRecoveryServiceFabricPlatformUpdateDomainWalk (#25897) * add filter for List VMSS operations (#25802) * fdsaf * generated change * Adding VMScaleSet Flex Filter Test * Update generate.ps1 * add recording Co-authored-by: LexieXie <[email protected]> Co-authored-by: xielexie <[email protected]> * add customizations * fix errors * regenerated from master * fix customization * fix customization * fix a test * new test recordings * change version name * remove unnecessary variable * update recording test * fix changes Co-authored-by: karthikka4820 <[email protected]> Co-authored-by: frank-pang-msft <[email protected]> Co-authored-by: Chase VanBuskirk <[email protected]> Co-authored-by: Chase Van Buskirk <[email protected]> Co-authored-by: Raktima Das <[email protected]> Co-authored-by: kamusta-msft <[email protected]> Co-authored-by: sukodava <[email protected]> Co-authored-by: ms-saypaul <[email protected]> Co-authored-by: vbhasker-msft <[email protected]> Co-authored-by: avjai <[email protected]> Co-authored-by: LexieXie <[email protected]> Co-authored-by: xielexie <[email protected]>

Add RepairAction property to VMSS AutoRepairs feature

f3f3003

frank-pang-msft requested review from archerzz, ArcturusZhang, ArthurMa1978, fengzhou-msft, m-nash and Yao725 as code owners November 2, 2021 23:27

openapi-assignment-bot bot assigned Yao725 Nov 2, 2021

ghost added the Compute label Nov 2, 2021

Include metadata file

91df910

frank-pang-msft requested a review from AlexGhiondea as a code owner November 4, 2021 00:35

Add session record and updated test

3b6b9a1